HADOOP-16611. Make test4tests vote for -0 instead of -1#1523
Closed
Apache9 wants to merge 1 commit intoapache:trunkfrom
Closed
HADOOP-16611. Make test4tests vote for -0 instead of -1#1523Apache9 wants to merge 1 commit intoapache:trunkfrom
Apache9 wants to merge 1 commit intoapache:trunkfrom
Conversation
|
🎊 +1 overall
This message was automatically generated. |
Contributor
|
I actually quite like the -1, as it says "you need a good explanation". If people are submitting patches without tests, they need good explanations. In contrast, we don't worry so much about checkstyle -which is why we're always fighting a losing battle against adherence to the style rules.
|
Contributor
Author
|
OK, htat's fine, will keep it as is. Mind taking a look at HADOOP-16610, i.e. #1527? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.