Skip to content

HADOOP-16611. Make test4tests vote for -0 instead of -1#1523

Closed
Apache9 wants to merge 1 commit intoapache:trunkfrom
Apache9:HADOOP-16611
Closed

HADOOP-16611. Make test4tests vote for -0 instead of -1#1523
Apache9 wants to merge 1 commit intoapache:trunkfrom
Apache9:HADOOP-16611

Conversation

@Apache9
Copy link
Contributor

@Apache9 Apache9 commented Sep 25, 2019

No description provided.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 40 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
0 shelldocs 0 Shelldocs was not available.
+1 @author 0 The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 shadedclient 801 branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 shellcheck 0 There were no new shellcheck issues.
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 827 patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 asflicense 36 The patch does not generate ASF License warnings.
1832
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1523/1/artifact/out/Dockerfile
GITHUB PR #1523
Optional Tests dupname asflicense shellcheck shelldocs
uname Linux d830086273d2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / c89d22d
Max. process+thread count 446 (vs. ulimit of 5500)
modules C: . U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1523/1/console
versions git=2.7.4 maven=3.3.9 shellcheck=0.4.6
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache9 Apache9 changed the title HADOOP-16611 Make test4tests vote for -0 instead of -1 HADOOP-16611. Make test4tests vote for -0 instead of -1 Sep 26, 2019
@steveloughran
Copy link
Contributor

I actually quite like the -1, as it says "you need a good explanation".

If people are submitting patches without tests, they need good explanations.

In contrast, we don't worry so much about checkstyle -which is why we're always fighting a losing battle against adherence to the style rules.

  1. I want people to feel uncomfortable when they submit patches without any tests. Having Yetus complaining about this avoids the personal conflict which arises when are people like me after the tests instead.
  2. And I like to be confident that those patches which I don't review, come with tests too.

@Apache9
Copy link
Contributor Author

Apache9 commented Sep 26, 2019

OK, htat's fine, will keep it as is.

Mind taking a look at HADOOP-16610, i.e. #1527? Thanks.

@Apache9 Apache9 closed this Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants