Skip to content

HADOOP-16705. MBeanInfoBuilder puts unnecessary memory pressure on the system with a debug log#1715

Merged
goiri merged 39 commits intoapache:trunkfrom
lukmajercak:lumajerc/HADOOP-16705
Nov 14, 2019
Merged

HADOOP-16705. MBeanInfoBuilder puts unnecessary memory pressure on the system with a debug log#1715
goiri merged 39 commits intoapache:trunkfrom
lukmajercak:lumajerc/HADOOP-16705

Conversation

@lukmajercak
Copy link
Contributor

@lukmajercak lukmajercak commented Nov 13, 2019

MBeanInfoBuilder's get() method DEBUG logs all the MBeanAttributeInfo attributes that it gathered. This can have a high memory churn that can be easily avoided.

https://issues.apache.org/jira/browse/HADOOP-16705

Lukas Majercak added 30 commits April 27, 2017 14:16
@steveloughran steveloughran self-requested a review November 13, 2019 17:13
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 43 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1221 trunk passed
+1 compile 1152 trunk passed
+1 checkstyle 45 trunk passed
+1 mvnsite 94 trunk passed
+1 shadedclient 943 branch has no errors when building and testing our client artifacts.
+1 javadoc 94 trunk passed
0 spotbugs 136 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 134 trunk passed
-0 patch 179 Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+1 mvninstall 56 the patch passed
+1 compile 1067 the patch passed
+1 javac 1067 the patch passed
+1 checkstyle 42 the patch passed
+1 mvnsite 83 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 842 patch has no errors when building and testing our client artifacts.
+1 javadoc 89 the patch passed
+1 findbugs 131 the patch passed
_ Other Tests _
-1 unit 535 hadoop-common in the patch failed.
+1 asflicense 56 The patch does not generate ASF License warnings.
6732
Reason Tests
Failed junit tests hadoop.fs.shell.TestCopyFromLocal
Subsystem Report/Notes
Docker Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1715/1/artifact/out/Dockerfile
GITHUB PR #1715
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux a418d76d6f4c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / df6b316
Default Java 1.8.0_222
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1715/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1715/1/testReport/
Max. process+thread count 1393 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1715/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@goiri goiri merged commit c73334a into apache:trunk Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants