-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HDFS-16141. Address permission related issues with File / Directory #3232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...s-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirMkdirOp.java
Outdated
Show resolved
Hide resolved
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
Outdated
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
e713d8a to
1e7f847
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
…rtitionedGSet. Contributed by Xing Lin. (apache#3201)
shvachko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TestFileCreation is still failing for me with
[INFO] Running org.apache.hadoop.hdfs.TestFileCreation
[ERROR] Tests run: 25, Failures: 0, Errors: 1, Skipped: 2, Time elapsed: 93.408 s <<< FAILURE! - in org.apache.hadoop.hdfs.TestFileCreation
[ERROR] testFileCreationNamenodeRestart(org.apache.hadoop.hdfs.TestFileCreation) Time elapsed: 9.975 s <<< ERROR!
org.apache.hadoop.ipc.RemoteException(java.lang.AssertionError): Must hold read Lock: key = range key: [1, 16385]
at org.apache.hadoop.util.PartitionedGSet.getPartition(PartitionedGSet.java:133)
at org.apache.hadoop.hdfs.server.namenode.INodeMap.get(INodeMap.java:268)
at org.apache.hadoop.hdfs.server.namenode.FSDirectory.getInode(FSDirectory.java:1625)
at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.isFileDeleted(FSNamesystem.java:5752)
at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.checkLease(FSNamesystem.java:3153)
at org.apache.hadoop.hdfs.server.namenode.FSDirWriteFileOp.analyzeFileState(FSDirWriteFileOp.java:634)
at org.apache.hadoop.hdfs.server.namenode.FSDirWriteFileOp.storeAllocatedBlock(FSDirWriteFileOp.java:238)
at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getAdditionalBlock(FSNamesystem.java:3036)
at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.addBlock(NameNodeRpcServer.java:908)
@prasad-acit do you think we can fix it here?
...s-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirMkdirOp.java
Outdated
Show resolved
Hide resolved
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSMkdirs.java
Outdated
Show resolved
Hide resolved
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSMkdirs.java
Outdated
Show resolved
Hide resolved
I am not facing this issue with 3.1.1 branch. Some issue related restart scenario, let me take a look. I will update on this. |
|
Why 3.1.1 branch? We are using fgl branch here, right? |
|
Thanks @shvachko for review & feedback. I have addressed the comments, can you please take a look? |
|
💔 -1 overall
This message was automatically generated. |
|
+1 this looks good now. Will commit in a bit |
|
@prasad-acit I removed on commit those lines that you commented out. |
|
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
HDFS-16141. Address permission related issues with File / Directory