HADOOP-19500. Skip tests that require JavaScript engine when it's not available #7503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
slfan1989
reviewed
Mar 14, 2025
| import org.junit.jupiter.api.Test; | ||
| import org.junit.jupiter.api.Timeout; | ||
|
|
||
| import static org.junit.Assume.assumeNotNull; |
Contributor
There was a problem hiding this comment.
If we find that the relevant classes already use org.junit.jupiter, we can use the JUnit 5 syntax.
|
🎊 +1 overall
This message was automatically generated. |
steveloughran
requested changes
Mar 14, 2025
| @Before | ||
| public void setup() { | ||
| //JavaScript engine has been removed from Java in Java 15. | ||
| assumeNotNull(new ScriptEngineManager().getEngineByName("JavaScript")); |
Contributor
There was a problem hiding this comment.
this is a common assert. why not pull it out into some shared utility class
- add a text message as to why it was skipped, just for those test reports
Contributor
Author
There was a problem hiding this comment.
Thanks for the review @steveloughran .
A utility class wouldn't really work because some of the tests use JUnit 4 and others Junit 5.
I have refactored the changes, and pushed the SLS check into the superclass, so that now there are only two assume instances, and a message is set.
| import org.junit.runners.Parameterized; | ||
| import org.junit.runners.Parameterized.Parameters; | ||
|
|
||
| import static org.junit.Assume.assumeNotNull; |
Contributor
There was a problem hiding this comment.
if you don't factor out the common assert, can you put the static import at the bottom of all other imports. thanks
Contributor
Author
There was a problem hiding this comment.
Sure.
Is there an Eclipse code formatter definition somewhere I can use ?
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
|
no eclipse style, AFAIK |
YanivKunda
pushed a commit
to YanivKunda/hadoop
that referenced
this pull request
Mar 23, 2025
… available (apache#7503) Contributed by Istvan Toth
p-szucs
pushed a commit
to p-szucs/hadoop
that referenced
this pull request
Oct 22, 2025
…when it's not available (apache#7503) Contributed by Istvan Toth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Skip tests that require JavaScript engine if it is not available in the JVM
How was this patch tested?
Ran the affected tests with JDK 17, confirmed that they are skipped instead of failing or erroring out
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?