HDFS-17943. Fix malformed error message for negative dfs.domain.socket.disable.interval.seconds#8603
Open
namest504 wants to merge 2 commits into
Open
HDFS-17943. Fix malformed error message for negative dfs.domain.socket.disable.interval.seconds#8603namest504 wants to merge 2 commits into
namest504 wants to merge 2 commits into
Conversation
…t.disable.interval.seconds
|
🎊 +1 overall
This message was automatically generated. |
ayushtkn
reviewed
Jul 16, 2026
|
🎊 +1 overall
This message was automatically generated. |
Member
|
do you have a jira id? So, I can merge and assign the ticket to you? if so can you assign the jira to your name or drop your jira id here & I will do that |
Author
|
Thanks for the review! I don't have a Jira account yet — I requested one via ASF self-serve on July 14 (requested username: namest504) and it's still pending approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
This PR fixes HDFS-17943.
When
dfs.domain.socket.disable.interval.secondsis set to a negative value, the client fails with a malformed error message — a space is missing between the configuration key and the rest of the message:This change adds the missing space in the
Preconditions.checkArgumentmessage inDfsClientConf.ShortCircuitConf, so the message now reads:How was this patch tested?
The change only touches a string literal in an error message. It was verified by setting the config to
-1and checking the correctedIllegalArgumentExceptionmessage. A dedicated unit test was initially included but removed per review feedback, as it is not needed for this trivial fix.For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?AI Tooling
Contains content generated by Claude Code.
where is the name of the AI tool used.
https://www.apache.org/legal/generative-tooling.html