Skip to content

MAPREDUCE-7541. Fix AM WebUI attempts page - #8652

Open
dmmkr wants to merge 1 commit into
apache:trunkfrom
dmmkr:MAPREDUCE-7541
Open

MAPREDUCE-7541. Fix AM WebUI attempts page#8652
dmmkr wants to merge 1 commit into
apache:trunkfrom
dmmkr:MAPREDUCE-7541

Conversation

@dmmkr

@dmmkr dmmkr commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Description of PR

Fix AM WebUI attempts page
Screenshot from 2026-08-02 18-13-04

How was this patch tested?

Validated with updating the jar
Screenshot from 2026-08-02 18-32-18

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

AI Tooling

If an AI tool was used:

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to fix the MapReduce ApplicationMaster (AM) Web UI “attempts” page by adjusting Guice bindings in the AM web application so the UI can render correctly with the expected injected state.

Changes:

  • Adds an explicit Guice binding for App within AMWebApp.setup().
  • Introduces a Guice scope annotation import to support the new binding.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 54s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 48m 14s trunk passed
+1 💚 compile 0m 59s trunk passed with JDK Ubuntu-21.0.11+10-1-24.04.2-Ubuntu
+1 💚 compile 1m 0s trunk passed with JDK Ubuntu-17.0.19+10-1-24.04.2-Ubuntu
+1 💚 checkstyle 0m 56s trunk passed
+1 💚 mvnsite 1m 2s trunk passed
+1 💚 javadoc 0m 58s trunk passed with JDK Ubuntu-21.0.11+10-1-24.04.2-Ubuntu
+1 💚 javadoc 0m 56s trunk passed with JDK Ubuntu-17.0.19+10-1-24.04.2-Ubuntu
+1 💚 spotbugs 1m 39s trunk passed
+1 💚 shadedclient 36m 16s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 32s the patch passed
+1 💚 compile 0m 30s the patch passed with JDK Ubuntu-21.0.11+10-1-24.04.2-Ubuntu
+1 💚 javac 0m 30s the patch passed
+1 💚 compile 0m 32s the patch passed with JDK Ubuntu-17.0.19+10-1-24.04.2-Ubuntu
+1 💚 javac 0m 32s the patch passed
-1 ❌ blanks 0m 0s /blanks-tabs.txt The patch 1 line(s) with tabs.
-0 ⚠️ checkstyle 0m 25s /results-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app: The patch generated 1 new + 11 unchanged - 0 fixed = 12 total (was 11)
+1 💚 mvnsite 0m 35s the patch passed
+1 💚 javadoc 0m 27s the patch passed with JDK Ubuntu-21.0.11+10-1-24.04.2-Ubuntu
+1 💚 javadoc 0m 27s the patch passed with JDK Ubuntu-17.0.19+10-1-24.04.2-Ubuntu
+1 💚 spotbugs 1m 19s the patch passed
+1 💚 shadedclient 34m 30s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 8m 36s hadoop-mapreduce-client-app in the patch passed.
+1 💚 asflicense 0m 37s The patch does not generate ASF License warnings.
143m 23s
Subsystem Report/Notes
Docker ClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8652/2/artifact/out/Dockerfile
GITHUB PR #8652
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 555964efe341 5.15.0-181-generic #191-Ubuntu SMP Fri May 22 19:09:02 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / c054343
Default Java Ubuntu-17.0.19+10-1-24.04.2-Ubuntu
Multi-JDK versions /usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.11+10-1-24.04.2-Ubuntu /usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.19+10-1-24.04.2-Ubuntu
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8652/2/testReport/
Max. process+thread count 599 (vs. ulimit of 10000)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8652/2/console
versions git=2.43.0 maven=3.9.15 spotbugs=4.9.7
Powered by Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants