Skip to content

HDFS-17961. Fix ineffective bucket-size validation in RollingWindow constructor - #8673

Merged
ZanderXu merged 1 commit into
apache:trunkfrom
CapMoon:HDFS-17961
Aug 17, 2026
Merged

HDFS-17961. Fix ineffective bucket-size validation in RollingWindow constructor#8673
ZanderXu merged 1 commit into
apache:trunkfrom
CapMoon:HDFS-17961

Conversation

@CapMoon

@CapMoon CapMoon commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

HDFS-17961. Fix ineffective bucket-size validation in RollingWindow constructor

Description of PR

Fix ineffective bucket-size validation in RollingWindow constructor

How was this patch tested?

tested by newly added unit test

For code changes:

  • Does the title of this PR start with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: Have the integration tests been executed and the endpoint
    declared according to the connector-specific documentation? Note: Automated CI
    testing doesn't cover all cases so manual testing with cloud storage is still
    required.
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

AI Tooling

If an AI tool was used:

@CapMoon

CapMoon commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

@ZanderXu @haiyang1987 @kokonguyen191 Masters, can check it when you are available

@CapMoon

CapMoon commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

Failed UTs are irrelevant to this pr

@ZanderXu ZanderXu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@ZanderXu

Copy link
Copy Markdown
Contributor

Merged, thanks @CapMoon for your contribution.

@ZanderXu
ZanderXu merged commit 7e78847 into apache:trunk Aug 17, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants