YARN-11982: Automatically stage weight capacity when dynamic queue creation on root queue is enabled - #8675
YARN-11982: Automatically stage weight capacity when dynamic queue creation on root queue is enabled#8675Hean-Chhinling wants to merge 2 commits into
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Based on the docs seems like this is not allowed. Or do i miss some thing? |
|
Why this validation was not running during your test? |
|
I checked on a cluster and seems working. |
Of course, the root queue capacity should be 100%. And if the user tries to set it to be different than 100% than the /validate endpoint will fail as I stated in the PR's description. But we allowing this mostly for the weight and also for absolute mode. So that user could enable the Dynamic Child Queue creation for "root" queue. |
Hmm..I don't think we are hitting this exception. The root queue is always 100% by itself. |
|
@Hean-Chhinling thanks for the patch! In general root will always have 100% capacity (regardless of if it's in weight, absolute resources or capacity), hence I wouldn't enable the edit capacity button, it could just cause confusion. Instead I think a more user-friendly solution would be to when Flexible Queue Auto-Creation is enabled on root, a 100%->1w change on root's capacity is auto-staged. It should be simpler in code as well. |
Thanks you for review @brumi1024. In that case, I will implement the following:
|
…eation on root queue is enabled
e9dbf83 to
7ab4e55
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contains content generated by Cursor.
Description of PR
Automatically stage 1w capacity for root queue when Dynamic Queue Creation is enabled.
There is no way to set capacity for root queue because the "Edit Capacity" button is disable, therefore it is not possible to enable the Dynamic Queue Creation on root queue.
The main change in this PR is to pass to 1w and 100% capacity when Dynamic Queue Creation is enabled or disable, respectively. This is implemented at
rootFlexibleAutoCreation.ts.Notes: the automatically stage weight capacity only works when
yarn.scheduler.capacity.legacy-queue-mode.enabled=true. If non-legacy queue mode, then there is no need to stage weight capacity.How was this patch tested?
Tested manually and works as expected.
Automatically stage 1w capacity for root queue when Dynamic Queue Creation is enabled:

If Dynamic Queue Creation is disable, then the root queue 100% will automatically be staged:
For code changes:
declared according to the connector-specific documentation? Note: Automated CI
testing doesn't cover all cases so manual testing with cloud storage is still
required.
LICENSE,LICENSE-binary,NOTICE-binaryfiles?AI Tooling
If an AI tool was used:
where is the name of the AI tool used.
https://www.apache.org/legal/generative-tooling.html