HBASE-30185 Port hbase-spark lower level RDD API to spark4 module#157
Open
wchevreuil wants to merge 5 commits into
Open
HBASE-30185 Port hbase-spark lower level RDD API to spark4 module#157wchevreuil wants to merge 5 commits into
wchevreuil wants to merge 5 commits into
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
Co-authored-by: Claude Code (claude-opus-4-6) <no-reply@anthropic.com> adding change to personality so that Pspark4 profile is activated when validating spark4 module setting jdk17 in JAVA_HOME for spark4 profile build adding nashorn as js engine and exclude rule to skip auto generated flattened pom from spotless chek. another change in personality to force spotless be run with jdk8 raising spotless version to 2.30 to support both jdk8 and jdk17. Fixed spotless issues on spark4 module. adding jrunsript download to docker file which is needed for pom.xml parsing in jdk17 adding sotless exclusion for flattened-pom
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
(!) A patch to the testing environment has been detected. |
|
🎊 +1 overall
This message was automatically generated. |
petersomogyi
reviewed
Jul 7, 2026
|
|
||
| # Yetus xml check uses jrunscript (removed in JDK 14). Provide a wrapper so | ||
| # it remains available when JAVA_HOME points to JDK 17. | ||
| RUN printf '#!/bin/sh\nexec /usr/local/openjdk-8/bin/jrunscript "$@"\n' \ |
Contributor
There was a problem hiding this comment.
Is this required because we're using an older Yetus in hbase-connectors? I don't see similar in the main repository.
Contributor
Author
There was a problem hiding this comment.
Good point. Let me check how does yetus is configured with jdk 17+. Here, I was getting a pom.xml parsing issue, and yetus was then reporting an xml error. The suggestion I got from claude-opus-4-6 was that jdk17 misss this jrunscript. I think the main problem here is that we are trying to support both jdk8 and jdk17.
| # When spark4 modules are in the changed set, activate the spark4 profile | ||
| # so the full reactor (including hbase-spark-pushdown_2.13) is built. | ||
| # The maven-enforcer-plugin in the spark4 profile requires JDK 17+. | ||
| if [[ "${MODULES[*]}" =~ spark4 ]]; then |
Contributor
There was a problem hiding this comment.
Does it also work if the changed file is in the global pom.xml as an example?
Contributor
Author
There was a problem hiding this comment.
It would just run with jdk8, then.
| <dependency> | ||
| <groupId>org.scalatest</groupId> | ||
| <artifactId>scalatest_${scala.binary.version}</artifactId> | ||
| <version>3.2.17</version> |
Contributor
There was a problem hiding this comment.
The spark/hbase-spark/pom.xml also has scalatest dependency. Can the versions be harmonised between the 2 places?
Contributor
Author
There was a problem hiding this comment.
I tried setting 3.2.17 in the hbase-spark pom, but got some compilation errors. If I try 3.0.5 on hbase-spark4, then it's spark4 build that fails.
| <plugin> | ||
| <groupId>org.scalatest</groupId> | ||
| <artifactId>scalatest-maven-plugin</artifactId> | ||
| <version>2.2.0</version> |
Contributor
There was a problem hiding this comment.
Can you use a property for the version? The scalatest-maven-plugin is also defined in spark/hbase-spark/pom.xml file.
| <dependency> | ||
| <groupId>org.openjdk.nashorn</groupId> | ||
| <artifactId>nashorn-core</artifactId> | ||
| <version>15.4</version> |
Contributor
There was a problem hiding this comment.
Please use a version property.
| assert(row.getString(2) == "last") | ||
| } | ||
|
|
||
| test("closure serialization succeeds with serializable column array") { |
Contributor
There was a problem hiding this comment.
What does this test actually do?
Contributor
Author
There was a problem hiding this comment.
This test class is not correct, it's not even referring the spark4 module HBaseContext. It's an outdated version, somehow I missed it. Will push a correct test class.
|
(!) A patch to the testing environment has been detected. |
|
🎊 +1 overall
This message was automatically generated. |
|
(!) A patch to the testing environment has been detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.