Skip to content

HBASE-23802 Remove unnecessary Configuration instantiation in LossyAccounting #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ndimiduk merged 1 commit into from
Feb 5, 2020
Merged

HBASE-23802 Remove unnecessary Configuration instantiation in LossyAccounting #1127

ndimiduk merged 1 commit into from
Feb 5, 2020

Conversation

@ndimiduk
Copy link
Member

@ndimiduk ndimiduk commented Feb 5, 2020

No description provided.

@ndimiduk
Copy link
Member Author

ndimiduk commented Feb 5, 2020

Unwind the Configuration creation, and cleanup a bunch of warnings along the way.

@busbey busbey requested a review from the-sakthi February 5, 2020 20:29
saintstack
saintstack approved these changes Feb 5, 2020
View reviewed changes
hbase-server/src/main/java/org/apache/hadoop/hbase/util/LossyCounting.java
}

public LossyCounting(String name, LossyCountingListener listener) {
this(HBaseConfiguration.create().getDouble(HConstants.DEFAULT_LOSSY_COUNTING_ERROR_RATE, 0.02),
Copy link
Contributor

@saintstack saintstack Feb 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch. To read a single config.

Copy link
Member Author

@ndimiduk ndimiduk Feb 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed.

@ndimiduk ndimiduk merged commit 5b4545d into apache:master Feb 5, 2020
@ndimiduk ndimiduk deleted the 23802-LossyAccounting-Configuration branch February 5, 2020 22:41
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Feb 5, 2020
@ndimiduk
HBASE-23802 Remove unnecessary Configuration instantiation in LossyAc…
ea80fb5 
…counting (apache#1127)

Signed-off-by: stack <stack@apache.org>
@ndimiduk ndimiduk mentioned this pull request Feb 5, 2020
Merged
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Feb 5, 2020
@ndimiduk
HBASE-23802 Remove unnecessary Configuration instantiation in LossyAc…
af20bc1 
…counting (apache#1127)

Signed-off-by: stack <stack@apache.org>
@Apache-HBase
Copy link

Apache-HBase commented Feb 5, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 27s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚 mvninstall 5m 57s master passed
+1 💚 compile 1m 0s master passed
+1 💚 checkstyle 1m 15s master passed
+1 💚 shadedjars 5m 4s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 38s master passed
+0 🆗 spotbugs 4m 31s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 4m 29s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 5m 26s the patch passed
+1 💚 compile 1m 0s the patch passed
+1 💚 javac 1m 0s the patch passed
+1 💚 checkstyle 1m 12s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 5m 4s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 17m 15s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚 javadoc 0m 35s the patch passed
+1 💚 findbugs 4m 45s the patch passed
_ Other Tests _
-1 ❌ unit 95m 22s hbase-server in the patch failed.
+1 💚 asflicense 0m 28s The patch does not generate ASF License warnings.
156m 45s
Reason Tests
Failed junit tests hadoop.hbase.replication.TestReplicationSmallTests
Subsystem Report/Notes
Docker Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1127/1/artifact/out/Dockerfile
GITHUB PR #1127
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 1eb80b166c49 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1127/out/precommit/personality/provided.sh
git revision master / b49ec58
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1127/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1127/1/testReport/
Max. process+thread count 6598 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1127/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

ndimiduk added a commit that referenced this pull request Feb 6, 2020
@ndimiduk
HBASE-23802 Remove unnecessary Configuration instantiation in LossyAc…
c2977a5 
…counting (#1127) (#1136)

Signed-off-by: stack <stack@apache.org>
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Feb 6, 2020
@ndimiduk
HBASE-23802 Remove unnecessary Configuration instantiation in LossyAc…
9afbd1c 
…counting (apache#1127)

Signed-off-by: stack <stack@apache.org>
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Feb 6, 2020
@ndimiduk
HBASE-23802 Remove unnecessary Configuration instantiation in LossyAc…
4ee4e52 
…counting (apache#1127)

Signed-off-by: stack <stack@apache.org>
@ndimiduk ndimiduk mentioned this pull request Feb 6, 2020
Merged
ndimiduk added a commit that referenced this pull request Feb 7, 2020
@ndimiduk
HBASE-23802 Remove unnecessary Configuration instantiation in LossyAc…
9e4aec5 
…counting (#1127) (#1140)

Signed-off-by: stack <stack@apache.org>
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Feb 7, 2020
@ndimiduk
HBASE-23802 Remove unnecessary Configuration instantiation in LossyAc…
4a4b6a3 
…counting (apache#1127) (apache#1136)

Signed-off-by: stack <stack@apache.org>
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Feb 10, 2020
@ndimiduk
HBASE-23802 Remove unnecessary Configuration instantiation in LossyAc…
00f784e 
…counting (apache#1127)

Signed-off-by: stack <stack@apache.org>
@ndimiduk ndimiduk mentioned this pull request Feb 10, 2020
Merged
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Feb 10, 2020
@ndimiduk
HBASE-23802 Remove unnecessary Configuration instantiation in LossyAc…
705f1df 
…counting (apache#1127)

Signed-off-by: stack <stack@apache.org>
@ndimiduk ndimiduk mentioned this pull request Feb 10, 2020
Merged
ndimiduk added a commit that referenced this pull request Feb 12, 2020
@ndimiduk
HBASE-23802 Remove unnecessary Configuration instantiation in LossyAc…
28f51d0 
…counting (#1127)

Signed-off-by: stack <stack@apache.org>
ndimiduk added a commit that referenced this pull request Feb 12, 2020
@ndimiduk
HBASE-23802 Remove unnecessary Configuration instantiation in LossyAc…
c540d90 
…counting (#1127)

Signed-off-by: stack <stack@apache.org>
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Feb 12, 2020
@ndimiduk
HBASE-23802 Remove unnecessary Configuration instantiation in LossyAc…
c5f2751 
…counting (apache#1127) (apache#1140)

Signed-off-by: stack <stack@apache.org>
@ndimiduk ndimiduk mentioned this pull request Feb 12, 2020
Merged
ndimiduk added a commit that referenced this pull request Feb 13, 2020
@ndimiduk
HBASE-23802 Remove unnecessary Configuration instantiation in LossyAc…
1c3eaed 
…counting (#1127) (#1166)

Signed-off-by: stack <stack@apache.org>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@ndimiduk @thangTang
HBASE-23802 Remove unnecessary Configuration instantiation in LossyAc…
740df53 
…counting (apache#1127)

Signed-off-by: stack <stack@apache.org>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@ndimiduk @thangTang
HBASE-23802 Remove unnecessary Configuration instantiation in LossyAc…
cfe929e 
…counting (apache#1127)

Signed-off-by: stack <stack@apache.org>
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
@ndimiduk @infraio
HBASE-23802 Remove unnecessary Configuration instantiation in LossyAc…
cc1f6fc 
…counting (apache#1127) (apache#1136)

Signed-off-by: stack <stack@apache.org>
Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MetaTableMetrics.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsUserAggregateImpl.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/util/LossyCounting.java
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
@ndimiduk @petersomogyi
HBASE-23802 Remove unnecessary Configuration instantiation in LossyAc…
e9e8271 
…counting (apache#1127)

Signed-off-by: stack <stack@apache.org>
(cherry picked from commit 5b4545d)

Change-Id: Iddfb4153a24a0e73f7d5dd7c89e99894f9c46130
udaynpusa pushed a commit to mapr/hbase that referenced this pull request Jan 30, 2024
@ndimiduk
HBASE-23802 Remove unnecessary Configuration instantiation in LossyAc…
884d46e 
…counting (apache#1127) (apache#1166)

Signed-off-by: stack <stack@apache.org>
(cherry picked from commit 1c3eaed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saintstack saintstack saintstack approved these changes

@ankitsinghal ankitsinghal Awaiting requested review from ankitsinghal

@the-sakthi the-sakthi Awaiting requested review from the-sakthi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndimiduk @Apache-HBase @saintstack