Skip to content

Conversation

@saintstack
Copy link
Contributor

…t in hbase-archetypes

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 9s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 5m 48s branch-2 passed
+1 💚 compile 0m 40s branch-2 passed
+1 💚 shadedjars 4m 42s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 28s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 5m 29s the patch passed
+1 💚 compile 0m 39s the patch passed
+1 💚 javac 0m 39s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 3s The patch has no ill-formed XML file.
+1 💚 shadedjars 4m 43s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 17m 17s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚 javadoc 0m 28s the patch passed
_ Other Tests _
+1 💚 unit 0m 45s hbase-client-project in the patch passed.
+1 💚 unit 0m 46s hbase-shaded-client-project in the patch passed.
+1 💚 asflicense 0m 21s The patch does not generate ASF License warnings.
50m 46s
Subsystem Report/Notes
Docker Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1145/1/artifact/out/Dockerfile
GITHUB PR #1145
Optional Tests dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
uname Linux 0891dce3324f 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1145/out/precommit/personality/provided.sh
git revision branch-2 / 29fb52b
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1145/1/testReport/
Max. process+thread count 432 (vs. ulimit of 10000)
modules C: hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: hbase-archetypes
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1145/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@z-york
Copy link
Contributor

z-york commented Feb 8, 2020

+1 LGTM

Copy link
Member

@ndimiduk ndimiduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I walked up the parent pom hierarchy for both of these poms and landed at our root.

+1

Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@saintstack
Copy link
Contributor Author

Signed-off-by: Nick Dimiduk ndimiduk@apache.org
Signed-off-by: Jan Hentschel janh@apache.org
Signed-off-by: Zach York zyork@apache.org

@saintstack saintstack merged commit f46d93e into apache:branch-2 Feb 8, 2020
asfgit pushed a commit that referenced this pull request Feb 8, 2020
…t in hbase-archetypes (#1145)


Signed-off-by: Nick Dimiduk ndimiduk@apache.org
Signed-off-by: Jan Hentschel janh@apache.org
Signed-off-by: Zach York zyork@apache.org
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
…t in hbase-archetypes (apache#1145)


Signed-off-by: Nick Dimiduk ndimiduk@apache.org
Signed-off-by: Jan Hentschel janh@apache.org
Signed-off-by: Zach York zyork@apache.org
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
…t in hbase-archetypes (apache#1145)


Signed-off-by: Nick Dimiduk ndimiduk@apache.org
Signed-off-by: Jan Hentschel janh@apache.org
Signed-off-by: Zach York zyork@apache.org
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants