HBASE-23781 Removed deprecated createTableDescriptor(String) from HBaseTestingUtility #1146

HorizonNet · 2020-02-07T23:03:01Z

No description provided.

…seTestingUtility

Apache-HBase · 2020-02-08T02:19:17Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 54s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 14 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	3m 9s	master passed
+1 💚	compile	1m 1s	master passed
+1 💚	checkstyle	1m 20s	master passed
+1 💚	shadedjars	5m 7s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	master passed
+0 🆗	spotbugs	4m 53s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	4m 50s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 2s	the patch passed
+1 💚	compile	1m 6s	the patch passed
+1 💚	javac	1m 6s	the patch passed
+1 💚	checkstyle	1m 17s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	5m 9s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	18m 5s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	0m 42s	the patch passed
+1 💚	findbugs	4m 55s	the patch passed
		_ Other Tests _
-1 ❌	unit	131m 28s	hbase-server in the patch failed.
+1 💚	asflicense	0m 50s	The patch does not generate ASF License warnings.
		193m 44s

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestAsyncMetaRegionLocator
	hadoop.hbase.client.TestTableFavoredNodes
	hadoop.hbase.master.procedure.TestSplitWALProcedure
	hadoop.hbase.client.TestAvoidCellReferencesIntoShippedBlocks
	hadoop.hbase.replication.regionserver.TestWALEntryStream

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/1/artifact/out/Dockerfile
GITHUB PR	#1146
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux b0ee019459c2 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1146/out/precommit/personality/provided.sh
git revision	master / `ef380e0`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/1/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/1/testReport/
Max. process+thread count	6648 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani

Test failures are relevant? Also, shell might be using this constructor so it’s worth running shell tests locally

HorizonNet · 2020-02-08T18:12:34Z

@virajjasani Checked the shell usage and it doesn't seem to be used there. Also ran the shell tests locally. They are all passing. I merged the latest master. Let's wait for QA.

Apache-HBase · 2020-02-08T20:19:07Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 14 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	5m 34s	master passed
+1 💚	compile	0m 59s	master passed
+1 💚	checkstyle	1m 16s	master passed
+1 💚	shadedjars	4m 41s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	master passed
+0 🆗	spotbugs	4m 19s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	4m 16s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 56s	the patch passed
+1 💚	compile	0m 59s	the patch passed
+1 💚	javac	0m 59s	the patch passed
+1 💚	checkstyle	1m 17s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	4m 40s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	15m 48s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	0m 35s	the patch passed
+1 💚	findbugs	4m 23s	the patch passed
		_ Other Tests _
-1 ❌	unit	61m 16s	hbase-server in the patch failed.
+1 💚	asflicense	0m 37s	The patch does not generate ASF License warnings.
		119m 0s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/2/artifact/out/Dockerfile
GITHUB PR	#1146
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 39e3dbee4bc8 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1146/out/precommit/personality/provided.sh
git revision	master / `348ee59`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/2/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/2/testReport/
Max. process+thread count	7848 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/2/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-02-08T22:39:45Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 14 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	5m 38s	master passed
+1 💚	compile	0m 59s	master passed
+1 💚	checkstyle	1m 18s	master passed
+1 💚	shadedjars	4m 42s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	master passed
+0 🆗	spotbugs	4m 24s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	4m 22s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 0s	the patch passed
+1 💚	compile	0m 58s	the patch passed
+1 💚	javac	0m 58s	the patch passed
+1 💚	checkstyle	1m 15s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	4m 39s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	15m 55s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	0m 37s	the patch passed
+1 💚	findbugs	4m 19s	the patch passed
		_ Other Tests _
-1 ❌	unit	63m 28s	hbase-server in the patch failed.
+1 💚	asflicense	0m 36s	The patch does not generate ASF License warnings.
		121m 28s

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestAsyncTableGetMultiThreaded
	hadoop.hbase.security.access.TestAccessController3

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/3/artifact/out/Dockerfile
GITHUB PR	#1146
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 44745fa220d6 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1146/out/precommit/personality/provided.sh
git revision	master / `348ee59`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/3/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/3/testReport/
Max. process+thread count	7328 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/3/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani

+1 if latest test failures are flaky

ndimiduk

Thanks for taking on these cleanup tasks @HorizonNet .

Apache-HBase · 2020-02-13T21:26:49Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 14 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	7m 0s	master passed
+1 💚	compile	1m 13s	master passed
+1 💚	checkstyle	1m 30s	master passed
+1 💚	shadedjars	6m 2s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 45s	master passed
+0 🆗	spotbugs	5m 2s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	4m 59s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	6m 45s	the patch passed
+1 💚	compile	1m 11s	the patch passed
+1 💚	javac	1m 11s	the patch passed
+1 💚	checkstyle	1m 31s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	6m 14s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	19m 57s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	0m 43s	the patch passed
+1 💚	findbugs	4m 59s	the patch passed
		_ Other Tests _
-1 ❌	unit	74m 5s	hbase-server in the patch failed.
+1 💚	asflicense	0m 40s	The patch does not generate ASF License warnings.
		146m 38s

Reason	Tests
Failed junit tests	hadoop.hbase.TestClusterPortAssignment
	hadoop.hbase.replication.TestSyncReplicationActive
	hadoop.hbase.replication.TestSyncReplicationMoreLogsInLocalCopyToRemote
	hadoop.hbase.replication.TestReplicationStatusSourceStartedTargetStoppedNoOps
	hadoop.hbase.replication.TestRemoveFromSerialReplicationPeer
	hadoop.hbase.replication.TestReplicationSmallTestsSync
	hadoop.hbase.TestSplitMerge
	hadoop.hbase.replication.TestSyncReplicationStandBy
	hadoop.hbase.replication.TestReplicationKillMasterRS
	hadoop.hbase.replication.TestSerialSyncReplication
	hadoop.hbase.replication.TestSyncReplicationStandbyKillRS

Subsystem	Report/Notes
Docker	Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/4/artifact/out/Dockerfile
GITHUB PR	#1146
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 61f6ebc4a7a1 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1146/out/precommit/personality/provided.sh
git revision	master / `488c2b2`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/4/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/4/testReport/
Max. process+thread count	7909 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/4/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

HorizonNet · 2020-02-14T20:49:13Z

Test failures seem to be different with each build. Let me dig into it.

Apache-HBase · 2020-02-15T00:02:44Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 21s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 14 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	8m 12s	master passed
+1 💚	compile	1m 27s	master passed
+1 💚	checkstyle	1m 38s	master passed
+1 💚	shadedjars	6m 31s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 7s	master passed
+0 🆗	spotbugs	5m 44s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	5m 41s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	8m 12s	the patch passed
+1 💚	compile	1m 25s	the patch passed
+1 💚	javac	1m 25s	the patch passed
+1 💚	checkstyle	1m 29s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	6m 32s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	24m 46s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	0m 52s	the patch passed
+1 💚	findbugs	5m 25s	the patch passed
		_ Other Tests _
-1 ❌	unit	106m 13s	hbase-server in the patch failed.
+1 💚	asflicense	0m 32s	The patch does not generate ASF License warnings.
		192m 22s

Reason	Tests
Failed junit tests	hadoop.hbase.replication.regionserver.TestSerialReplicationChecker
	hadoop.hbase.replication.TestReplicationStatusAfterLagging
	hadoop.hbase.replication.TestRemoveFromSerialReplicationPeer
	hadoop.hbase.replication.TestReplicationKillMasterRSCompressed

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/5/artifact/out/Dockerfile
GITHUB PR	#1146
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux d4f040148022 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1146/out/precommit/personality/provided.sh
git revision	master / `5f61df4`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/5/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/5/testReport/
Max. process+thread count	6742 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/5/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-02-19T16:42:03Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 14 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	5m 29s	master passed
+1 💚	compile	0m 59s	master passed
+1 💚	checkstyle	1m 16s	master passed
+1 💚	shadedjars	4m 39s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	master passed
+0 🆗	spotbugs	4m 13s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	4m 11s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 3s	the patch passed
+1 💚	compile	0m 58s	the patch passed
+1 💚	javac	0m 58s	the patch passed
+1 💚	checkstyle	1m 16s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	4m 38s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	15m 58s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	0m 37s	the patch passed
+1 💚	findbugs	4m 24s	the patch passed
		_ Other Tests _
-1 ❌	unit	63m 31s	hbase-server in the patch failed.
+1 💚	asflicense	0m 37s	The patch does not generate ASF License warnings.
		121m 32s

Reason	Tests
Failed junit tests	hadoop.hbase.replication.TestNamespaceReplicationWithBulkLoadedData
	hadoop.hbase.replication.TestNamespaceReplication
	hadoop.hbase.replication.TestReplicationDisableInactivePeer
	hadoop.hbase.replication.TestReplicationKillMasterRS

Subsystem	Report/Notes
Docker	Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/6/artifact/out/Dockerfile
GITHUB PR	#1146
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 8936ec5f14f7 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1146/out/precommit/personality/provided.sh
git revision	master / `53afc1d`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/6/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/6/testReport/
Max. process+thread count	9692 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/6/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-02-21T14:06:23Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 8s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 17 new or modified test files.
		_ master Compile Tests _
+0 🆗	mvndep	0m 37s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 49s	master passed
+1 💚	compile	1m 31s	master passed
+1 💚	checkstyle	1m 32s	master passed
+1 💚	shadedjars	5m 9s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 51s	master passed
+0 🆗	spotbugs	4m 50s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	4m 48s	master passed
-0 ⚠️	patch	5m 3s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 38s	the patch passed
+1 💚	compile	1m 29s	the patch passed
+1 💚	javac	1m 29s	the patch passed
-1 ❌	checkstyle	1m 18s	hbase-server: The patch generated 1 new + 244 unchanged - 0 fixed = 245 total (was 244)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	5m 5s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	17m 31s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	0m 51s	the patch passed
+1 💚	findbugs	4m 51s	the patch passed
		_ Other Tests _
-1 ❌	unit	98m 25s	hbase-server in the patch failed.
+1 💚	unit	1m 4s	hbase-it in the patch passed.
+1 💚	asflicense	0m 46s	The patch does not generate ASF License warnings.
		166m 6s

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestFromClientSideWithCoprocessor

Subsystem	Report/Notes
Docker	Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/7/artifact/out/Dockerfile
GITHUB PR	#1146
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux a5d7352dbea7 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1146/out/precommit/personality/provided.sh
git revision	master / `fe0d49b`
Default Java	1.8.0_181
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/7/artifact/out/diff-checkstyle-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/7/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/7/testReport/
Max. process+thread count	7397 (vs. ulimit of 10000)
modules	C: hbase-server hbase-it U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/7/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

HorizonNet · 2020-02-21T18:28:05Z

Fixed the remaining Checkstyle violation. The test failing in the last build passes locally.

Apache-HBase · 2020-02-21T20:38:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 17 new or modified test files.
		_ master Compile Tests _
+0 🆗	mvndep	0m 41s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 25s	master passed
+1 💚	compile	1m 28s	master passed
+1 💚	checkstyle	1m 34s	master passed
+1 💚	shadedjars	4m 47s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 55s	master passed
+0 🆗	spotbugs	4m 16s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	4m 13s	master passed
-0 ⚠️	patch	4m 31s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 28s	the patch passed
+1 💚	compile	1m 32s	the patch passed
+1 💚	javac	1m 32s	the patch passed
+1 💚	checkstyle	1m 31s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	4m 50s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	15m 50s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	0m 51s	the patch passed
+1 💚	findbugs	4m 21s	the patch passed
		_ Other Tests _
-1 ❌	unit	64m 59s	hbase-server in the patch failed.
+1 💚	unit	1m 14s	hbase-it in the patch passed.
+1 💚	asflicense	1m 6s	The patch does not generate ASF License warnings.
		128m 18s

Reason	Tests
Failed junit tests	hadoop.hbase.replication.TestNamespaceReplicationWithBulkLoadedData
	hadoop.hbase.replication.TestReplicationStatus

Subsystem	Report/Notes
Docker	Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/8/artifact/out/Dockerfile
GITHUB PR	#1146
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux fd2a0ec51b66 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1146/out/precommit/personality/provided.sh
git revision	master / `3ab0135`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/8/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/8/testReport/
Max. process+thread count	9799 (vs. ulimit of 10000)
modules	C: hbase-server hbase-it U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/8/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

HorizonNet · 2020-02-22T16:30:24Z

Both test failures seem to be unrelated to the change. Ran them several times locally. TestNamespaceReplicationWithBulkLoadedData always passes, TestReplicationStatus 50% of the time.

HorizonNet · 2020-02-22T16:31:03Z

@ndimiduk @virajjasani Does your +1 stay?

saintstack

LGTM

If failing tests did not use this method, go for the commit... else do a test rerun before committing.

virajjasani

+1 stays :)

HBASE-23781 Removed deprecated createTableDescriptor(String) from HBa…

db98bbd

…seTestingUtility

HorizonNet added the enhancement label Feb 7, 2020

virajjasani reviewed Feb 8, 2020

View reviewed changes

Merge branch 'master' into HBASE-23781

4c8113f

virajjasani reviewed Feb 9, 2020

View reviewed changes

ndimiduk approved these changes Feb 10, 2020

View reviewed changes

Merge branch 'master' into HBASE-23781

7e42e8f

Merge branch 'master' into HBASE-23781

6ad2c6e

Merge branch 'master' into HBASE-23781

0b7a15e

Merge branch 'master' into HBASE-23781

21cda67

HBASE-23781 Fixed remaining Checkstyle violation

6682560

saintstack approved these changes Feb 22, 2020

View reviewed changes

virajjasani approved these changes Feb 23, 2020

View reviewed changes

HorizonNet merged commit 9f223c2 into apache:master Feb 25, 2020

HorizonNet deleted the HBASE-23781 branch February 25, 2020 20:10

HBASE-23781 Removed deprecated createTableDescriptor(String) from HBaseTestingUtility #1146

HBASE-23781 Removed deprecated createTableDescriptor(String) from HBaseTestingUtility #1146

Uh oh!

Conversation

HorizonNet commented Feb 7, 2020

Uh oh!

Apache-HBase commented Feb 8, 2020

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

HorizonNet commented Feb 8, 2020

Uh oh!

Apache-HBase commented Feb 8, 2020

Uh oh!

Apache-HBase commented Feb 8, 2020

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

ndimiduk left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Feb 13, 2020

Uh oh!

HorizonNet commented Feb 14, 2020

Uh oh!

Apache-HBase commented Feb 15, 2020

Uh oh!

Apache-HBase commented Feb 19, 2020

Uh oh!

Apache-HBase commented Feb 21, 2020

Uh oh!

HorizonNet commented Feb 21, 2020

Uh oh!

Apache-HBase commented Feb 21, 2020

Uh oh!

HorizonNet commented Feb 22, 2020

Uh oh!

HorizonNet commented Feb 22, 2020

Uh oh!

saintstack left a comment

Choose a reason for hiding this comment

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants