Backport HBASE-20467 and HBASE-24078 to branch-2.3 #1398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…we're going to run it at the root Signed-off-by: Sean Busbey <busbey@apache.org>
Without patch, the spotbugs results include warnings for inapplicable modules: +--------------------------------------------------------------------------- | | | | Compile Tests +--------------------------------------------------------------------------- | 0 | mvndep | 0m 11s | Maven dependency ordering | +1 | mvninstall | 2m 47s | the source passed | 0 | spotbugs | 0m 11s | branch/hbase-annotations no spotbugs | | | | output file (spotbugsXml.xml) | 0 | spotbugs | 0m 14s | branch/hbase-assembly no spotbugs output | | | | file (spotbugsXml.xml) | 0 | spotbugs | 0m 07s | | | | | branch/hbase-archetypes/hbase-archetype-bu | | | | ilder no spotbugs output file | | | | (spotbugsXml.xml) +--------------------------------------------------------------------------- With patch, +--------------------------------------------------------------------------- | | | | Compile Tests +--------------------------------------------------------------------------- | 0 | mvndep | 0m 13s | Maven dependency ordering | +1 | mvninstall | 3m 09s | the source passed | +1 | spotbugs | 17m 09s | the source passed +--------------------------------------------------------------------------- Signed-off-by: stack <stack@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HBASE-20467 is a good thing to have for PR builds, and is a prerequisite of the checkstyle cleanup performed in HBASE-24078.