-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-24162 Move CHANGES.txt to CHANGES.md. Add RELEASENOTES.md too o… #1476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…n branch-2, branch-2.3, and master
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
So we loose all the content of the exiting files? That's intentional? |
|
Intentional. CHANGES.txt has changes up to 0.94.0 if you are interested. |
| @@ -0,0 +1,22 @@ | |||
| # HBASE Changelog | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Copyright at the beginning of this file? Same to RELEASENOTES.md
other than that, seems good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review.
I can't put copyright/license at head of the flie because it messes up markdown viewers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We render these to html, so aren't standard xml <!-- --> applicable? I guess it would be as noise for anyone opening the file locally though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May need revisiting. In old days, rendering this markdown in browser would hide the license w/ these markings. After a recent experience, trying to read from filesystem using various markdown viewers, may need more work.
|
THanks for the reviews. I merged this after filling the files w/ changes from 2.0, 2.1., and 2.2. |
…n branch-2, branch-2.3, and master