HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format #1479

busbey · 2020-04-10T04:13:10Z

No description provided.

…s when calling String.format

busbey · 2020-04-10T04:13:28Z

tested error prone locally to confirm this clears the error that currently shows in nightly.

Apache-HBase · 2020-04-10T04:56:46Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	5m 58s	master passed
+1 💚	checkstyle	1m 14s	master passed
+1 💚	spotbugs	2m 8s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 25s	the patch passed
+1 💚	checkstyle	1m 12s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 6s	Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚	spotbugs	2m 18s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		36m 41s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1479/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1479
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 7018e1f2670a 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ac4e94e`
Max. process+thread count	83 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1479/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani

+1

Apache-HBase · 2020-04-10T07:43:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 8s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	6m 0s	master passed
+1 💚	compile	0m 55s	master passed
+1 💚	shadedjars	5m 13s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 35s	the patch passed
+1 💚	compile	0m 57s	the patch passed
+1 💚	javac	0m 57s	the patch passed
+1 💚	shadedjars	4m 54s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	176m 7s	hbase-server in the patch passed.
		203m 41s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1479/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#1479
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a3e2248d8b3f 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ac4e94e`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1479/1/testReport/
Max. process+thread count	3114 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1479/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-04-10T08:00:07Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 51s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	8m 47s	master passed
+1 💚	compile	1m 29s	master passed
+1 💚	shadedjars	6m 43s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 49s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	7m 37s	the patch passed
+1 💚	compile	1m 23s	the patch passed
+1 💚	javac	1m 23s	the patch passed
+1 💚	shadedjars	6m 42s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 42s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	182m 22s	hbase-server in the patch passed.
		220m 0s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1479/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1479
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d34939304e28 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ac4e94e`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1479/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1479/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1479/1/testReport/
Max. process+thread count	3077 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1479/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

busbey · 2020-04-10T15:58:10Z

thanks for the reviews!

ndimiduk · 2020-04-10T20:37:53Z

Thanks @busbey!

…s when calling String.format (apache#1479) Signed-off-by: stack <stack@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Josh Elser <elserj@apache.org>

…s when calling String.format (apache#1479) Signed-off-by: stack <stack@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit 09d20fb) Change-Id: Id3e6b8c4a3978bfccb3503d4e486b164d79593da Signed-off-by: Josh Elser <elserj@apache.org> Author: Sean Busbey Reason: Bug Ref: CDPD-10195

…s when calling String.format (apache#1479) Signed-off-by: stack <stack@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit 09d20fb) Signed-off-by: Josh Elser <elserj@apache.org> Author: Sean Busbey Reason: Bug Ref: CDPD-10195 (cherry picked from commit c6c78f4) Change-Id: I9f25e55fdeb1c97b8279f8a378230bdbc5c627ca

HBASE-24163 MOB compactor implementations should use format specifier…

19d32e6

…s when calling String.format

saintstack approved these changes Apr 10, 2020

View reviewed changes

virajjasani approved these changes Apr 10, 2020

View reviewed changes

joshelser approved these changes Apr 10, 2020

View reviewed changes

busbey merged commit 09d20fb into apache:master Apr 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format #1479

HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format #1479

Uh oh!

busbey commented Apr 10, 2020

Uh oh!

busbey commented Apr 10, 2020

Uh oh!

Apache-HBase commented Apr 10, 2020

Uh oh!

virajjasani left a comment

Uh oh!

Apache-HBase commented Apr 10, 2020

Uh oh!

Apache-HBase commented Apr 10, 2020

Uh oh!

busbey commented Apr 10, 2020

Uh oh!

ndimiduk commented Apr 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format #1479

HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format #1479

Uh oh!

Conversation

busbey commented Apr 10, 2020

Uh oh!

busbey commented Apr 10, 2020

Uh oh!

Apache-HBase commented Apr 10, 2020

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Apr 10, 2020

Uh oh!

Apache-HBase commented Apr 10, 2020

Uh oh!

busbey commented Apr 10, 2020

Uh oh!

ndimiduk commented Apr 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants