Skip to content

HBASE-24327: TestMasterShutdown#testMasterShutdownBeforeStartingAnyRe… #1653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
markrmiller wants to merge 1 commit into from
Closed

HBASE-24327: TestMasterShutdown#testMasterShutdownBeforeStartingAnyRe… #1653

markrmiller wants to merge 1 commit into from

Conversation

@markrmiller
Copy link
Member

@markrmiller markrmiller commented May 5, 2020

…gionServer can fail with retries exhausted on an admin call.

@markrmiller
HBASE-24327: TestMasterShutdown#testMasterShutdownBeforeStartingAnyRe…
93a5c02 
…gionServer can fail with retries exhausted on an admin call.
@Apache-HBase
Copy link

Apache-HBase commented May 5, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 50s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚 mvninstall 4m 15s branch-2 passed
+1 💚 checkstyle 1m 16s branch-2 passed
+1 💚 spotbugs 2m 16s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 40s the patch passed
+1 💚 checkstyle 1m 15s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 13m 33s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 2m 53s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 14s The patch does not generate ASF License warnings.
40m 13s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1653/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1653
JIRA Issue HBASE-24327
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 3705b8bd417a 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 3a375e6
Max. process+thread count 84 (vs. ulimit of 12500)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1653/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

wchevreuil
wchevreuil reviewed May 5, 2020
View reviewed changes
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterShutdown.java
htu = new HBaseTestingUtility(
createMasterShutdownBeforeStartingAnyRegionServerConfiguration());

htu.getConfiguration().setInt("hbase.client.retries.number", 64);
Copy link
Contributor

@wchevreuil wchevreuil May 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any further context on this value? Smaller values were still causing test to fail?

@Apache-HBase
Copy link

Apache-HBase commented May 5, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 37s Docker mode activated.
-0 ⚠️ yetus 0m 7s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 4m 9s branch-2 passed
+1 💚 compile 1m 4s branch-2 passed
+1 💚 shadedjars 5m 15s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 41s hbase-server in branch-2 failed.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 53s the patch passed
+1 💚 compile 1m 1s the patch passed
+1 💚 javac 1m 1s the patch passed
+1 💚 shadedjars 5m 11s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 40s hbase-server in the patch failed.
_ Other Tests _
+1 💚 unit 122m 18s hbase-server in the patch passed.
147m 4s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1653/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1653
JIRA Issue HBASE-24327
Optional Tests javac javadoc unit shadedjars compile
uname Linux 453bc21a5c1c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 3a375e6
Default Java 2020-01-14
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1653/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1653/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1653/1/testReport/
Max. process+thread count 4026 (vs. ulimit of 12500)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1653/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented May 5, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 51s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 4m 24s branch-2 passed
+1 💚 compile 0m 59s branch-2 passed
+1 💚 shadedjars 5m 4s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 39s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 51s the patch passed
+1 💚 compile 0m 59s the patch passed
+1 💚 javac 0m 59s the patch passed
+1 💚 shadedjars 4m 59s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 37s the patch passed
_ Other Tests _
-1 ❌ unit 212m 20s hbase-server in the patch failed.
237m 40s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1653/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #1653
JIRA Issue HBASE-24327
Optional Tests javac javadoc unit shadedjars compile
uname Linux 7533b9ee47b1 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 3a375e6
Default Java 1.8.0_232
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1653/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1653/1/testReport/
Max. process+thread count 2539 (vs. ulimit of 12500)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1653/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani
virajjasani requested changes May 8, 2020
View reviewed changes
Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By keeping high retry count, we are not going to be able to call shutdown to already stopped cluster.

@busbey
Copy link
Contributor

busbey commented Jun 25, 2020

@markrmiller still working on this PR?

@saintstack
Copy link
Contributor

saintstack commented Oct 6, 2020

Closing abandoned PR

@saintstack saintstack closed this Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wchevreuil wchevreuil wchevreuil left review comments

@virajjasani virajjasani virajjasani requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@markrmiller @Apache-HBase @busbey @saintstack @wchevreuil @virajjasani