HBASE-24516 Parameter copyFiles should be passed in SecureBulkLoadClient

[QilinCao]

When refactor SecureBulkLoadClient started in HBASE-22380. The public secureBulkLoadHFiles method parameter copyFiles was not passed to the refactoring method.

[wchevreuil]

Thanks for clarifying on the issue, this looks good. Mind add a UT for checking this condition and avoid such mistake from been repeated in the future?

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 25s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.2 Compile Tests _
+1 💚	mvninstall	5m 43s	branch-2.2 passed
+1 💚	compile	0m 28s	branch-2.2 passed
+1 💚	checkstyle	0m 39s	branch-2.2 passed
+1 💚	shadedjars	4m 26s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	branch-2.2 passed
+0 🆗	spotbugs	1m 20s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	1m 18s	branch-2.2 passed
-0 ⚠️	patch	1m 26s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 14s	the patch passed
+1 💚	compile	0m 27s	the patch passed
+1 💚	javac	0m 27s	the patch passed
+1 💚	checkstyle	0m 38s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	4m 25s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	28m 14s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1.
+1 💚	javadoc	0m 23s	the patch passed
+1 💚	findbugs	1m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 43s	hbase-client in the patch passed.
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		68m 50s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1868/1/artifact/out/Dockerfile
GITHUB PR	#1868
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 4efad511d154 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1868/out/precommit/personality/provided.sh
git revision	branch-2.2 / 61a2cce
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1868/1/testReport/
Max. process+thread count	257 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1868/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[Apache9]

Please change the PR to against master branch?

I believe this is not a 2.2 specific bug.

[QilinCao]

@Apache9 master branch use AsyncClusterConnectionImpl as bulkload client, the bug not exist.

[Apache9]

Only branch-2.2 has the problem? What about branch-2 and branch-2.3?

[infraio]

+1