Skip to content

HBASE-24546 CloneSnapshotProcedure unlimited retry #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
infraio merged 3 commits into from
Jul 6, 2020
Merged

HBASE-24546 CloneSnapshotProcedure unlimited retry #1916

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5f3f18
HBASE-24546
Jun 16, 2020
07387b0
add comments
Jun 19, 2020
04236e2
add comment
Jul 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...server/src/main/java/org/apache/hadoop/hbase/master/procedure/CloneSnapshotProcedure.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,6 +457,11 @@ private List<RegionInfo> createFsLayout(
// 1. Create Table Descriptor
// using a copy of descriptor, table will be created enabling first
final Path tempTableDir = FSUtils.getTableDir(tempdir, tableDescriptor.getTableName());
if (FSUtils.isExists(mfs.getFileSystem(), tempTableDir)) {
// if the region dirs exist, will cause exception and unlimited retry (see HBASE-24546)
LOG.warn("temp table dir already exists on disk: {}, will be deleted.", tempTableDir);
FSUtils.deleteDirectory(mfs.getFileSystem(), tempTableDir);
}
Copy link
Contributor

@infraio infraio Jun 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is: the retry will never succeed if the region dirs exist? Add comment here?

Copy link
Contributor Author

@WenFeiYi WenFeiYi Jun 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, RestoreSnapshotHelper.restoreHdfsRegions will remove the region dirs, but CloneSnapshotProcedure.createFilesystemLayout not allow exist remove. retrying will have the same effect

Copy link
Contributor

@infraio infraio Jun 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I didn't follow here is why region dir changed? Add more comments to code too?

((FSTableDescriptors)(env.getMasterServices().getTableDescriptors()))
.createTableDescriptorForTableDirectory(tempTableDir,
TableDescriptorBuilder.newBuilder(tableDescriptor).build(), false);
Expand Down