HBASE-24205 Create metric to know the number of reads that happens from memstore by ramkrish86 · Pull Request #1929 · apache/hbase

ramkrish86 · 2020-06-19T07:53:25Z

PR for branch-2.2

…pache#1920) * HBASE-24205 - Create metric to know the number of reads that happens from memstore (branch-2) * Add the optimization as in master and fix whitestyle and checkstyle * Fix compilation error that accidently crept in Authored-by: Ramkrishna <ramkrishna@apache.org> Signed-off by:Anoop Sam John<anoopsamjohn@gmail.com> Signed-off by:Viraj Jasani<virajjasani@apache.org>

Apache-HBase · 2020-06-19T12:31:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 4 new or modified test files.
		_ branch-2.2 Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 41s	branch-2.2 passed
+1 💚	compile	1m 35s	branch-2.2 passed
+1 💚	checkstyle	1m 52s	branch-2.2 passed
+1 💚	shadedjars	4m 29s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 6s	branch-2.2 passed
+0 🆗	spotbugs	3m 49s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	4m 44s	branch-2.2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 14s	the patch passed
+1 💚	compile	1m 31s	the patch passed
+1 💚	javac	1m 31s	the patch passed
-1 ❌	checkstyle	1m 29s	hbase-server: The patch generated 1 new + 91 unchanged - 1 fixed = 92 total (was 92)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	4m 24s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	28m 28s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1.
+1 💚	javadoc	1m 7s	the patch passed
+1 💚	findbugs	5m 7s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 33s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	0m 38s	hbase-hadoop2-compat in the patch passed.
-1 ❌	unit	193m 16s	hbase-server in the patch failed.
+1 💚	asflicense	1m 20s	The patch does not generate ASF License warnings.
		270m 57s

Reason	Tests
Failed junit tests	hadoop.hbase.master.TestClusterRestartFailoverSplitWithoutZk

Subsystem	Report/Notes
Docker	Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1929/1/artifact/out/Dockerfile
GITHUB PR	#1929
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux d7be7f2da25b 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1929/out/precommit/personality/provided.sh
git revision	branch-2.2 / `e7f17fe`
Default Java	1.8.0_181
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1929/1/artifact/out/diff-checkstyle-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1929/1/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1929/1/testReport/
Max. process+thread count	4551 (vs. ulimit of 10000)
modules	C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1929/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-06-19T16:35:55Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 4 new or modified test files.
		_ branch-2.2 Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	6m 13s	branch-2.2 passed
+1 💚	compile	1m 32s	branch-2.2 passed
+1 💚	checkstyle	1m 55s	branch-2.2 passed
+1 💚	shadedjars	4m 56s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 7s	branch-2.2 passed
+0 🆗	spotbugs	4m 12s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	5m 22s	branch-2.2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 17s	the patch passed
+1 💚	compile	1m 29s	the patch passed
+1 💚	javac	1m 29s	the patch passed
-1 ❌	checkstyle	1m 26s	hbase-server: The patch generated 2 new + 91 unchanged - 1 fixed = 93 total (was 92)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	4m 22s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	27m 35s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1.
+1 💚	javadoc	1m 2s	the patch passed
+1 💚	findbugs	4m 53s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 32s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	0m 36s	hbase-hadoop2-compat in the patch passed.
-1 ❌	unit	165m 28s	hbase-server in the patch failed.
+1 💚	asflicense	1m 13s	The patch does not generate ASF License warnings.
		243m 25s

Reason	Tests
Failed junit tests	hadoop.hbase.quotas.TestSpaceQuotaBasicFunctioning

Subsystem	Report/Notes
Docker	Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1929/2/artifact/out/Dockerfile
GITHUB PR	#1929
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 8a5a27fdd94b 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1929/out/precommit/personality/provided.sh
git revision	branch-2.2 / `e7f17fe`
Default Java	1.8.0_181
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1929/2/artifact/out/diff-checkstyle-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1929/2/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1929/2/testReport/
Max. process+thread count	5111 (vs. ulimit of 10000)
modules	C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1929/2/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

…om memstore (apache#1929) * HBASE-24205 - Create metric to know the number of reads that happens (apache#1920) * HBASE-24205 - Create metric to know the number of reads that happens from memstore (branch-2) * Add the optimization as in master and fix whitestyle and checkstyle * Fix compilation error that accidently crept in Authored-by: Ramkrishna <ramkrishna@apache.org> Signed-off by:Anoop Sam John<anoopsamjohn@gmail.com> Signed-off by:Viraj Jasani<virajjasani@apache.org> * Merger changes * Remove unnecessary methods as part of rebase * Removed the empty lines

…om memstore (#1929) (#1958) * HBASE-24205 - Create metric to know the number of reads that happens (#1920) * HBASE-24205 - Create metric to know the number of reads that happens from memstore (branch-2) * Add the optimization as in master and fix whitestyle and checkstyle * Fix compilation error that accidently crept in Authored-by: Ramkrishna <ramkrishna@apache.org> Signed-off by:Anoop Sam John<anoopsamjohn@gmail.com> Signed-off by:Viraj Jasani<virajjasani@apache.org> * Merger changes * Remove unnecessary methods as part of rebase * Removed the empty lines

…om memstore (apache#1929) * HBASE-24205 - Create metric to know the number of reads that happens (apache#1920) * HBASE-24205 - Create metric to know the number of reads that happens from memstore (branch-2) * Add the optimization as in master and fix whitestyle and checkstyle * Fix compilation error that accidently crept in Authored-by: Ramkrishna <ramkrishna@apache.org> Signed-off by:Anoop Sam John<anoopsamjohn@gmail.com> Signed-off by:Viraj Jasani<virajjasani@apache.org> * Merger changes * Remove unnecessary methods as part of rebase * Removed the empty lines (cherry picked from commit 81ea8e5) Change-Id: Ie1e20b9e051e1dfcadbb410db56d9823e0c14aa4

ramkrish86 added 3 commits June 19, 2020 13:05

Merger changes

8567624

Remove unnecessary methods as part of rebase

1a69bc7

infraio changed the title ~~Branch 2.2 hbase 24205~~ HBASE-24205 Create metric to know the number of reads that happens from memstore Jun 19, 2020

infraio added the enhancement label Jun 19, 2020

Removed the empty lines

0026c84

ramkrish86 merged commit 81ea8e5 into apache:branch-2.2 Jun 22, 2020

ramkrish86 mentioned this pull request Jun 23, 2020

HBASE-24205 Create metric to know the number of reads that happens fr… #1958

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-24205 Create metric to know the number of reads that happens from memstore#1929

HBASE-24205 Create metric to know the number of reads that happens from memstore#1929
ramkrish86 merged 4 commits intoapache:branch-2.2from
ramkrish86:branch_2.2_HBASE-24205

ramkrish86 commented Jun 19, 2020

Uh oh!

Apache-HBase commented Jun 19, 2020

Uh oh!

Apache-HBase commented Jun 19, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ramkrish86 commented Jun 19, 2020

Uh oh!

Apache-HBase commented Jun 19, 2020

Uh oh!

Apache-HBase commented Jun 19, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants