[Flaky Test][branch-1] TestFromClientSide#testCheckAndDeleteWithCompareOp by Reidddddd · Pull Request #2396 · apache/hbase

Reidddddd · 2020-09-14T11:04:41Z

https://issues.apache.org/jira/browse/HBASE-25025

Apache-HBase · 2020-09-14T14:02:09Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ branch-1 Compile Tests _
+1 💚	mvninstall	9m 53s	branch-1 passed
+1 💚	compile	0m 42s	branch-1 passed with JDK v1.8.0_262
+1 💚	compile	0m 45s	branch-1 passed with JDK v1.7.0_272
+1 💚	checkstyle	1m 47s	branch-1 passed
+1 💚	shadedjars	3m 3s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 48s	branch-1 passed with JDK v1.8.0_262
+1 💚	javadoc	0m 40s	branch-1 passed with JDK v1.7.0_272
+0 🆗	spotbugs	3m 2s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 0s	branch-1 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 54s	the patch passed
+1 💚	compile	0m 42s	the patch passed with JDK v1.8.0_262
+1 💚	javac	0m 42s	the patch passed
+1 💚	compile	0m 43s	the patch passed with JDK v1.7.0_272
+1 💚	javac	0m 43s	the patch passed
+1 💚	checkstyle	1m 36s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	2m 49s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	4m 45s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚	javadoc	0m 30s	the patch passed with JDK v1.8.0_262
+1 💚	javadoc	0m 39s	the patch passed with JDK v1.7.0_272
+1 💚	findbugs	2m 53s	the patch passed
		_ Other Tests _
-1 ❌	unit	134m 45s	hbase-server in the patch failed.
+1 💚	asflicense	0m 37s	The patch does not generate ASF License warnings.
		176m 49s

Reason	Tests
Failed junit tests	hadoop.hbase.replication.TestReplicationSyncUpTool

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2396/1/artifact/out/Dockerfile
GITHUB PR	#2396
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 1df2c8c39b0d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2396/out/precommit/personality/provided.sh
git revision	branch-1 / `7801b45`
Default Java	1.7.0_272
Multi-JDK versions	/usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2396/1/artifact/out/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2396/1/testReport/
Max. process+thread count	4404 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2396/1/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Reidddddd · 2020-09-15T04:24:31Z

not related

virajjasani · 2020-09-15T16:06:15Z

hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java

+    table.put(bbbb);
    ok = table.checkAndDelete(ROW, FAMILY, QUALIFIER, CompareOp.LESS_OR_EQUAL, value1, delete);
-    assertEquals(ok, true);
-    table.put(put2);


so this was just a redundant put right?

virajjasani · 2020-09-15T16:10:50Z

hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java


    // cell = "bbbb", using "aaaa" to compare only LESS/LESS_OR_EQUAL/NOT_EQUAL
    // turns out "match"
+    table.put(bbbb);


Curious to know if keeping this put operation on this line is a code improvement or has something to do with flaky behaviour?

Just for readability only, this was originally in line 5033. I just separated it from initialization.

virajjasani

+1

Apache-HBase · 2020-09-16T10:29:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 47s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ branch-1 Compile Tests _
+1 💚	mvninstall	10m 40s	branch-1 passed
+1 💚	compile	0m 55s	branch-1 passed with JDK v1.8.0_262
+1 💚	compile	1m 1s	branch-1 passed with JDK v1.7.0_272
+1 💚	checkstyle	2m 0s	branch-1 passed
+1 💚	shadedjars	3m 9s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 49s	branch-1 passed with JDK v1.8.0_262
+1 💚	javadoc	0m 45s	branch-1 passed with JDK v1.7.0_272
+0 🆗	spotbugs	3m 5s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 0s	branch-1 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 55s	the patch passed
+1 💚	compile	0m 39s	the patch passed with JDK v1.8.0_262
+1 💚	javac	0m 39s	the patch passed
+1 💚	compile	0m 44s	the patch passed with JDK v1.7.0_272
+1 💚	javac	0m 44s	the patch passed
+1 💚	checkstyle	1m 37s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	2m 49s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	4m 39s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚	javadoc	0m 30s	the patch passed with JDK v1.8.0_262
+1 💚	javadoc	0m 39s	the patch passed with JDK v1.7.0_272
+1 💚	findbugs	2m 52s	the patch passed
		_ Other Tests _
-1 ❌	unit	152m 14s	hbase-server in the patch failed.
+1 💚	asflicense	0m 44s	The patch does not generate ASF License warnings.
		196m 22s

Reason	Tests
Failed junit tests	hadoop.hbase.mapreduce.TestImportExport
	hadoop.hbase.replication.TestMasterReplication
	hadoop.hbase.replication.TestReplicationStatus
	hadoop.hbase.replication.regionserver.TestWALEntryStream
	hadoop.hbase.util.TestHBaseFsck
	hadoop.hbase.mapreduce.TestImportTsv
	hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpointNoMaster
	hadoop.hbase.mapreduce.TestMultiTableInputFormat

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2396/2/artifact/out/Dockerfile
GITHUB PR	#2396
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux f17d911748d6 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2396/out/precommit/personality/provided.sh
git revision	branch-1 / `7801b45`
Default Java	1.7.0_272
Multi-JDK versions	/usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2396/2/artifact/out/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2396/2/testReport/
Max. process+thread count	4370 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2396/2/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

…eteWithCompareOp

Reidddddd · 2020-09-28T09:33:25Z

This version should be much stable, let's see

Apache-HBase · 2020-09-28T12:41:06Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	6m 52s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ branch-1 Compile Tests _
+1 💚	mvninstall	10m 0s	branch-1 passed
+1 💚	compile	0m 44s	branch-1 passed with JDK v1.8.0_262
+1 💚	compile	0m 48s	branch-1 passed with JDK v1.7.0_272
+1 💚	checkstyle	1m 50s	branch-1 passed
+1 💚	shadedjars	3m 13s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 51s	branch-1 passed with JDK v1.8.0_262
+1 💚	javadoc	0m 45s	branch-1 passed with JDK v1.7.0_272
+0 🆗	spotbugs	3m 12s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 9s	branch-1 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 3s	the patch passed
+1 💚	compile	0m 45s	the patch passed with JDK v1.8.0_262
+1 💚	javac	0m 45s	the patch passed
+1 💚	compile	0m 47s	the patch passed with JDK v1.7.0_272
+1 💚	javac	0m 47s	the patch passed
+1 💚	checkstyle	1m 42s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	2m 59s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	4m 52s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚	javadoc	0m 35s	the patch passed with JDK v1.8.0_262
+1 💚	javadoc	0m 43s	the patch passed with JDK v1.7.0_272
+1 💚	findbugs	3m 4s	the patch passed
		_ Other Tests _
+1 💚	unit	137m 22s	hbase-server in the patch passed.
+1 💚	asflicense	0m 39s	The patch does not generate ASF License warnings.
		187m 32s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2396/3/artifact/out/Dockerfile
GITHUB PR	#2396
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux b4418eca196e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2396/out/precommit/personality/provided.sh
git revision	branch-1 / `53d8af5`
Default Java	1.7.0_272
Multi-JDK versions	/usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2396/3/testReport/
Max. process+thread count	4765 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2396/3/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Reidddddd requested a review from apurtell September 15, 2020 04:24

virajjasani reviewed Sep 15, 2020

View reviewed changes

virajjasani approved these changes Sep 16, 2020

View reviewed changes

HBASE-25025 [Flaky Test][branch-1] TestFromClientSide#testCheckAndDel…

2537bc0

…eteWithCompareOp

Reidddddd force-pushed the HBASE-25025 branch from 7434524 to 2537bc0 Compare September 28, 2020 09:32

Reidddddd merged commit 93b76fd into apache:branch-1 Sep 29, 2020

Reidddddd deleted the HBASE-25025 branch September 29, 2020 06:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Flaky Test][branch-1] TestFromClientSide#testCheckAndDeleteWithCompareOp#2396

[Flaky Test][branch-1] TestFromClientSide#testCheckAndDeleteWithCompareOp#2396
Reidddddd merged 1 commit intoapache:branch-1from
Reidddddd:HBASE-25025

Reidddddd commented Sep 14, 2020

Uh oh!

Apache-HBase commented Sep 14, 2020

Uh oh!

Reidddddd commented Sep 15, 2020

Uh oh!

virajjasani Sep 15, 2020

Uh oh!

Reidddddd Sep 16, 2020

Uh oh!

virajjasani Sep 15, 2020

Uh oh!

Reidddddd Sep 16, 2020

Uh oh!

virajjasani left a comment

Uh oh!

Apache-HBase commented Sep 16, 2020

Uh oh!

Reidddddd commented Sep 28, 2020

Uh oh!

Apache-HBase commented Sep 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Reidddddd commented Sep 14, 2020

Uh oh!

Apache-HBase commented Sep 14, 2020

Uh oh!

Reidddddd commented Sep 15, 2020

Uh oh!

virajjasani Sep 15, 2020

Choose a reason for hiding this comment

Uh oh!

Reidddddd Sep 16, 2020

Choose a reason for hiding this comment

Uh oh!

virajjasani Sep 15, 2020

Choose a reason for hiding this comment

Uh oh!

Reidddddd Sep 16, 2020

Choose a reason for hiding this comment

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Sep 16, 2020

Uh oh!

Reidddddd commented Sep 28, 2020

Uh oh!

Apache-HBase commented Sep 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants