HBASE-25061 Update default URL to KEYS file in `hbase-vote.sh` by ndimiduk · Pull Request #2416 · apache/hbase

ndimiduk · 2020-09-17T21:17:33Z

No description provided.

Apache-HBase · 2020-09-17T21:20:18Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 25s	Maven dependency ordering for branch
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 9s	Maven dependency ordering for patch
		_ Other Tests _
		1m 53s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2416/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2416
Optional Tests
uname	Linux cca0f04cd742 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e386ec5`
Max. process+thread count	50 (vs. ulimit of 12500)
modules	C: U:
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2416/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-09-17T21:21:31Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 38s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	shelldocs	0m 0s	Shelldocs was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 8s	Maven dependency ordering for patch
+1 💚	shellcheck	0m 1s	There were no new shellcheck issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
		_ Other Tests _
+0 🆗	asflicense	0m 0s	ASF License check generated no output?
		3m 15s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2416/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2416
Optional Tests	dupname asflicense shellcheck shelldocs
uname	Linux 389e3fee79e2 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e386ec5`
Max. process+thread count	44 (vs. ulimit of 12500)
modules	C: U:
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2416/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-09-17T21:21:56Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 57s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 25s	Maven dependency ordering for branch
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 8s	Maven dependency ordering for patch
		_ Other Tests _
		3m 38s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2416/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2416
Optional Tests
uname	Linux 7d60964729a1 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e386ec5`
Max. process+thread count	51 (vs. ulimit of 12500)
modules	C: U:
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2416/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

HorizonNet

LGTM overall. Should the developer documentation for this flag and the download links also be updated with this one?

virajjasani

+1

virajjasani · 2020-09-18T10:16:55Z

LGTM overall. Should the developer documentation for this flag and the download links also be updated with this one?

Let me address this concern and keep the PR ready. Since the change is minor, hope it is fine with you @ndimiduk .

Apache-HBase · 2020-09-18T10:20:09Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
		_ Patch Compile Tests _
		_ Other Tests _
		1m 21s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2416/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2416
Optional Tests
uname	Linux 7c205304aaac 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e386ec5`
Max. process+thread count	55 (vs. ulimit of 12500)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2416/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-09-18T10:21:07Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 19s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
		_ Patch Compile Tests _
		_ Other Tests _
		2m 17s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2416/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2416
Optional Tests
uname	Linux 90890abdde75 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e386ec5`
Max. process+thread count	43 (vs. ulimit of 12500)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2416/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-09-18T11:13:25Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 58s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	shelldocs	0m 0s	Shelldocs was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	5m 23s	master passed
+1 💚	mvnsite	14m 24s	master passed
+0 🆗	refguide	6m 32s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 51s	the patch passed
+1 💚	mvnsite	12m 57s	the patch passed
+1 💚	shellcheck	0m 1s	There were no new shellcheck issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+0 🆗	refguide	6m 36s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
		_ Other Tests _
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		54m 27s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2416/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2416
Optional Tests	dupname asflicense shellcheck shelldocs refguide mvnsite xml
uname	Linux dd3635438517 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e386ec5`
refguide	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2416/2/artifact/yetus-general-check/output/branch-site/book.html
refguide	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2416/2/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count	79 (vs. ulimit of 12500)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2416/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

ndimiduk · 2020-09-18T20:12:10Z

Ah, thanks. Yes those are good too.

ndimiduk · 2020-09-18T20:17:13Z

Oh, sorry. This was my first time making a PR from within GH's UI. Apparently i screwed up the location of the PR branch.

HBASE-25061 Update default URL to KEYS file in hbase-vote.sh

a4651c7

HorizonNet reviewed Sep 17, 2020

View reviewed changes

busbey approved these changes Sep 18, 2020

View reviewed changes

virajjasani approved these changes Sep 18, 2020

View reviewed changes

changes suggested by Jan

2adf747

HorizonNet approved these changes Sep 18, 2020

View reviewed changes

ndimiduk merged commit 5e12c0a into master Sep 18, 2020

ndimiduk deleted the 25061-hbase-vote-KEYS-url branch September 18, 2020 20:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-25061 Update default URL to KEYS file in `hbase-vote.sh`#2416

HBASE-25061 Update default URL to KEYS file in `hbase-vote.sh`#2416
ndimiduk merged 2 commits intomasterfrom
25061-hbase-vote-KEYS-url

ndimiduk commented Sep 17, 2020

Uh oh!

Apache-HBase commented Sep 17, 2020

Uh oh!

Apache-HBase commented Sep 17, 2020

Uh oh!

Apache-HBase commented Sep 17, 2020

Uh oh!

HorizonNet left a comment

Uh oh!

virajjasani left a comment

Uh oh!

virajjasani commented Sep 18, 2020

Uh oh!

Apache-HBase commented Sep 18, 2020

Uh oh!

Apache-HBase commented Sep 18, 2020

Uh oh!

Apache-HBase commented Sep 18, 2020

Uh oh!

ndimiduk commented Sep 18, 2020

Uh oh!

ndimiduk commented Sep 18, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

ndimiduk commented Sep 17, 2020

Uh oh!

Apache-HBase commented Sep 17, 2020

Uh oh!

Apache-HBase commented Sep 17, 2020

Uh oh!

Apache-HBase commented Sep 17, 2020

Uh oh!

HorizonNet left a comment

Choose a reason for hiding this comment

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

virajjasani commented Sep 18, 2020

Uh oh!

Apache-HBase commented Sep 18, 2020

Uh oh!

Apache-HBase commented Sep 18, 2020

Uh oh!

Apache-HBase commented Sep 18, 2020

Uh oh!

ndimiduk commented Sep 18, 2020

Uh oh!

ndimiduk commented Sep 18, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants