HBASE-25220 Backport HBASE-24246 Miscellaneous hbck2 fixMeta bulk merge fixes: better logging around merges/overlap-fixing, 'HBCK Report' overlap listing, and configuration#2588
Merged
Conversation
…ge fixes: better logging around merges/overlap-fixing, 'HBCK Report' overlap listing, and configuration Includes addendum hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java Fix weird brackets around each region name when logging. hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetaFixer.java Log when we hit the max merge limit. Also up limit to 64. hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java Make logs make more sense to operator. hbase-server/src/main/resources/hbase-webapps/master/hbck.jsp Make RegionName show when you mouseover so long names don't mess up display of holes and overlaps. Address Mingliang Liu liuml07 feedback Signed-off-by: Peter Somogyi <psomogyi@apache.org> Signed-off-by: Mingliang Liu <liuml07@apache.org> Addendum to address minor feedback on text
|
🎊 +1 overall
This message was automatically generated. |
saintstack
approved these changes
Oct 26, 2020
| currentMergeSet.size() >= maxMergeCount) { | ||
| // Log when we cut-off-merge because we hit the configured maximum merge limit. | ||
| if (currentMergeSet.size() >= maxMergeCount) { | ||
| LOG.warn("Ran into maximum-at-a-time merges limit={}", maxMergeCount); |
| String msg = "Unable to merge non-adjacent or non-overlapping regions " + | ||
| previous.getShortNameToLog() + ", " + ri.getShortNameToLog() + " when force=false"; | ||
| String msg = "Unable to merge non-adjacent or non-overlapping regions '" + | ||
| previous.getShortNameToLog() + "', '" + ri.getShortNameToLog() + "' when force=false"; |
Contributor
There was a problem hiding this comment.
nit: we need the ' characters? we don't usually do this?
Contributor
Author
There was a problem hiding this comment.
This is a clean cherry-pick of your commit to master, the ' character was part of the original commit. 🙂 It was not pushed to branch-2.2 at that time I found this as a nice improvement.
| ", because a parent, " + RegionInfo.getShortNameToLog(ri) + ", has a merge qualifier " + | ||
| "(if a 'merge column' in parent, it was recently merged but still has outstanding " + | ||
| "references to its parents that must be cleared before it can participate in merge -- " + | ||
| "major compact it to hurry clearing of its references)"; |
wchevreuil
pushed a commit
to wchevreuil/hbase
that referenced
this pull request
May 24, 2021
…ge fixes: better logging around merges/overlap-fixing, 'HBCK Report' overlap listing, and configuration (apache#2588) Includes addendum hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java Fix weird brackets around each region name when logging. hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetaFixer.java Log when we hit the max merge limit. Also up limit to 64. hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java Make logs make more sense to operator. hbase-server/src/main/resources/hbase-webapps/master/hbck.jsp Make RegionName show when you mouseover so long names don't mess up display of holes and overlaps. Address Mingliang Liu liuml07 feedback Signed-off-by: Peter Somogyi <psomogyi@apache.org> Signed-off-by: Mingliang Liu <liuml07@apache.org> Addendum to address minor feedback on text Co-authored-by: Michael Stack <saintstack@users.noreply.github.com> (cherry picked from commit 84cf118) Change-Id: I300e9fa533e88528c4933e26ae2eb8977478063e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes addendum
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
Fix weird brackets around each region name when logging.
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetaFixer.java
Log when we hit the max merge limit. Also up limit to 64.
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java
Make logs make more sense to operator.
hbase-server/src/main/resources/hbase-webapps/master/hbck.jsp
Make RegionName show when you mouseover so long names don't mess up
display of holes and overlaps.
Address Mingliang Liu liuml07 feedback
Signed-off-by: Peter Somogyi psomogyi@apache.org
Signed-off-by: Mingliang Liu liuml07@apache.org
Addendum to address minor feedback on text