HBASE-25285 [branch-1] Fix two methods removed problems reported by compat-check #2658

Reidddddd · 2020-11-16T07:05:02Z

No description provided.

…ompat-check

Reidddddd · 2020-11-16T07:06:15Z

Because they are HBaseInterfaceAudience.COPROC.
Let's keep them, just in case any coprocessor uses.

Apache-HBase · 2020-11-16T07:17:27Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	docker	10m 40s	Docker failed to build yetus/hbase:b249092a5f.

Subsystem	Report/Notes
GITHUB PR	#2658
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2658/1/console
versions	git=2.17.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-11-16T07:23:12Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	docker	0m 11s	Docker failed to build yetus/hbase:b249092a5f.

Subsystem	Report/Notes
GITHUB PR	#2658
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2658/2/console
versions	git=2.17.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Reidddddd · 2020-11-16T07:38:53Z

Archive JUnit-formatted test results
[2020-11-16T07:23:14.835Z] Recording test results
[2020-11-16T07:23:14.982Z] No test report files were found. Configuration error?

any hint?

apurtell

One change requested, otherwise lgtm

apurtell · 2020-11-16T15:46:49Z

hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java


+  @Override
+  public void refreshAuthManager(PolicyProvider pp) {
+    // noop


Can we call the static method from here?

RpcServer is IA.private, and #refreshAuthManager shouldn't be called elsewhere, do we still need the concrete impl

Apache-HBase · 2020-11-17T15:41:56Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	docker	0m 12s	Docker failed to build yetus/hbase:b249092a5f.

Subsystem	Report/Notes
GITHUB PR	#2658
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2658/3/console
versions	git=2.17.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

apurtell

Consider adding a Deprecated annotation to all of these compat methods we put back. Not a big deal. Can be done at commit time.

apurtell · 2020-11-19T18:26:04Z

hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServerInterface.java

+   * for correctness.
+   * @param pp PolicyProvider
+   */
+  @VisibleForTesting


Add a Deprecated annotation. Can be done at commit time.

virajjasani

+1

virajjasani · 2020-11-23T16:56:17Z

Triggered new build, we should see QA result this time.

Apache-HBase · 2020-11-23T19:54:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	12m 0s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-1 Compile Tests _
+1 💚	mvninstall	9m 53s	branch-1 passed
+1 💚	compile	0m 40s	branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚	compile	0m 45s	branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚	checkstyle	1m 42s	branch-1 passed
+1 💚	shadedjars	3m 2s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 48s	branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚	javadoc	0m 41s	branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗	spotbugs	3m 8s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 4s	branch-1 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 58s	the patch passed
+1 💚	compile	0m 41s	the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚	javac	0m 41s	the patch passed
+1 💚	compile	0m 45s	the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚	javac	0m 45s	the patch passed
+1 💚	checkstyle	1m 32s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	2m 49s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	4m 38s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚	javadoc	0m 30s	the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚	javadoc	0m 41s	the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚	findbugs	2m 54s	the patch passed
		_ Other Tests _
+1 💚	unit	125m 25s	hbase-server in the patch passed.
+1 💚	asflicense	0m 35s	The patch does not generate ASF License warnings.
		178m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2658/4/artifact/out/Dockerfile
GITHUB PR	#2658
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux db8abcbc8621 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2658/out/precommit/personality/provided.sh
git revision	branch-1 / `edccfe4`
Default Java	Azul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions	/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2658/4/testReport/
Max. process+thread count	3352 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2658/4/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-11-24T14:23:13Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	7m 52s	Docker mode activated.
-1 ❌	patch	0m 8s	#2658 does not apply to branch-1. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2658/5/artifact/out/Dockerfile
GITHUB PR	#2658
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2658/5/console
versions	git=1.9.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

HBASE-25285 [branch-1] Fix two methods removed problems reported by c…

8741fed

…ompat-check

Reidddddd requested a review from apurtell November 16, 2020 07:05

RpcServer is IA.private, can safely remove the implementation

f463cac

apurtell requested changes Nov 16, 2020

View reviewed changes

Address comment

a47eb90

apurtell approved these changes Nov 19, 2020

View reviewed changes

virajjasani approved these changes Nov 23, 2020

View reviewed changes

Add Deprecated annotation on void refreshAuthManager(PolicyProvider pp);

3ff2b38

Reidddddd merged commit 4640b22 into apache:branch-1 Nov 24, 2020

Reidddddd mentioned this pull request Nov 24, 2020

HBASE-24640 [branch-1] Purge use of VisibleForTesting #2697

Merged

HBASE-25285 [branch-1] Fix two methods removed problems reported by compat-check #2658

HBASE-25285 [branch-1] Fix two methods removed problems reported by compat-check #2658

Uh oh!

Conversation

Reidddddd commented Nov 16, 2020

Uh oh!

Reidddddd commented Nov 16, 2020

Uh oh!

Apache-HBase commented Nov 16, 2020

Uh oh!

Apache-HBase commented Nov 16, 2020

Uh oh!

Reidddddd commented Nov 16, 2020

Uh oh!

apurtell left a comment

Choose a reason for hiding this comment

Uh oh!

apurtell Nov 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reidddddd Nov 17, 2020

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Nov 17, 2020

Uh oh!

apurtell left a comment

Choose a reason for hiding this comment

Uh oh!

apurtell Nov 19, 2020

Choose a reason for hiding this comment

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

virajjasani commented Nov 23, 2020

Uh oh!

Apache-HBase commented Nov 23, 2020

Uh oh!

Apache-HBase commented Nov 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

apurtell Nov 16, 2020 •

edited

Loading