HBASE-25356 HBaseAdmin#getRegion() needs to filter out non-regionName… #2759

huaxiangsun · 2020-12-09T21:39:35Z

… and non-encodedRegionName

Apache-HBase · 2020-12-09T22:35:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 57s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 46s	branch-2 passed
+1 💚	checkstyle	2m 7s	branch-2 passed
+1 💚	spotbugs	3m 58s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 13s	the patch passed
-0 ⚠️	checkstyle	0m 41s	hbase-client: The patch generated 1 new + 124 unchanged - 0 fixed = 125 total (was 124)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	14m 50s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	3m 39s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 23s	The patch does not generate ASF License warnings.
		47m 43s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2759/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2759
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 9794ac38a1f8 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `81868e3`
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2759/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
Max. process+thread count	84 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2759/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-12-10T00:34:29Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 33s	branch-2 passed
+1 💚	compile	1m 24s	branch-2 passed
+1 💚	shadedjars	6m 1s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 2s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 16s	the patch passed
+1 💚	compile	1m 24s	the patch passed
+1 💚	javac	1m 24s	the patch passed
+1 💚	shadedjars	6m 2s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 1s	the patch passed
		_ Other Tests _
-1 ❌	unit	0m 55s	hbase-client in the patch failed.
+1 💚	unit	138m 51s	hbase-server in the patch passed.
		167m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2759/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#2759
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 609f4fb06765 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `81868e3`
Default Java	AdoptOpenJDK-1.8.0_232-b09
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2759/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-client.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2759/1/testReport/
Max. process+thread count	4134 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2759/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

huaxiangsun · 2020-12-10T01:45:42Z

checking the client error at my local machine now.

Apache-HBase · 2020-12-10T02:10:58Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 43s	branch-2 passed
+1 💚	compile	1m 48s	branch-2 passed
+1 💚	shadedjars	7m 39s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 19s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 50s	the patch passed
+1 💚	compile	1m 53s	the patch passed
+1 💚	javac	1m 53s	the patch passed
+1 💚	shadedjars	7m 46s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 12s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 40s	hbase-client in the patch passed.
+1 💚	unit	225m 39s	hbase-server in the patch passed.
		263m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2759/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2759
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a4a9a07cab7e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `81868e3`
Default Java	AdoptOpenJDK-11.0.6+10
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2759/1/testReport/
Max. process+thread count	2490 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2759/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

huaxiangsun · 2020-12-10T16:53:44Z

My local run of hbase-client tests passed so I think it is transient env issue in the test machine.

hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java

saintstack · 2020-12-10T18:47:21Z

hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java

  }

+  private boolean isHexChar(char c) {
+    return (c >= 'A' && c <= 'F') || (c >= 'a' && c <= 'f') || (c >= '0' && c <= '9');


There is Bytes.isHexDigit. It is missing (c >= 'a' && c <= 'f'). Bytes might be better place for this than here?

I tried poking around.. you'd think this sort of thing would be available in a lib... but I couldn't find an easy ref after looking for 5 mins.

hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java

saintstack · 2020-12-14T19:02:35Z

You going to put up new changes @huaxiangsun ?

huaxiangsun · 2020-12-16T05:54:44Z

You going to put up new changes @huaxiangsun ?

Yeah, I am going to put up a new patch.

… and non-encodedRegionName

huaxiangsun · 2020-12-17T20:11:00Z

A new patch is uploaded.

Apache-HBase · 2020-12-17T20:47:50Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 47s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 48s	branch-2 passed
+1 💚	checkstyle	1m 44s	branch-2 passed
+1 💚	spotbugs	3m 13s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 16s	the patch passed
+1 💚	checkstyle	1m 45s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 45s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	4m 34s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 30s	The patch does not generate ASF License warnings.
		39m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2759/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2759
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 49ebe4ddc600 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `32c4432`
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2759/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-12-17T22:55:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 48s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 27s	branch-2 passed
+1 💚	compile	1m 43s	branch-2 passed
+1 💚	shadedjars	6m 59s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 13s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 8s	the patch passed
+1 💚	compile	1m 41s	the patch passed
+1 💚	javac	1m 41s	the patch passed
+1 💚	shadedjars	6m 52s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 9s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 31s	hbase-client in the patch passed.
+1 💚	unit	132m 34s	hbase-server in the patch passed.
		167m 14s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2759/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2759
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a59fb7241bdb 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `32c4432`
Default Java	AdoptOpenJDK-11.0.6+10
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2759/2/testReport/
Max. process+thread count	4307 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2759/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-12-17T23:16:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 48s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 36s	branch-2 passed
+1 💚	compile	1m 48s	branch-2 passed
+1 💚	shadedjars	8m 8s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 18s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 25s	the patch passed
+1 💚	compile	1m 48s	the patch passed
+1 💚	javac	1m 48s	the patch passed
+1 💚	shadedjars	8m 18s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 31s	hbase-client in the patch passed.
+1 💚	unit	150m 28s	hbase-server in the patch passed.
		188m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2759/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#2759
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b453cb7e1c2d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `32c4432`
Default Java	AdoptOpenJDK-1.8.0_232-b09
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2759/2/testReport/
Max. process+thread count	3984 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2759/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

… and non-encodedRegionName (apache#2759) Signed-off-by: stack <stack@apache.org>

… and non-encodedRegionName (#2759) (#2788) Signed-off-by: stack <stack@apache.org>

… and non-encodedRegionName (#2759) (#2789) Signed-off-by: stack <stack@apache.org>

saintstack approved these changes Dec 10, 2020

View reviewed changes

HBASE-25356 HBaseAdmin#getRegion() needs to filter out non-regionName…

0f2ed94

… and non-encodedRegionName

huaxiangsun force-pushed the b2.HBASE-25356 branch from b67ccf5 to 0f2ed94 Compare December 17, 2020 20:07

huaxiangsun merged commit 22dd054 into apache:branch-2 Dec 17, 2020

huaxiangsun added a commit to huaxiangsun/hbase that referenced this pull request Dec 18, 2020

HBASE-25356 HBaseAdmin#getRegion() needs to filter out non-regionName…

c491ec9

… and non-encodedRegionName (apache#2759) Signed-off-by: stack <stack@apache.org>

huaxiangsun mentioned this pull request Dec 18, 2020

HBASE-25356 HBaseAdmin#getRegion() needs to filter out non-regionName… #2788

Merged

huaxiangsun added a commit to huaxiangsun/hbase that referenced this pull request Dec 18, 2020

HBASE-25356 HBaseAdmin#getRegion() needs to filter out non-regionName…

b5a7651

… and non-encodedRegionName (apache#2759) Signed-off-by: stack <stack@apache.org>

huaxiangsun mentioned this pull request Dec 18, 2020

HBASE-25356 HBaseAdmin#getRegion() needs to filter out non-regionName… #2789

Merged

huaxiangsun added a commit that referenced this pull request Dec 18, 2020

HBASE-25356 HBaseAdmin#getRegion() needs to filter out non-regionName…

1069647

… and non-encodedRegionName (#2759) (#2788) Signed-off-by: stack <stack@apache.org>

huaxiangsun added a commit that referenced this pull request Dec 18, 2020

HBASE-25356 HBaseAdmin#getRegion() needs to filter out non-regionName…

baf3122

… and non-encodedRegionName (#2759) (#2789) Signed-off-by: stack <stack@apache.org>

HBASE-25356 HBaseAdmin#getRegion() needs to filter out non-regionName… #2759

HBASE-25356 HBaseAdmin#getRegion() needs to filter out non-regionName… #2759

Uh oh!

Conversation

huaxiangsun commented Dec 9, 2020

Uh oh!

Apache-HBase commented Dec 9, 2020

Uh oh!

Apache-HBase commented Dec 10, 2020

Uh oh!

huaxiangsun commented Dec 10, 2020

Uh oh!

Apache-HBase commented Dec 10, 2020

Uh oh!

huaxiangsun commented Dec 10, 2020

Uh oh!

Uh oh!

saintstack Dec 10, 2020

Choose a reason for hiding this comment

Uh oh!

saintstack Dec 10, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

saintstack commented Dec 14, 2020

Uh oh!

huaxiangsun commented Dec 16, 2020

Uh oh!

huaxiangsun commented Dec 17, 2020

Uh oh!

Apache-HBase commented Dec 17, 2020

Uh oh!

Apache-HBase commented Dec 17, 2020

Uh oh!

Apache-HBase commented Dec 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants