HBASE-25587 [hbck2] Schedule SCP for all unknown servers by petersomogyi · Pull Request #2978 · apache/hbase

petersomogyi · 2021-02-23T12:03:59Z

No description provided.

petersomogyi · 2021-02-23T12:05:28Z

hbase-protocol-shaded/src/main/protobuf/server/master/Master.proto

I wanted to use similar naming to the existing SCP but it is getting too long. I'm open for suggestions how it should be named.
RecoverUnknownServers?

Maybe ScheduleSCPsForUnknownServersRequest and ScheduleSCPsForUnknownServersResponse?

wchevreuil

LGTM. This is of great utility, I wonder if we can have a complete client-side only version of it in hbck2 that wraps current existing scheduleRecoveries method, so that hbase versions that don't support this server-side method could also benefit from this convenience?

wchevreuil · 2021-02-23T12:51:56Z

hbase-protocol-shaded/src/main/protobuf/server/master/Master.proto

Maybe ScheduleSCPsForUnknownServersRequest and ScheduleSCPsForUnknownServersResponse?

Apache-HBase · 2021-03-03T14:35:09Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 22s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 5s	master passed
+1 💚	compile	5m 45s	master passed
+1 💚	checkstyle	1m 49s	master passed
+1 💚	spotbugs	6m 55s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 55s	the patch passed
+1 💚	compile	5m 40s	the patch passed
+1 💚	cc	5m 40s	the patch passed
+1 💚	javac	5m 40s	the patch passed
+1 💚	checkstyle	0m 9s	The patch passed checkstyle in hbase-protocol-shaded
+1 💚	checkstyle	0m 27s	The patch passed checkstyle in hbase-client
+1 💚	checkstyle	1m 11s	hbase-server: The patch generated 0 new + 19 unchanged - 1 fixed = 19 total (was 20)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	19m 17s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	hbaseprotoc	2m 3s	the patch passed
+1 💚	spotbugs	7m 21s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 34s	The patch does not generate ASF License warnings.
		69m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2978/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2978
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
uname	Linux 6811d01e3946 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `5d9a6ed`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2978/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-03-03T16:17:16Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 16s	master passed
+1 💚	compile	2m 43s	master passed
+1 💚	shadedjars	7m 5s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 21s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 22s	the patch passed
+1 💚	compile	2m 42s	the patch passed
+1 💚	javac	2m 42s	the patch passed
+1 💚	shadedjars	7m 7s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 3s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 7s	hbase-client in the patch passed.
+1 💚	unit	135m 2s	hbase-server in the patch passed.
		171m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2978/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2978
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b74c6a70b44a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `5d9a6ed`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2978/3/testReport/
Max. process+thread count	4367 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2978/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-03-03T17:38:16Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 15s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 31s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 57s	master passed
+1 💚	compile	2m 12s	master passed
+1 💚	shadedjars	7m 14s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 9s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 48s	the patch passed
+1 💚	compile	2m 9s	the patch passed
+1 💚	javac	2m 10s	the patch passed
+1 💚	shadedjars	7m 21s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 9s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 46s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 7s	hbase-client in the patch passed.
+1 💚	unit	217m 41s	hbase-server in the patch passed.
		252m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2978/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2978
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux aeaa43d2a9fb 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `5d9a6ed`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2978/3/testReport/
Max. process+thread count	3690 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2978/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> (cherry picked from commit 3a2b574) Change-Id: I2e1358648b0f38cda4a0173fa6a525e02123adba

HBASE-25587 [hbck2] Schedule SCP for all unknown servers

c5cc5f3

petersomogyi commented Feb 23, 2021

View reviewed changes

wchevreuil approved these changes Feb 23, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

Rename to ScheduleSCPsForUnknownServers based on feedback

d74f44c

This comment has been minimized.

Sign in to view

Fix import order

20df57d

petersomogyi merged commit 0cc1ae4 into apache:master Mar 11, 2021

petersomogyi deleted the HBASE-25587 branch March 11, 2021 16:20

petersomogyi added a commit that referenced this pull request Mar 11, 2021

HBASE-25587 [hbck2] Schedule SCP for all unknown servers (#2978)

af8dc2e

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>

petersomogyi added a commit that referenced this pull request Mar 11, 2021

HBASE-25587 [hbck2] Schedule SCP for all unknown servers (#2978)

723f2ee

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>

petersomogyi added a commit that referenced this pull request Mar 11, 2021

HBASE-25587 [hbck2] Schedule SCP for all unknown servers (#2978)

3a2b574

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>

petersomogyi added a commit that referenced this pull request Mar 11, 2021

HBASE-25587 [hbck2] Schedule SCP for all unknown servers (#2978)

092bbaf

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-25587 [hbck2] Schedule SCP for all unknown servers#2978

HBASE-25587 [hbck2] Schedule SCP for all unknown servers#2978
petersomogyi merged 3 commits intoapache:masterfrom
petersomogyi:HBASE-25587

petersomogyi commented Feb 23, 2021

Uh oh!

petersomogyi Feb 23, 2021

Uh oh!

wchevreuil Feb 23, 2021

Uh oh!

wchevreuil left a comment

Uh oh!

wchevreuil Feb 23, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Mar 3, 2021

Uh oh!

Apache-HBase commented Mar 3, 2021

Uh oh!

Apache-HBase commented Mar 3, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

petersomogyi commented Feb 23, 2021

Uh oh!

petersomogyi Feb 23, 2021

Choose a reason for hiding this comment

Uh oh!

wchevreuil Feb 23, 2021

Choose a reason for hiding this comment

Uh oh!

wchevreuil left a comment

Choose a reason for hiding this comment

Uh oh!

wchevreuil Feb 23, 2021

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Mar 3, 2021

Uh oh!

Apache-HBase commented Mar 3, 2021

Uh oh!

Apache-HBase commented Mar 3, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments