HBASE-22577 BufferedMutatorOverAsyncBufferedMutator.tryCompleteFuture… #305

Apache9 · 2019-06-13T13:49:29Z

… consume too much CPU time

...nt/src/main/java/org/apache/hadoop/hbase/client/BufferedMutatorOverAsyncBufferedMutator.java

Apache-HBase · 2019-06-13T18:10:44Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	155	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ HBASE-21512 Compile Tests _
0	mvndep	35	Maven dependency ordering for branch
+1	mvninstall	268	HBASE-21512 passed
+1	compile	77	HBASE-21512 passed
+1	checkstyle	103	HBASE-21512 passed
+1	shadedjars	275	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	236	HBASE-21512 passed
+1	javadoc	54	HBASE-21512 passed
		_ Patch Compile Tests _
0	mvndep	14	Maven dependency ordering for patch
+1	mvninstall	250	the patch passed
+1	compile	77	the patch passed
+1	javac	77	the patch passed
+1	checkstyle	104	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	278	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	772	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	279	the patch passed
+1	javadoc	53	the patch passed
		_ Other Tests _
+1	unit	100	hbase-client in the patch passed.
+1	unit	11908	hbase-server in the patch passed.
+1	asflicense	53	The patch does not generate ASF License warnings.
		15436

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-305/2/artifact/out/Dockerfile
GITHUB PR	#305
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux f122719bee34 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon Sep 24 17:14:57 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	HBASE-21512 / `5ca23c3`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-305/2/testReport/
Max. process+thread count	5028 (vs. ulimit of 10000)
modules	C: hbase-client hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-305/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-06-14T07:19:53Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	206	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ HBASE-21512 Compile Tests _
0	mvndep	34	Maven dependency ordering for branch
+1	mvninstall	273	HBASE-21512 passed
+1	compile	76	HBASE-21512 passed
+1	checkstyle	94	HBASE-21512 passed
+1	shadedjars	258	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	254	HBASE-21512 passed
+1	javadoc	53	HBASE-21512 passed
		_ Patch Compile Tests _
0	mvndep	15	Maven dependency ordering for patch
+1	mvninstall	256	the patch passed
+1	compile	77	the patch passed
+1	javac	77	the patch passed
-1	checkstyle	28	hbase-client: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	260	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	803	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	280	the patch passed
+1	javadoc	53	the patch passed
		_ Other Tests _
+1	unit	106	hbase-client in the patch passed.
-1	unit	15056	hbase-server in the patch failed.
+1	asflicense	50	The patch does not generate ASF License warnings.
		18652

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
	hadoop.hbase.client.TestFromClientSide

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-305/3/artifact/out/Dockerfile
GITHUB PR	#305
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux f065a0be9d94 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	HBASE-21512 / `93a6aaa`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-305/3/artifact/out/diff-checkstyle-hbase-client.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-305/3/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-305/3/testReport/
Max. process+thread count	4723 (vs. ulimit of 10000)
modules	C: hbase-client hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-305/3/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache9 · 2019-06-14T08:52:15Z

Any other concerns? @busbey

...nt/src/main/java/org/apache/hadoop/hbase/client/BufferedMutatorOverAsyncBufferedMutator.java

Apache-HBase · 2019-06-14T21:03:52Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	143	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ HBASE-21512 Compile Tests _
0	mvndep	31	Maven dependency ordering for branch
+1	mvninstall	251	HBASE-21512 passed
+1	compile	74	HBASE-21512 passed
+1	checkstyle	97	HBASE-21512 passed
+1	shadedjars	257	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	234	HBASE-21512 passed
+1	javadoc	55	HBASE-21512 passed
		_ Patch Compile Tests _
0	mvndep	17	Maven dependency ordering for patch
+1	mvninstall	255	the patch passed
+1	compile	79	the patch passed
+1	javac	79	the patch passed
-1	checkstyle	29	hbase-client: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	260	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	727	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	267	the patch passed
+1	javadoc	57	the patch passed
		_ Other Tests _
+1	unit	108	hbase-client in the patch passed.
-1	unit	15277	hbase-server in the patch failed.
+1	asflicense	55	The patch does not generate ASF License warnings.
		18687

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestFromClientSide
	hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
	hadoop.hbase.quotas.TestQuotaAdmin

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-305/4/artifact/out/Dockerfile
GITHUB PR	#305
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux b4d16958a66c 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	HBASE-21512 / `c342064`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-305/4/artifact/out/diff-checkstyle-hbase-client.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-305/4/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-305/4/testReport/
Max. process+thread count	5289 (vs. ulimit of 10000)
modules	C: hbase-client hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-305/4/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache9 · 2019-06-15T00:30:46Z

Any other concerns? Thanks.

… consume too much CPU time

Apache-HBase · 2019-06-15T08:23:45Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	45	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ HBASE-21512 Compile Tests _
0	mvndep	29	Maven dependency ordering for branch
+1	mvninstall	254	HBASE-21512 passed
+1	compile	77	HBASE-21512 passed
+1	checkstyle	94	HBASE-21512 passed
+1	shadedjars	263	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	255	HBASE-21512 passed
+1	javadoc	55	HBASE-21512 passed
		_ Patch Compile Tests _
0	mvndep	16	Maven dependency ordering for patch
+1	mvninstall	249	the patch passed
+1	compile	79	the patch passed
+1	javac	79	the patch passed
+1	checkstyle	94	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	278	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	904	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	318	the patch passed
+1	javadoc	54	the patch passed
		_ Other Tests _
+1	unit	244	hbase-client in the patch passed.
-1	unit	17050	hbase-server in the patch failed.
+1	asflicense	44	The patch does not generate ASF License warnings.
		20742

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestFromClientSide
	hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
	hadoop.hbase.client.TestCloneSnapshotFromClientNormal
	hadoop.hbase.client.TestAsyncTableAdminApi

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-305/5/artifact/out/Dockerfile
GITHUB PR	#305
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 9dfd0754527d 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	HBASE-21512 / `948f33b`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-305/5/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-305/5/testReport/
Max. process+thread count	4860 (vs. ulimit of 10000)
modules	C: hbase-client hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-305/5/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache9 force-pushed the HBASE-22577 branch from def97ba to 06c8bba Compare June 13, 2019 13:52

busbey requested changes Jun 13, 2019

View reviewed changes

...nt/src/main/java/org/apache/hadoop/hbase/client/BufferedMutatorOverAsyncBufferedMutator.java Show resolved Hide resolved

asfgit force-pushed the HBASE-21512 branch from 5ca23c3 to 93a6aaa Compare June 14, 2019 02:06

Apache9 force-pushed the HBASE-22577 branch from 06c8bba to 53abe6c Compare June 14, 2019 02:08

busbey reviewed Jun 14, 2019

View reviewed changes

...nt/src/main/java/org/apache/hadoop/hbase/client/BufferedMutatorOverAsyncBufferedMutator.java Outdated Show resolved Hide resolved

openinx reviewed Jun 14, 2019

View reviewed changes

...nt/src/main/java/org/apache/hadoop/hbase/client/BufferedMutatorOverAsyncBufferedMutator.java Outdated Show resolved Hide resolved

...nt/src/main/java/org/apache/hadoop/hbase/client/BufferedMutatorOverAsyncBufferedMutator.java Show resolved Hide resolved

asfgit force-pushed the HBASE-21512 branch from 93a6aaa to c342064 Compare June 14, 2019 15:49

Apache9 force-pushed the HBASE-22577 branch from 53abe6c to f087392 Compare June 14, 2019 15:51

infraio approved these changes Jun 15, 2019

View reviewed changes

asfgit force-pushed the HBASE-21512 branch from c342064 to 948f33b Compare June 15, 2019 02:33

HBASE-22577 BufferedMutatorOverAsyncBufferedMutator.tryCompleteFuture…

25feab0

… consume too much CPU time

Apache9 force-pushed the HBASE-22577 branch from f087392 to 25feab0 Compare June 15, 2019 02:37

openinx approved these changes Jun 15, 2019

View reviewed changes

Apache9 merged commit b025eda into apache:HBASE-21512 Jun 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-22577 BufferedMutatorOverAsyncBufferedMutator.tryCompleteFuture… #305

HBASE-22577 BufferedMutatorOverAsyncBufferedMutator.tryCompleteFuture… #305

Uh oh!

Apache9 commented Jun 13, 2019

Uh oh!

Uh oh!

Apache-HBase commented Jun 13, 2019

Uh oh!

Apache-HBase commented Jun 14, 2019

Uh oh!

Apache9 commented Jun 14, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Apache-HBase commented Jun 14, 2019

Uh oh!

Apache9 commented Jun 15, 2019

Uh oh!

Apache-HBase commented Jun 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

HBASE-22577 BufferedMutatorOverAsyncBufferedMutator.tryCompleteFuture… #305

HBASE-22577 BufferedMutatorOverAsyncBufferedMutator.tryCompleteFuture… #305

Uh oh!

Conversation

Apache9 commented Jun 13, 2019

Uh oh!

Uh oh!

Apache-HBase commented Jun 13, 2019

Uh oh!

Apache-HBase commented Jun 14, 2019

Uh oh!

Apache9 commented Jun 14, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Apache-HBase commented Jun 14, 2019

Uh oh!

Apache9 commented Jun 15, 2019

Uh oh!

Apache-HBase commented Jun 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants