Skip to content

HBASE-25755 Exclude tomcat-embed-core from libthrift#3141

Merged
petersomogyi merged 1 commit intoapache:masterfrom
petersomogyi:HBASE-25755
Apr 10, 2021
Merged

HBASE-25755 Exclude tomcat-embed-core from libthrift#3141
petersomogyi merged 1 commit intoapache:masterfrom
petersomogyi:HBASE-25755

Conversation

@petersomogyi
Copy link
Contributor

Exlude tomcat-embed-core transitive dependency
Remove outdated exclude rule for slf4j

Exlude tomcat-embed-core transitive dependency
Remove outdated exclude rule for slf4j
@petersomogyi petersomogyi requested a review from pankaj72981 April 9, 2021 17:41
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 44s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 5m 15s master passed
+1 💚 compile 10m 24s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 49s the patch passed
+1 💚 compile 10m 2s the patch passed
+1 💚 javac 10m 2s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 22m 51s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
_ Other Tests _
+1 💚 asflicense 0m 16s The patch does not generate ASF License warnings.
63m 32s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3141/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3141
Optional Tests dupname asflicense javac hadoopcheck xml compile
uname Linux bf5ef04da1b6 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 8e08952
Default Java AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count 126 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3141/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 22s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 5m 2s master passed
+1 💚 compile 3m 20s master passed
+1 💚 shadedjars 8m 41s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 13s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 47s the patch passed
+1 💚 compile 3m 15s the patch passed
+1 💚 javac 3m 15s the patch passed
+1 💚 shadedjars 8m 37s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 9s the patch passed
_ Other Tests _
+1 💚 unit 254m 43s root in the patch passed.
298m 20s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3141/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3141
Optional Tests javac javadoc unit shadedjars compile
uname Linux 815166f2cc82 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 8e08952
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3141/1/testReport/
Max. process+thread count 4520 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3141/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 50s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 43s master passed
+1 💚 compile 3m 0s master passed
+1 💚 shadedjars 9m 25s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 18s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 52s the patch passed
+1 💚 compile 3m 4s the patch passed
+1 💚 javac 3m 4s the patch passed
+1 💚 shadedjars 10m 26s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 49s the patch passed
_ Other Tests _
-1 ❌ unit 345m 32s root in the patch failed.
388m 42s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3141/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3141
Optional Tests javac javadoc unit shadedjars compile
uname Linux cf958e3d314e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 8e08952
Default Java AdoptOpenJDK-1.8.0_282-b08
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3141/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3141/1/testReport/
Max. process+thread count 5705 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3141/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@petersomogyi
Copy link
Contributor Author

The failed tests are in hbase-backup module which are unrelated. The tests in hbase-thrift passed.

@petersomogyi petersomogyi merged commit 7549410 into apache:master Apr 10, 2021
@petersomogyi petersomogyi deleted the HBASE-25755 branch April 10, 2021 07:21
petersomogyi added a commit that referenced this pull request Apr 10, 2021
Exclude tomcat-embed-core transitive dependency
Remove outdated exclude rule for slf4j

Signed-off-by: Pankaj <pankajkumar@apache.org>
Signed-off-by: Kevin Risden <krisden@apache.org>
petersomogyi added a commit that referenced this pull request Apr 10, 2021
Exclude tomcat-embed-core transitive dependency
Remove outdated exclude rule for slf4j

Signed-off-by: Pankaj <pankajkumar@apache.org>
Signed-off-by: Kevin Risden <krisden@apache.org>
petersomogyi added a commit that referenced this pull request Apr 10, 2021
Exclude tomcat-embed-core transitive dependency
Remove outdated exclude rule for slf4j

Signed-off-by: Pankaj <pankajkumar@apache.org>
Signed-off-by: Kevin Risden <krisden@apache.org>
petersomogyi added a commit that referenced this pull request Apr 10, 2021
Exclude tomcat-embed-core transitive dependency
Remove outdated exclude rule for slf4j

Signed-off-by: Pankaj <pankajkumar@apache.org>
Signed-off-by: Kevin Risden <krisden@apache.org>
wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request May 24, 2021
Exclude tomcat-embed-core transitive dependency
Remove outdated exclude rule for slf4j

Signed-off-by: Pankaj <pankajkumar@apache.org>
Signed-off-by: Kevin Risden <krisden@apache.org>
(cherry picked from commit 4e9d5d9)
Change-Id: Ic42967a0717c58066938e58c613ad9b4e1fa6fe7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants