Skip to content

Conversation

@Reidddddd
Copy link
Contributor

CompactionChecker and PeriodicMemStoreFlusher

HConstants.DEFAULT_HBASE_CLIENT_RETRIES_NUMBER);
this.threadWakeFrequency = conf.getInt(HConstants.THREAD_WAKE_FREQUENCY, 10 * 1000);
this.compactionCheckFrequency = conf.getInt(PERIOD_COMPACTION, this.threadWakeFrequency);
this.flushCheckFrequency = conf.getInt(PERIOD_FLUSH, this.threadWakeFrequency);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For keeping the old behavior, if both new paras are unset, then just use threadWakeFrequency as their default value.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 27 Docker mode activated.
_ Prechecks _
0 findbugs 0 Findbugs executables are not available.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
+1 mvninstall 142 branch-1 passed
+1 compile 38 branch-1 passed with JDK v1.8.0_212
+1 compile 41 branch-1 passed with JDK v1.7.0_222
+1 checkstyle 76 branch-1 passed
+1 shadedjars 159 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 31 branch-1 passed with JDK v1.8.0_212
+1 javadoc 37 branch-1 passed with JDK v1.7.0_222
_ Patch Compile Tests _
+1 mvninstall 110 the patch passed
+1 compile 42 the patch passed with JDK v1.8.0_212
+1 javac 42 the patch passed
+1 compile 42 the patch passed with JDK v1.7.0_222
+1 javac 42 the patch passed
+1 checkstyle 79 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 174 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 213 Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 javadoc 30 the patch passed with JDK v1.8.0_212
+1 javadoc 41 the patch passed with JDK v1.7.0_222
_ Other Tests _
+1 unit 6727 hbase-server in the patch passed.
+1 asflicense 22 The patch does not generate ASF License warnings.
8213
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-319/1/artifact/out/Dockerfile
GITHUB PR #319
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux fab9af106cc5 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision branch-1 / 9472d6e
maven version: Apache Maven 3.0.5
Default Java 1.7.0_222
Multi-JDK versions /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_212 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_222
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-319/1/testReport/
Max. process+thread count 4817 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-319/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Reidddddd Reidddddd requested a review from apurtell June 18, 2019 03:06
@Reidddddd
Copy link
Contributor Author

Approved in HBASE-22596

@Reidddddd Reidddddd merged commit be9f0dd into apache:branch-1 Jun 20, 2019
@Reidddddd Reidddddd deleted the HBASE-22596 branch June 20, 2019 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants