Skip to content

HBASE-25846 Backport 'HBASE-25825 RSGroupBasedLoadBalancer.onConfigurationChange should chain the request to internal balancer' to branch-1#3231

Merged
Reidddddd merged 1 commit into
apache:branch-1from
caroliney14:HBASE-25846
May 5, 2021

Conversation

@caroliney14
Copy link
Copy Markdown
Contributor

No description provided.

…ationChange should chain the request to internal balancer' to branch-1
@caroliney14
Copy link
Copy Markdown
Contributor Author

@Apache9 @d-c-manning please review when you get the chance, thanks:)

@Apache-HBase
Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 13m 5s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
-1 ❌ mvninstall 10m 14s root in branch-1 failed.
+1 💚 compile 0m 17s branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 compile 0m 22s branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 checkstyle 0m 26s branch-1 passed
+1 💚 shadedjars 3m 24s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 31s branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javadoc 0m 20s branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗 spotbugs 1m 11s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 1m 8s branch-1 passed
_ Patch Compile Tests _
-1 ❌ mvninstall 2m 2s root in the patch failed.
+1 💚 compile 0m 19s the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javac 0m 19s the patch passed
+1 💚 compile 0m 23s the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 javac 0m 23s the patch passed
+1 💚 checkstyle 0m 17s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 3m 10s patch has no errors when building our shaded downstream artifacts.
-1 ❌ hadoopcheck 1m 42s The patch causes 10 errors with Hadoop v2.8.5.
-1 ❌ hadoopcheck 4m 0s The patch causes 10 errors with Hadoop v2.9.2.
+1 💚 javadoc 0m 14s the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javadoc 0m 19s the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 findbugs 0m 59s the patch passed
_ Other Tests _
+1 💚 unit 16m 57s hbase-rsgroup in the patch passed.
+1 💚 asflicense 0m 21s The patch does not generate ASF License warnings.
60m 29s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3231/1/artifact/out/Dockerfile
GITHUB PR #3231
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux cf30adb79c49 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3231/out/precommit/personality/provided.sh
git revision branch-1 / 633d966
Default Java Azul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
mvninstall https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3231/1/artifact/out/branch-mvninstall-root.txt
mvninstall https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3231/1/artifact/out/patch-mvninstall-root.txt
hadoopcheck https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3231/1/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3231/1/artifact/out/patch-javac-2.9.2.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3231/1/testReport/
Max. process+thread count 1586 (vs. ulimit of 10000)
modules C: hbase-rsgroup U: hbase-rsgroup
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3231/1/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Reidddddd
Copy link
Copy Markdown
Contributor

Could ignore the check failure. I'm still working on it.

Copy link
Copy Markdown
Contributor

@Reidddddd Reidddddd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@caroliney14
Copy link
Copy Markdown
Contributor Author

thanks @Reidddddd. can either you or @Apache9 merge this?

@Reidddddd Reidddddd merged commit 852b1b0 into apache:branch-1 May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants