HBASE-26004: port HBASE-26001 (cell level tags invisible in atomic operations when access control is on)to branch-1 by YutSean · Pull Request #3387 · apache/hbase

YutSean · 2021-06-15T06:06:55Z

https://issues.apache.org/jira/browse/HBASE-26004

Apache-HBase · 2021-06-15T09:46:57Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	11m 38s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-1 Compile Tests _
+1 💚	mvninstall	9m 48s	branch-1 passed
+1 💚	compile	0m 41s	branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚	compile	0m 47s	branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚	checkstyle	1m 56s	branch-1 passed
+1 💚	shadedjars	3m 21s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 49s	branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚	javadoc	0m 43s	branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗	spotbugs	3m 15s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 13s	branch-1 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 1s	the patch passed
+1 💚	compile	0m 41s	the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚	javac	0m 41s	the patch passed
+1 💚	compile	0m 46s	the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚	javac	0m 46s	the patch passed
+1 💚	checkstyle	1m 45s	hbase-server: The patch generated 0 new + 25 unchanged - 1 fixed = 25 total (was 26)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	3m 7s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	4m 55s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚	javadoc	0m 31s	the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚	javadoc	0m 44s	the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
-1 ❌	findbugs	3m 10s	hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
-1 ❌	unit	164m 14s	hbase-server in the patch failed.
+1 💚	asflicense	0m 31s	The patch does not generate ASF License warnings.
		219m 14s

Reason	Tests
FindBugs	module:hbase-server
	Dead store to perms in org.apache.hadoop.hbase.security.access.AccessController.postMutationBeforeWAL(ObserverContext, RegionObserver$MutationType, Mutation, Cell, Cell) At AccessController.java:org.apache.hadoop.hbase.security.access.AccessController.postMutationBeforeWAL(ObserverContext, RegionObserver$MutationType, Mutation, Cell, Cell) At AccessController.java:[line 1958]
Failed junit tests	hadoop.hbase.procedure.TestFailedProcCleanup
	hadoop.hbase.mapreduce.TestLoadIncrementalHFiles
	hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint
	hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3387/1/artifact/out/Dockerfile
GITHUB PR	#3387
JIRA Issue	HBASE-26004
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux ab2c2f90f02b 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3387/out/precommit/personality/provided.sh
git revision	branch-1 / `a40f458`
Default Java	Azul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions	/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
findbugs	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3387/1/artifact/out/new-findbugs-hbase-server.html
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3387/1/artifact/out/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3387/1/testReport/
Max. process+thread count	4238 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3387/1/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-06-18T11:50:22Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	11m 57s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ branch-1 Compile Tests _
+1 💚	mvninstall	10m 0s	branch-1 passed
+1 💚	compile	0m 40s	branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚	compile	0m 46s	branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚	checkstyle	1m 52s	branch-1 passed
+1 💚	shadedjars	3m 17s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 48s	branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚	javadoc	0m 43s	branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗	spotbugs	3m 15s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 11s	branch-1 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 2s	the patch passed
+1 💚	compile	0m 41s	the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚	javac	0m 41s	the patch passed
+1 💚	compile	0m 46s	the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚	javac	0m 46s	the patch passed
-1 ❌	checkstyle	1m 42s	hbase-server: The patch generated 1 new + 25 unchanged - 1 fixed = 26 total (was 26)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	3m 8s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	4m 51s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚	javadoc	0m 31s	the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚	javadoc	0m 43s	the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
-1 ❌	findbugs	3m 10s	hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
-1 ❌	unit	169m 36s	hbase-server in the patch failed.
+1 💚	asflicense	0m 33s	The patch does not generate ASF License warnings.
		224m 31s

Reason	Tests
FindBugs	module:hbase-server
	Dead store to perms in org.apache.hadoop.hbase.security.access.AccessController.postMutationBeforeWAL(ObserverContext, RegionObserver$MutationType, Mutation, Cell, Cell) At AccessController.java:org.apache.hadoop.hbase.security.access.AccessController.postMutationBeforeWAL(ObserverContext, RegionObserver$MutationType, Mutation, Cell, Cell) At AccessController.java:[line 1958]
Failed junit tests	hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint
	hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles
	hadoop.hbase.master.TestMasterBalanceThrottling

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3387/2/artifact/out/Dockerfile
GITHUB PR	#3387
JIRA Issue	HBASE-26004
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 02d754105373 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3387/out/precommit/personality/provided.sh
git revision	branch-1 / `a40f458`
Default Java	Azul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions	/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3387/2/artifact/out/diff-checkstyle-hbase-server.txt
findbugs	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3387/2/artifact/out/new-findbugs-hbase-server.html
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3387/2/artifact/out/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3387/2/testReport/
Max. process+thread count	4338 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3387/2/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Reidddddd · 2021-06-18T12:00:38Z

Please fix the findbugs and checkstyle warnings @YutSean, thx

Apache-HBase · 2021-06-18T15:50:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 12s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ branch-1 Compile Tests _
+1 💚	mvninstall	10m 5s	branch-1 passed
+1 💚	compile	0m 42s	branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚	compile	0m 47s	branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚	checkstyle	1m 54s	branch-1 passed
+1 💚	shadedjars	3m 25s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 53s	branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚	javadoc	0m 44s	branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗	spotbugs	3m 15s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 13s	branch-1 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 2s	the patch passed
+1 💚	compile	0m 44s	the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚	javac	0m 44s	the patch passed
+1 💚	compile	0m 51s	the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚	javac	0m 51s	the patch passed
-1 ❌	checkstyle	1m 44s	hbase-server: The patch generated 1 new + 24 unchanged - 2 fixed = 25 total (was 26)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	3m 13s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	4m 46s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚	javadoc	0m 38s	the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚	javadoc	0m 44s	the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚	findbugs	3m 7s	the patch passed
		_ Other Tests _
-1 ❌	unit	194m 50s	hbase-server in the patch failed.
+1 💚	asflicense	0m 37s	The patch does not generate ASF License warnings.
		239m 44s

Reason	Tests
Failed junit tests	hadoop.hbase.mapreduce.TestLoadIncrementalHFiles
	hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint
	hadoop.hbase.master.cleaner.TestSnapshotFromMaster
	hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles
	hadoop.hbase.master.TestMasterBalanceThrottling

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3387/3/artifact/out/Dockerfile
GITHUB PR	#3387
JIRA Issue	HBASE-26004
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux cdf32775f1a7 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3387/out/precommit/personality/provided.sh
git revision	branch-1 / `a40f458`
Default Java	Azul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions	/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3387/3/artifact/out/diff-checkstyle-hbase-server.txt
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3387/3/artifact/out/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3387/3/testReport/
Max. process+thread count	4374 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3387/3/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Reidddddd · 2021-06-21T02:56:28Z

@YutSean checksytle still has warnings sir

YutSean · 2021-06-21T04:40:59Z

This looks strange. I just removed a useless import but did not change the order.

Reidddddd · 2021-06-21T04:45:30Z

This looks strange. I just removed a useless import but did not change the order.

OK, It means the original order is wrong. Let it be then

Reidddddd

+1

HBASE-26004: port HBASE-26001 to branch-1

3ae0100

YutSean added 3 commits June 18, 2021 16:04

Add unit test for HBASE-26004

bd43468

Remove useless import

0d814ed

Fix a code style problem

f746b28

Reidddddd approved these changes Jun 21, 2021

View reviewed changes

Reidddddd merged commit 5263b8c into apache:branch-1 Jun 21, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-26004: port HBASE-26001 (cell level tags invisible in atomic operations when access control is on)to branch-1#3387

HBASE-26004: port HBASE-26001 (cell level tags invisible in atomic operations when access control is on)to branch-1#3387
Reidddddd merged 4 commits intoapache:branch-1from
YutSean:HBASE-26004

YutSean commented Jun 15, 2021

Uh oh!

Apache-HBase commented Jun 15, 2021

Uh oh!

Apache-HBase commented Jun 18, 2021

Uh oh!

Reidddddd commented Jun 18, 2021

Uh oh!

Apache-HBase commented Jun 18, 2021

Uh oh!

Reidddddd commented Jun 21, 2021

Uh oh!

YutSean commented Jun 21, 2021

Uh oh!

Reidddddd commented Jun 21, 2021

Uh oh!

Reidddddd left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

YutSean commented Jun 15, 2021

Uh oh!

Apache-HBase commented Jun 15, 2021

Uh oh!

Apache-HBase commented Jun 18, 2021

Uh oh!

Reidddddd commented Jun 18, 2021

Uh oh!

Apache-HBase commented Jun 18, 2021

Uh oh!

Reidddddd commented Jun 21, 2021

Uh oh!

YutSean commented Jun 21, 2021

Uh oh!

Reidddddd commented Jun 21, 2021

Uh oh!

Reidddddd left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants