HBASE-26009 Backport HBASE-25766 "Introduce RegionSplitRestriction that restricts the pattern of the split point" to branch-2.3 #3395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at restricts the pattern of the split point" to branch-2.3
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
|
This is a new feature? Is it suitable to be backported to 2.3? |
Member
Author
|
This may be a new feature but it doesn't break any compatibilities. So I thought we could put it into the next 2.3.x release. What do you guys think? Thanks. |
Member
|
I personally think this cannot be applied to any patch release. It introduces a new table configuration, which may cause problems during a rollback. What are the "Server-Server" compatibility implications of this change being applied to any patch release? |
ndimiduk
requested changes
Jun 22, 2021
Member
ndimiduk
left a comment
ndimiduk
left a comment
There was a problem hiding this comment.
I request two small javadoc changes if this does go back to a 2.3.x.
| * ensures that all rows starting with the same userid, belongs to the same region. | ||
| * @see KeyPrefixRegionSplitPolicy | ||
| * | ||
| * @deprecated since 2.4.3 and will be removed in 4.0.0. Use {@link RegionSplitRestriction}, |
Member
There was a problem hiding this comment.
You need to update this deprecation string to also include the applicable 2.3.x version number.
| * This ensures that a region is not split "inside" a prefix of a row key. | ||
| * I.e. rows can be co-located in a region by their prefix. | ||
| * | ||
| * @deprecated since 2.4.3 and will be removed in 4.0.0. Use {@link RegionSplitRestriction}, |
Member
There was a problem hiding this comment.
You need to update this deprecation string to also include the applicable 2.3.x version number.
Member
Author
|
@ndimiduk Thank you for taking a look at this!
I don't think it breaks the "Server-Server" compatibility, and we can perform a rolling upgrade to the version that has this fix. But yes, it's not a bug fix, but introducing a new table configuration, so we shouldn't apply it to patch releases. So I will close this PR. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.