Skip to content

Conversation

@maoling
Copy link
Member

@maoling maoling commented Jul 17, 2019

Detect regionserver failure as fast as reasonable. Set the following parameters:
* In `hbase-site.xml`, set `zookeeper.session.timeout` to 30 seconds or less to bound failure detection (20-30 seconds is a good start).
- Notice: the `sessionTimeout` of zookeeper is limited between 2 times and 20 times the `tickTime`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an explanation for 'tickTime'?

@infraio
Copy link
Contributor

infraio commented Jul 17, 2019

+1. Will merge this after HBase QA.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 32 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
0 mvndep 25 Maven dependency ordering for branch
+1 mvninstall 225 master passed
0 refguide 431 branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 javadoc 189 master passed
_ Patch Compile Tests _
0 mvndep 13 Maven dependency ordering for patch
+1 mvninstall 227 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 1 The patch has no ill-formed XML file.
0 refguide 431 patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 javadoc 172 the patch passed
_ Other Tests _
+1 unit 12627 root in the patch passed.
+1 asflicense 73 The patch does not generate ASF License warnings.
14528
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-388/1/artifact/out/Dockerfile
GITHUB PR #388
JIRA Issue HBASE-22700
Optional Tests dupname asflicense javac javadoc unit refguide xml
uname Linux 3ba5d395780c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 72e58a8
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-388/1/artifact/out/branch-site/book.html
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-388/1/artifact/out/patch-site/book.html
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-388/1/testReport/
Max. process+thread count 5602 (vs. ulimit of 10000)
modules C: hbase-common . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-388/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@infraio infraio merged commit 54b514d into apache:master Jul 17, 2019
@maoling maoling deleted the HBASE-22700 branch July 18, 2019 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants