Skip to content

HBASE-22742 [HBCK2] Add more log for hbck operations at master side #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
infraio merged 1 commit into from
Jul 27, 2019
Merged

HBASE-22742 [HBCK2] Add more log for hbck operations at master side #412

infraio merged 1 commit into from
Jul 27, 2019

Conversation

@infraio
Copy link
Contributor

@infraio infraio commented Jul 26, 2019

No description provided.

@Apache-HBase
Copy link

Apache-HBase commented Jul 26, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 66 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 397 master passed
+1 compile 72 master passed
+1 checkstyle 93 master passed
+1 shadedjars 357 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 44 master passed
0 spotbugs 314 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 311 master passed
_ Patch Compile Tests _
+1 mvninstall 376 the patch passed
+1 compile 69 the patch passed
+1 javac 69 the patch passed
+1 checkstyle 92 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 356 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1137 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 44 the patch passed
+1 findbugs 322 the patch passed
_ Other Tests _
-1 unit 16576 hbase-server in the patch failed.
+1 asflicense 29 The patch does not generate ASF License warnings.
20807
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-412/1/artifact/out/Dockerfile
GITHUB PR #412
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux e4600925b8cd 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-412/out/precommit/personality/provided.sh
git revision master / 747d000
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-412/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-412/1/testReport/
Max. process+thread count 4857 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-412/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

saintstack
saintstack approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit noted below but good stuff.

hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java Outdated
MasterProtos.AssignsResponse.newBuilder();
try {
boolean override = request.getOverride();
LOG.info("HbckService: {} assigns, override={}", master.getClientIdAuditPrefix(), override);
Copy link
Contributor

@saintstack saintstack Jul 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need the 'HbckService' prefix? Only it can call the assigns method, no?

Copy link
Contributor Author

@infraio infraio Jul 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "HbckService" to keep same with others log style.

hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java Outdated
MasterProtos.UnassignsResponse.newBuilder();
try {
boolean override = request.getOverride();
LOG.info("HbckService: {} unassigns, override={}", master.getClientIdAuditPrefix(), override);
Copy link
Contributor

@saintstack saintstack Jul 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@Apache-HBase
Copy link

Apache-HBase commented Jul 27, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 73 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 442 master passed
+1 compile 71 master passed
+1 checkstyle 95 master passed
+1 shadedjars 350 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 47 master passed
0 spotbugs 317 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 314 master passed
_ Patch Compile Tests _
+1 mvninstall 373 the patch passed
+1 compile 69 the patch passed
+1 javac 69 the patch passed
+1 checkstyle 95 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 365 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1195 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 43 the patch passed
+1 findbugs 306 the patch passed
_ Other Tests _
-1 unit 17093 hbase-server in the patch failed.
+1 asflicense 30 The patch does not generate ASF License warnings.
21415
Reason Tests
Failed junit tests hadoop.hbase.master.TestMasterShutdown
hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
hadoop.hbase.tool.TestSecureBulkLoadHFiles
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-412/2/artifact/out/Dockerfile
GITHUB PR #412
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux fb7b87a347a4 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-412/out/precommit/personality/provided.sh
git revision master / fa77c75
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-412/2/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-412/2/testReport/
Max. process+thread count 5185 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-412/2/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@infraio infraio merged commit 1cb37f1 into apache:master Jul 27, 2019
@infraio infraio deleted the HBASE-22742 branch July 27, 2019 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saintstack saintstack saintstack approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@infraio @Apache-HBase @saintstack