Skip to content

HBASE-26906 Remove duplicate dependency declaration (branch-2)#4300

Merged
ndimiduk merged 1 commit intoapache:branch-2from
ndimiduk:26906-remove-duplicate-dependency-branch-2
Apr 19, 2022
Merged

HBASE-26906 Remove duplicate dependency declaration (branch-2)#4300
ndimiduk merged 1 commit intoapache:branch-2from
ndimiduk:26906-remove-duplicate-dependency-branch-2

Conversation

@ndimiduk
Copy link
Member

I chose to keep the declaration that has more exclusions. That decision was arbitrary. The difference was javax.servlet:servlet-api.

@ndimiduk ndimiduk requested review from Apache9, apurtell and busbey March 30, 2022 11:53
@ndimiduk ndimiduk changed the title HBASE-26906 Remove duplicate dependency declaration HBASE-26906 Remove duplicate dependency declaration (branch-2) Mar 30, 2022
@Apache9
Copy link
Contributor

Apache9 commented Mar 30, 2022

This is only for branch-2.x? Master is ok?

@Apache-HBase

This comment was marked as outdated.

@Apache-HBase

This comment was marked as outdated.

@ndimiduk
Copy link
Member Author

This is only for branch-2.x? Master is ok?

Correct.

@Apache-HBase

This comment was marked as outdated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 52s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚 mvninstall 2m 24s branch-2 passed
+1 💚 compile 6m 10s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 6s the patch passed
+1 💚 compile 6m 2s the patch passed
+1 💚 javac 6m 2s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 8m 5s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
_ Other Tests _
+1 💚 asflicense 0m 15s The patch does not generate ASF License warnings.
30m 48s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4300/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4300
Optional Tests dupname asflicense javac hadoopcheck xml compile
uname Linux 4a7a21bd0a39 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 1a85588
Default Java AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count 140 (vs. ulimit of 12500)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4300/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
Copy link
Member Author

Repeating my comment from JIRA.

Hmm. This affects branch-2 and branch-2.5 only. Looking at the blame on 2.5, I don't see a strong reason for one version or the other. It looks like the dependency was introduced via HBASE-26691 and includes the extra exclusion. The second declaration came without the exclusion via HBASE-26802. Before these changes, there was no explicit mention of this dependency.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 12s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 2m 36s branch-2 passed
+1 💚 compile 1m 49s branch-2 passed
+1 💚 shadedjars 3m 50s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 57s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 32s the patch passed
+1 💚 compile 1m 49s the patch passed
+1 💚 javac 1m 49s the patch passed
+1 💚 shadedjars 3m 52s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 54s the patch passed
_ Other Tests _
+1 💚 unit 231m 25s root in the patch passed.
255m 24s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4300/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4300
Optional Tests javac javadoc unit shadedjars compile
uname Linux 0a0f90cce89d 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 1a85588
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4300/2/testReport/
Max. process+thread count 5502 (vs. ulimit of 12500)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4300/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 36s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 2m 49s branch-2 passed
+1 💚 compile 1m 50s branch-2 passed
+1 💚 shadedjars 4m 18s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 47s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 34s the patch passed
+1 💚 compile 1m 55s the patch passed
+1 💚 javac 1m 55s the patch passed
+1 💚 shadedjars 4m 19s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 42s the patch passed
_ Other Tests _
+1 💚 unit 343m 16s root in the patch passed.
368m 16s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4300/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #4300
Optional Tests javac javadoc unit shadedjars compile
uname Linux b561a5b3c156 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 1a85588
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4300/2/testReport/
Max. process+thread count 4605 (vs. ulimit of 12500)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4300/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Signed-off-by: Andrew Purtell <apurtell@apache.org>
@ndimiduk ndimiduk force-pushed the 26906-remove-duplicate-dependency-branch-2 branch from 034fea9 to 8becb52 Compare April 19, 2022 14:04
@ndimiduk ndimiduk merged commit a81b369 into apache:branch-2 Apr 19, 2022
@ndimiduk ndimiduk deleted the 26906-remove-duplicate-dependency-branch-2 branch April 19, 2022 14:05
@ndimiduk
Copy link
Member Author

Thanks for the review @apurtell .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments