Skip to content

HBASE-27532 Add block bytes scanned metrics#5146

Merged
bbeaudreault merged 1 commit intoapache:branch-2from
HubSpot:HBASE-27532-2
Mar 28, 2023
Merged

HBASE-27532 Add block bytes scanned metrics#5146
bbeaudreault merged 1 commit intoapache:branch-2from
HubSpot:HBASE-27532-2

Conversation

@bbeaudreault
Copy link
Contributor

No description provided.

Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
@bbeaudreault bbeaudreault added the backport This PR is a back port of some issue or issues already committed to master label Mar 27, 2023
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 31s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 5m 42s branch-2 passed
+1 💚 compile 4m 50s branch-2 passed
+1 💚 checkstyle 1m 9s branch-2 passed
+1 💚 spotless 0m 50s branch has no errors when running spotless:check.
+1 💚 spotbugs 3m 52s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 20s Maven dependency ordering for patch
+1 💚 mvninstall 4m 58s the patch passed
+1 💚 compile 4m 29s the patch passed
+1 💚 javac 4m 29s the patch passed
+1 💚 checkstyle 0m 7s The patch passed checkstyle in hbase-hadoop-compat
+1 💚 checkstyle 0m 7s The patch passed checkstyle in hbase-hadoop2-compat
+1 💚 checkstyle 0m 19s hbase-client: The patch generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
+1 💚 checkstyle 0m 35s The patch passed checkstyle in hbase-server
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 26m 24s Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.
+1 💚 spotless 1m 3s patch has no errors when running spotless:check.
-1 ❌ spotbugs 0m 49s hbase-hadoop2-compat generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
_ Other Tests _
+1 💚 asflicense 0m 43s The patch does not generate ASF License warnings.
66m 3s
Reason Tests
FindBugs module:hbase-hadoop2-compat
Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.appendHisto; locked 50% of time Unsynchronized access at MetricsUserSourceImpl.java:50% of time Unsynchronized access at MetricsUserSourceImpl.java:[line 253]
Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.getHisto; locked 50% of time Unsynchronized access at MetricsUserSourceImpl.java:50% of time Unsynchronized access at MetricsUserSourceImpl.java:[line 241]
Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.incrementHisto; locked 50% of time Unsynchronized access at MetricsUserSourceImpl.java:50% of time Unsynchronized access at MetricsUserSourceImpl.java:[line 247]
Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.scanTimeHisto; locked 50% of time Unsynchronized access at MetricsUserSourceImpl.java:50% of time Unsynchronized access at MetricsUserSourceImpl.java:[line 264]
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5146/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5146
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux a45e8d58d6e4 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 61e18a3
Default Java Eclipse Adoptium-11.0.17+8
spotbugs https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5146/1/artifact/yetus-general-check/output/new-spotbugs-hbase-hadoop2-compat.html
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: hbase-hadoop-compat hbase-hadoop2-compat hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5146/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 3s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 2m 51s branch-2 passed
+1 💚 compile 1m 23s branch-2 passed
+1 💚 shadedjars 4m 9s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 3s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 2m 41s the patch passed
+1 💚 compile 1m 24s the patch passed
+1 💚 javac 1m 24s the patch passed
+1 💚 shadedjars 4m 12s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 59s the patch passed
_ Other Tests _
+1 💚 unit 0m 27s hbase-hadoop-compat in the patch passed.
+1 💚 unit 0m 21s hbase-hadoop2-compat in the patch passed.
+1 💚 unit 7m 47s hbase-client in the patch passed.
+1 💚 unit 212m 30s hbase-server in the patch passed.
246m 27s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5146/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #5146
Optional Tests javac javadoc unit shadedjars compile
uname Linux c19bbdc436da 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 61e18a3
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5146/1/testReport/
Max. process+thread count 2229 (vs. ulimit of 30000)
modules C: hbase-hadoop-compat hbase-hadoop2-compat hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5146/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 30s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 5m 42s branch-2 passed
+1 💚 compile 2m 4s branch-2 passed
+1 💚 shadedjars 5m 38s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 27s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 5m 13s the patch passed
+1 💚 compile 2m 14s the patch passed
+1 💚 javac 2m 14s the patch passed
+1 💚 shadedjars 5m 43s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 22s the patch passed
_ Other Tests _
+1 💚 unit 0m 33s hbase-hadoop-compat in the patch passed.
+1 💚 unit 0m 29s hbase-hadoop2-compat in the patch passed.
+1 💚 unit 8m 14s hbase-client in the patch passed.
+1 💚 unit 220m 25s hbase-server in the patch passed.
266m 26s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5146/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5146
Optional Tests javac javadoc unit shadedjars compile
uname Linux 2439389019a0 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 61e18a3
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5146/1/testReport/
Max. process+thread count 2189 (vs. ulimit of 30000)
modules C: hbase-hadoop-compat hbase-hadoop2-compat hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5146/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreault
Copy link
Contributor Author

The failure here is the same spotbugs failure as in master, which will be addressed in HBASE-27758

@bbeaudreault bbeaudreault merged commit e33afb4 into apache:branch-2 Mar 28, 2023
@bbeaudreault bbeaudreault deleted the HBASE-27532-2 branch March 28, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a back port of some issue or issues already committed to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants