HBASE-28091 Too long namespace/table/column name cause CreateTableProcedure stuck#5410
Open
guluo2016 wants to merge 6 commits intoapache:masterfrom
Open
HBASE-28091 Too long namespace/table/column name cause CreateTableProcedure stuck#5410guluo2016 wants to merge 6 commits intoapache:masterfrom
guluo2016 wants to merge 6 commits intoapache:masterfrom
Conversation
…mn family name or namespace name exceeds the specified value
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
reviewed
Sep 18, 2023
| return false; | ||
| } | ||
|
|
||
| int dfsMaxComponentLength = |
Contributor
There was a problem hiding this comment.
Is this check in DFSClient or in NameNode? If it is in NameNode, we can not make sure that we have the same configuration value with NameNode?
Member
Author
There was a problem hiding this comment.
sorry about that，i was thinking too simplistic，i will rewrite this code
Contributor
|
I prefer we catch the exception and check whether this is a file name length limit and then fail the procedure with DoNotRetryIOException. Of course there may be a problem that when we try to create the file on namenode, we have already passed the SPOF so the procedure can not fail, if this is the case, I think we need to do some refactoring... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details see: HBASE-28091