HBASE-28567 Race condition causes MetaRegionLocationCache to never se… by vincentpoon · Pull Request #5874 · apache/hbase

vincentpoon · 2024-05-06T01:00:22Z

…t watcher to populate meta location

Apache9 · 2024-05-06T01:11:38Z

I think we should change the logic in MetaRegionLocationCache instead of in ZKWatcher?

vincentpoon · 2024-05-06T01:16:33Z

Sure but right now the problem is ZKWatcher#filterMetaReplicaNodes returns empty List if the input nodes is null. So MetaRegionLocationCache can't tell the difference between:

node exists but has no children
node does not exist

So seems like we might need to change ZKWatcher either way.

virajjasani · 2024-05-06T01:18:44Z

I agree, we will need to change ZKWatcher one way or another, and currently this is the only caller

Apache-HBase · 2024-05-06T01:24:42Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 45s	master passed
+1 💚	compile	0m 12s	master passed
+1 💚	shadedjars	5m 38s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 24s	the patch passed
+1 💚	compile	0m 12s	the patch passed
+1 💚	javac	0m 12s	the patch passed
+1 💚	shadedjars	5m 38s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 9s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 35s	hbase-zookeeper in the patch passed.
		19m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5874/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5874
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e6596c092f1d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3d66866`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5874/1/testReport/
Max. process+thread count	246 (vs. ulimit of 30000)
modules	C: hbase-zookeeper U: hbase-zookeeper
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5874/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-05-06T01:25:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 59s	master passed
+1 💚	compile	0m 14s	master passed
+1 💚	shadedjars	5m 14s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 49s	the patch passed
+1 💚	compile	0m 15s	the patch passed
+1 💚	javac	0m 15s	the patch passed
+1 💚	shadedjars	5m 19s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 44s	hbase-zookeeper in the patch passed.
		19m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5874/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5874
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4a93e621e4b8 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3d66866`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5874/1/testReport/
Max. process+thread count	304 (vs. ulimit of 30000)
modules	C: hbase-zookeeper U: hbase-zookeeper
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5874/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-05-06T01:26:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 18s	master passed
+1 💚	compile	0m 13s	master passed
+1 💚	shadedjars	5m 48s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 0s	the patch passed
+1 💚	compile	0m 12s	the patch passed
+1 💚	javac	0m 12s	the patch passed
+1 💚	shadedjars	5m 49s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 38s	hbase-zookeeper in the patch passed.
		20m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5874/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#5874
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a1990c1317b8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3d66866`
Default Java	Eclipse Adoptium-17.0.10+7
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5874/1/testReport/
Max. process+thread count	271 (vs. ulimit of 30000)
modules	C: hbase-zookeeper U: hbase-zookeeper
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5874/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-05-06T01:26:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 6s	master passed
+1 💚	compile	0m 19s	master passed
+1 💚	checkstyle	0m 9s	master passed
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 24s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 40s	the patch passed
+1 💚	compile	0m 16s	the patch passed
+1 💚	javac	0m 16s	the patch passed
+1 💚	checkstyle	0m 7s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	5m 6s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 39s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 27s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		20m 59s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5874/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5874
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux f804a067c6a9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3d66866`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	77 (vs. ulimit of 30000)
modules	C: hbase-zookeeper U: hbase-zookeeper
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5874/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2024-05-06T01:31:32Z

Sure but right now the problem is ZKWatcher#filterMetaReplicaNodes returns empty List if the input nodes is null. So MetaRegionLocationCache can't tell the difference between:

node exists but has no children

node does not exist

So seems like we might need to change ZKWatcher either way.

It is just a bit strange that in ZKUtil we eat the NoNodeException while at the upper layer we create a new NoNodeException and throw it...

Better just return null in ZKWatcher, and in MetaRegionLocationCache, we do not break the loop if the return value is null.

WDYT?

Thanks.

virajjasani · 2024-05-06T01:34:36Z

Better just return null in ZKWatcher, and in MetaRegionLocationCache, we do not break the loop if the return value is null.

We need to retry in the case of race condition, that's the main difference from filterMetaReplicaNodes() returning null.
So even if we do not break the loop in MetaRegionLocationCache, we will not retry for genuine race condition case.

virajjasani · 2024-05-06T01:41:46Z

Oh, I see you are talking about breaking this loop:

        try {
          znodes = watcher.getMetaReplicaNodesAndWatchChildren();
          break;
        } catch (KeeperException ke) {
...
...

Yeah that might also work.

vincentpoon · 2024-05-06T01:49:55Z

It is just a bit strange that in ZKUtil we eat the NoNodeException while at the upper layer we create a new NoNodeException and throw it...

I think the original author of getMetaReplicaNodesAndWatchChildren never envisioned base znode not existing. If there were a ZKUtil method that didn't swallow the exception, we would use that instead. IMO getMetaReplicaNodesAndWatchChildren is doing something very specific and should in fact throw in that situation.

But happy to change ZKWatcher to return null and have MetaRegionLocationCache stay in the loop when null if folks are in agreement here that that's the best path forward. Note that this would mean that before /hbase/meta-region-server gets created, all Regionservers in cluster would be retrying listChildren calls against ZK, instead of waiting for watcher notifications.
Whereas with the original patch, all the behavior stays the same except under the race condition where base /hbase znode hasn't been created yet.

virajjasani · 2024-05-06T02:10:44Z

Btw just in case if we end up updating MetaRegionLocationCache#loadMetaLocationsFromZk, we might have to keep retryCounter.sleepUntilNextRetry() out of catching KeeperException.

virajjasani · 2024-05-06T02:23:19Z

I am in favor of keeping patch like this, so that we don't have to keep calling listChildren until /hbase/meta-region-server gets created. I know you have valid concern about not re-throwing NoNodeException but given that this is special case, I think we should be good, we can comment here for better explanation.
WDYT @Apache9?

Apache9 · 2024-05-06T02:32:06Z

I am in favor of keeping patch like this, so that we don't have to keep calling listChildren until /hbase/meta-region-server gets created. I know you have valid concern about not re-throwing NoNodeException but given that this is special case, I think we should be good, we can comment here for better explanation. WDYT @Apache9?

I need to figure out that what we have fixed here is that we should keep calling listChildren util /hbase/meta-region-server gets created, no matter you add a null check or use an exception...

hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java

vincentpoon · 2024-05-06T02:41:26Z

Let me attempt to summarize the cases:

/hbase/meta-region-server exists - node is returned all the way ZKUtil -> ZKWatcher -> MetaRegionLocationCache
/hbase exists but not meta-region-server child - empty list returned all the way to MetaRegionLocationCache, which proceeds without retry and waits for watcher notifications
/hbase does not exist. Currently returns null from ZKUtil, empty list from ZKWatcher, and MetaRegionLocationCache waits forever without watcher set. I am proposing throwing here so MetaRegionLocationCache retries for this case.

…t watcher to populate meta location

virajjasani

+1

Apache-HBase · 2024-05-06T03:09:18Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 25s	master passed
+1 💚	compile	0m 11s	master passed
+1 💚	shadedjars	5m 36s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 10s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 26s	the patch passed
+1 💚	compile	0m 11s	the patch passed
+1 💚	javac	0m 11s	the patch passed
+1 💚	shadedjars	5m 36s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 10s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 35s	hbase-zookeeper in the patch passed.
		18m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5874/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5874
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 436ada3f4319 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3d66866`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5874/2/testReport/
Max. process+thread count	273 (vs. ulimit of 30000)
modules	C: hbase-zookeeper U: hbase-zookeeper
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5874/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-05-06T03:09:51Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 44s	master passed
+1 💚	compile	0m 15s	master passed
+1 💚	shadedjars	5m 15s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 50s	the patch passed
+1 💚	compile	0m 15s	the patch passed
+1 💚	javac	0m 15s	the patch passed
+1 💚	shadedjars	5m 12s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 44s	hbase-zookeeper in the patch passed.
		19m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5874/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5874
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c31a1bbd493a 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3d66866`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5874/2/testReport/
Max. process+thread count	257 (vs. ulimit of 30000)
modules	C: hbase-zookeeper U: hbase-zookeeper
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5874/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-05-06T03:10:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 56s	master passed
+1 💚	compile	0m 13s	master passed
+1 💚	shadedjars	5m 45s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 10s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 0s	the patch passed
+1 💚	compile	0m 13s	the patch passed
+1 💚	javac	0m 13s	the patch passed
+1 💚	shadedjars	5m 44s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 10s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 39s	hbase-zookeeper in the patch passed.
		20m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5874/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#5874
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c80fc035db3f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3d66866`
Default Java	Eclipse Adoptium-17.0.10+7
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5874/2/testReport/
Max. process+thread count	251 (vs. ulimit of 30000)
modules	C: hbase-zookeeper U: hbase-zookeeper
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5874/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-05-06T03:10:58Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 44s	master passed
+1 💚	compile	0m 16s	master passed
+1 💚	checkstyle	0m 7s	master passed
+1 💚	spotless	0m 39s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 19s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 41s	the patch passed
+1 💚	compile	0m 17s	the patch passed
+1 💚	javac	0m 17s	the patch passed
+1 💚	checkstyle	0m 7s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	5m 5s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 27s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 7s	The patch does not generate ASF License warnings.
		20m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5874/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5874
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 85abf0fb7ab8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3d66866`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-zookeeper U: hbase-zookeeper
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5874/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…t watcher to populate meta location (#5874) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit ce113dd)

…t watcher to populate meta location (apache#5874) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>

vincentpoon mentioned this pull request May 6, 2024

Update to Phoenix 5.2.0 and HBase 2.5 trinodb/trino#21569

Merged

virajjasani self-requested a review May 6, 2024 01:13

Apache9 reviewed May 6, 2024

View reviewed changes

hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java Show resolved Hide resolved

HBASE-28567 Race condition causes MetaRegionLocationCache to never se…

8ba1a41

…t watcher to populate meta location

vincentpoon force-pushed the HBASE-28567 branch from 0db7622 to 8ba1a41 Compare May 6, 2024 02:47

Apache9 approved these changes May 6, 2024

View reviewed changes

virajjasani approved these changes May 6, 2024

View reviewed changes

Apache9 merged commit ce113dd into apache:master May 6, 2024

vincentpoon deleted the HBASE-28567 branch May 6, 2024 16:07

Conversation

vincentpoon commented May 6, 2024

Uh oh!

Apache9 commented May 6, 2024

Uh oh!

vincentpoon commented May 6, 2024

Uh oh!

virajjasani commented May 6, 2024

Uh oh!

Apache-HBase commented May 6, 2024

Uh oh!

Apache-HBase commented May 6, 2024

Uh oh!

Apache-HBase commented May 6, 2024

Uh oh!

Apache-HBase commented May 6, 2024

Uh oh!

Apache9 commented May 6, 2024

Uh oh!

virajjasani commented May 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

virajjasani commented May 6, 2024

Uh oh!

vincentpoon commented May 6, 2024

Uh oh!

virajjasani commented May 6, 2024

Uh oh!

virajjasani commented May 6, 2024

Uh oh!

Apache9 commented May 6, 2024

Uh oh!

Uh oh!

vincentpoon commented May 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented May 6, 2024

Uh oh!

Apache-HBase commented May 6, 2024

Uh oh!

Apache-HBase commented May 6, 2024

Uh oh!

Apache-HBase commented May 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

virajjasani commented May 6, 2024 •

edited

Loading

vincentpoon commented May 6, 2024 •

edited

Loading