Skip to content

HBASE-28604 Fix the error message in ReservoirSample's constructor #5920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Apache9 merged 1 commit into from
May 18, 2024
Merged

HBASE-28604 Fix the error message in ReservoirSample's constructor #5920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hbase-common/src/main/java/org/apache/hadoop/hbase/util/ReservoirSample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public class ReservoirSample<T> {
private int n;

public ReservoirSample(int k) {
Preconditions.checkArgument(k > 0, "negative sampling number(%d) is not allowed");
Preconditions.checkArgument(k > 0, "negative sampling number(%s) is not allowed", k);
r = new ArrayList<>(k);
this.k = k;
}
Expand Down
8 changes: 8 additions & 0 deletions hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestReservoirSample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
package org.apache.hadoop.hbase.util;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertThrows;
import static org.junit.Assert.assertTrue;

import java.util.stream.IntStream;
Expand Down Expand Up @@ -89,4 +90,11 @@ public void testStream() {
assertTrue(containsOne > round / 10 * 0.95);
assertTrue(containsOne < round / 10 * 1.05);
}

@Test
public void testNegativeSamplingNumber() {
IllegalArgumentException e =
assertThrows(IllegalArgumentException.class, () -> new ReservoirSample<Integer>(-1));
assertEquals("negative sampling number(-1) is not allowed", e.getMessage());
}
}