Backport "HBASE-29131 Introduce the option for post-compaction validation of HFiles (#6700)" to branch-2 by ndimiduk · Pull Request #6721 · apache/hbase

ndimiduk · 2025-02-25T14:21:24Z

No description provided.

…iles (apache#6700) Introduces the option for an HStore to fully read the file it just wrote after a flush or compaction. To enable this feature, set `hbase.hstore.validate.read_fully=true`. This is an HStore configuration feature, so it can be enabled in hbase-site.xml, in the TableDescriptor, or in the ColumnFamilyDescriptor. Signed-off-by: Peter Somogyi <psomogyi@apache.org >

Apache-HBase · 2025-03-18T00:31:47Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 53s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ branch-2 Compile Tests _
+1 💚	mvninstall	4m 44s		branch-2 passed
+1 💚	compile	4m 8s		branch-2 passed
+1 💚	checkstyle	1m 4s		branch-2 passed
+1 💚	spotbugs	2m 2s		branch-2 passed
+1 💚	spotless	0m 54s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 41s		the patch passed
+1 💚	compile	3m 49s		the patch passed
+1 💚	javac	3m 49s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 43s		the patch passed
+1 💚	spotbugs	2m 23s		the patch passed
+1 💚	hadoopcheck	22m 29s		Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
-1 ❌	spotless	1m 2s		patch has 1 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
+1 💚	asflicense	0m 12s		The patch does not generate ASF License warnings.
		49m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6721/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6721
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 3af477214bef 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `cbd1738`
Default Java	Eclipse Adoptium-11.0.23+9
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6721/2/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6721/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-03-18T03:38:42Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 45s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+1 💚	mvninstall	2m 35s		branch-2 passed
+1 💚	compile	0m 40s		branch-2 passed
+1 💚	javadoc	0m 25s		branch-2 passed
+1 💚	shadedjars	5m 20s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 24s		the patch passed
+1 💚	compile	0m 40s		the patch passed
+1 💚	javac	0m 40s		the patch passed
+1 💚	javadoc	0m 23s		the patch passed
+1 💚	shadedjars	5m 19s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	213m 20s		hbase-server in the patch passed.
		236m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6721/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#6721
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 1dedde4c0e04 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `cbd1738`
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6721/2/testReport/
Max. process+thread count	4309 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6721/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-03-18T04:18:21Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 43s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 19s		branch-2 passed
+1 💚	compile	0m 55s		branch-2 passed
+1 💚	javadoc	0m 28s		branch-2 passed
+1 💚	shadedjars	6m 8s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 58s		the patch passed
+1 💚	compile	0m 55s		the patch passed
+1 💚	javac	0m 55s		the patch passed
-0 ⚠️	javadoc	0m 26s	/results-javadoc-javadoc-hbase-server.txt	hbase-server generated 5 new + 57 unchanged - 0 fixed = 62 total (was 57)
+1 💚	shadedjars	6m 5s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	205m 16s		hbase-server in the patch passed.
		231m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6721/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6721
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 3892b2458f59 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `cbd1738`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6721/2/testReport/
Max. process+thread count	4091 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6721/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-03-18T04:23:50Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 40s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+1 💚	mvninstall	4m 5s		branch-2 passed
+1 💚	compile	0m 51s		branch-2 passed
+1 💚	javadoc	0m 27s		branch-2 passed
+1 💚	shadedjars	6m 29s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 2s		the patch passed
+1 💚	compile	0m 50s		the patch passed
+1 💚	javac	0m 50s		the patch passed
-0 ⚠️	javadoc	0m 25s	/results-javadoc-javadoc-hbase-server.txt	hbase-server generated 12 new + 85 unchanged - 12 fixed = 97 total (was 97)
+1 💚	shadedjars	6m 18s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	216m 8s		hbase-server in the patch passed.
		243m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6721/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#6721
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 4168ab9c5b94 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `cbd1738`
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6721/2/testReport/
Max. process+thread count	4432 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6721/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk · 2025-03-18T08:51:38Z

Spotless failure is not due to formatting issues, but a failure of some plugin to shutdown cleanly,

[ERROR] An internal error occurred during: "Periodic workspace save.".
java.lang.IllegalStateException: Job manager has been shut down.
    at org.eclipse.core.internal.jobs.JobManager.schedule (JobManager.java:1295)
    at org.eclipse.core.internal.jobs.InternalJob.schedule (InternalJob.java:385)
    at org.eclipse.core.runtime.jobs.Job.schedule (Job.java:684)
    at org.eclipse.core.internal.events.AutoBuildJob.build (AutoBuildJob.java:110)
    at org.eclipse.core.internal.events.BuildManager.endTopLevel (BuildManager.java:604)
    at org.eclipse.core.internal.resources.Workspace.endOperation (Workspace.java:1518)
    at org.eclipse.core.internal.resources.SaveManager.save (SaveManager.java:1246)
    at org.eclipse.core.internal.resources.SaveManager.save (SaveManager.java:1143)
    at org.eclipse.core.internal.resources.DelayedSnapshotJob.run (DelayedSnapshotJob.java:55)
    at org.eclipse.core.internal.jobs.Worker.run (Worker.java:63)

ndimiduk added the backport This PR is a back port of some issue or issues already committed to master label Feb 25, 2025

This comment has been minimized.

Sign in to view

ndimiduk force-pushed the 29131-branch-2 branch from 37d1b59 to cbd1738 Compare March 17, 2025 13:46

ndimiduk marked this pull request as ready for review March 17, 2025 13:47

ndimiduk merged commit 636703b into apache:branch-2 Mar 18, 2025
1 check failed

ndimiduk deleted the 29131-branch-2 branch March 18, 2025 08:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backport "HBASE-29131 Introduce the option for post-compaction validation of HFiles (#6700)" to branch-2#6721

Backport "HBASE-29131 Introduce the option for post-compaction validation of HFiles (#6700)" to branch-2#6721
ndimiduk merged 1 commit intoapache:branch-2from
ndimiduk:29131-branch-2

ndimiduk commented Feb 25, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Mar 18, 2025

Uh oh!

Apache-HBase commented Mar 18, 2025

Uh oh!

Apache-HBase commented Mar 18, 2025

Uh oh!

Apache-HBase commented Mar 18, 2025

Uh oh!

ndimiduk commented Mar 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ndimiduk commented Feb 25, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Mar 18, 2025

Uh oh!

Apache-HBase commented Mar 18, 2025

Uh oh!

Apache-HBase commented Mar 18, 2025

Uh oh!

Apache-HBase commented Mar 18, 2025

Uh oh!

ndimiduk commented Mar 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants