HBASE-23218 Increase the flexibility of replication walentry filter interface #760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenOpened
changed the title
|
💔 -1 overall
This message was automatically generated. |
anoopsjohn
reviewed
Oct 29, 2019
| * @return True if we are to filter out the edit. | ||
| */ | ||
| boolean filter(TableName table, long writeTime); | ||
| boolean filter(WALEntry entry); |
Contributor
There was a problem hiding this comment.
Exposing the PB object here is the concern. We did lot of work for 2.0 to avoid this.
Contributor
There was a problem hiding this comment.
Yes, what @anoopsjohn said. We don't want PBs in our API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jira : https://jira.apache.org/jira/browse/HBASE-23218
The current WALEntrySinkFilter filter interface can only filter table and writetime, which is not flexible enough. It often needs to get all the attributes of entry for comprehensive judgment and filtering.