HBASE-29787 Run Yetus General Checks as a GitHub Action (addendum)

[ndimiduk]

Conditionally execute publishing to nightlies.

[github-actions]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 18s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	yamllint	0m 0s		yamllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ master Compile Tests _
+1 💚	spotless	0m 52s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	spotless	0m 37s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 12s		The patch does not generate ASF License warnings.
		3m 18s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://nightlies.apache.org/hbase/HBase-PreCommit-GH-Actions-PR/PR-7638/60/yetus-general-check/output/Dockerfile
GITHUB PR	#7638
Optional Tests	dupname asflicense codespell detsecrets yamllint spotless
uname	Linux 3973db210c49 6.11.0-1018-azure #18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 64dd0e7
Max. process+thread count	42 (vs. ulimit of 30000)
modules	C: . U: .
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[ndimiduk]

Context on https://issues.apache.org/jira/browse/INFRA-27571 . I'm not sure if this tweak will actually work without merging it, though maybe the PR from my external repo will teach us something.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 41s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
			_ Patch Compile Tests _
			_ Other Tests _
		1m 52s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7638/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7638
Optional Tests
uname	Linux ebe734586ea6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 64dd0e7
Max. process+thread count	39 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7638/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 41s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	yamllint	0m 0s		yamllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ master Compile Tests _
+1 💚	spotless	0m 53s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	spotless	0m 41s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 12s		The patch does not generate ASF License warnings.
		3m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7638/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7638
Optional Tests	dupname asflicense codespell detsecrets yamllint spotless
uname	Linux 54c235cb3e73 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 64dd0e7
Max. process+thread count	47 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7638/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[ndimiduk]

Hmm strange. Nothing at all from GHA on #7639

[Apache9]

How do other projects which use GHA store the build result?

[Apache9]

https://github.com/apache/dubbo/actions/runs/21034081969/job/60477885181?pr=16005

This project just uploads the artifacts to github.

https://github.com/apache/dubbo/blob/3.3/.github/workflows/build-and-test-pr.yml

name: "Upload test logs"
        if: always()
        uses: actions/upload-artifact@v4
        with:
          name: integration-test-logs-${{matrix.job_id}}-java${{matrix.java}}
          path: test/logs/*

[Apache9]

OK, we also upload the yetus output to artifacts on github.

So what do we want to upload to nightlies? Can we also upload them to github artifacts?

[ndimiduk]

I started by uploading to GH artifacts, not using nightlies. The trouble is with the links out from the report on the comment -- they need a url for each plugin's output. GH artifacts does not support this. With multiple artifact files (we ship everything from the build) it only permits you to upload an archive and there's no way to deep link into the contents of that archive. So, no links. I built out nightlies support thinking that would be a solution.

To migrate to GHA, it appears that all failures need to be reported to the Checks API. We can use Annotations as well, but not all of our plugins support this (our spotless appears to be one such plugin). For all the plugins we want to run, we'll need to ensure that they report any details properly via annotation. Of course, a human can still download the entire test-patch archive bundle, but the need to know where to find it in the Actions run UI.

[ndimiduk]

Argh this means we don't have use of the hide-old-comments feature either. That will get annoying fast.

I'm going to remove reliance on secrets in this addendum. Let's looks more closely at what remains.

For hiding old comments, I guess we could implement a cron action. Let me add that and y'all can tell me what you think.

And let me see if it's a simple thing to add linecomment support to our spotless extension.