Skip to content

HBASE-29871 During WAL write times out add DataNode address in. the exception message#7719

Open
srinireddy2020 wants to merge 1 commit intoapache:masterfrom
srinireddy2020:HBASE-29871
Open

HBASE-29871 During WAL write times out add DataNode address in. the exception message#7719
srinireddy2020 wants to merge 1 commit intoapache:masterfrom
srinireddy2020:HBASE-29871

Conversation

@srinireddy2020
Copy link
Contributor

For better debug, add datanode address to the exception message during WAL write times out

if (evt instanceof IdleStateEvent && ((IdleStateEvent) evt).state() == READER_IDLE) {
promise
.tryFailure(new IOException("Timeout(" + timeoutMs + "ms) waiting for response"));
promise.tryFailure(new IOException(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srinireddy2020
In other two places we are logging "channel.remoteAddress" in message and here dnInfo.toString.

Can't we keep it consistent?

Copy link
Contributor

@pankaj72981 pankaj72981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants