HBASE-29970 SplitSuccess and SplitTime metrics are no longer used at …#8005
Open
liuxiaocs7 wants to merge 1 commit intoapache:branch-2from
Open
HBASE-29970 SplitSuccess and SplitTime metrics are no longer used at …#8005liuxiaocs7 wants to merge 1 commit intoapache:branch-2from
liuxiaocs7 wants to merge 1 commit intoapache:branch-2from
Conversation
…RegionServer and Table level (apache#7866) Signed-off-by: Duo Zhang <zhangduo@apache.org>
liuxiaocs7
added
the
backport
There was a problem hiding this comment.
Pull request overview
Updates RegionServer/Table metrics to drop unused split success/time metrics while ensuring split request counts are still tracked (including at table level), per HBASE-29970.
Changes:
- Remove
SplitSuccessandSplitTimemetrics from RegionServer and Table metrics sources/interfaces. - Update split request recording to pass table name so table-level
splitRequestCountcan be incremented. - Add/extend unit tests to validate
splitRequestCountat both RegionServer and table-aggregate levels.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitRequest.java | Pass table name into split-request metric update. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServer.java | Change incrSplitRequest to accept table name and forward to table metrics. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTable.java | Remove table-level split success/time methods now unused. |
| hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java | Remove split time/success API and constants. |
| hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableSource.java | Remove split time/success API. |
| hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java | Remove backing metrics and methods for split time/success. |
| hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableSourceImpl.java | Remove backing metrics and methods for split time/success. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionServer.java | Add test to assert server-level splitRequestCount increments. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsTableAggregate.java | Add test to assert table-aggregate splitRequestCount increments only for non-null table. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…RegionServer and Table level (#7866)