HBASE-30055 Correct the configuration in MobFileCompactionChore log#8023
Merged
liuxiaocs7 merged 2 commits intoapache:masterfrom Apr 5, 2026
Merged
HBASE-30055 Correct the configuration in MobFileCompactionChore log#8023liuxiaocs7 merged 2 commits intoapache:masterfrom
liuxiaocs7 merged 2 commits intoapache:masterfrom
Conversation
Member
liuxiaocs7
commented
Apr 3, 2026
liuxiaocs7
commented
- see: HBASE-30055
liuxiaocs7
commented
Apr 3, 2026
| + " all regions will be compacted in parallel", | ||
| htd.getTableName(), hcd.getNameAsString(), "hbase.mob.compaction.batch.size"); | ||
| htd.getTableName(), hcd.getNameAsString(), | ||
| MobConstants.MOB_MAJOR_COMPACTION_REGION_BATCH_SIZE); |
Member
Author
There was a problem hiding this comment.
this.regionBatchSize =
master.getConfiguration().getInt(MobConstants.MOB_MAJOR_COMPACTION_REGION_BATCH_SIZE,
MobConstants.DEFAULT_MOB_MAJOR_COMPACTION_REGION_BATCH_SIZE);we use hbase.mob.major.compaction.region.batch.size rather than hbase.mob.compaction.batch.size here
There was a problem hiding this comment.
Pull request overview
This PR addresses HBASE-30055 by correcting the configuration key shown in MobFileCompactionChore log messages so operators see the actual setting that controls MOB major compaction batching.
Changes:
- Replace the incorrect hardcoded config key in logs with
MobConstants.MOB_MAJOR_COMPACTION_REGION_BATCH_SIZE. - Adjust the related INFO log message to print the config key and configured batch size consistently.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…CompactionChore.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Apache9
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.