HBASE-30080: Send exception to user when refreshing store file fails for a region#8081
Merged
anmolnar merged 1 commit intoapache:HBASE-29081from Apr 14, 2026
Merged
Conversation
anmolnar
requested changes
Apr 14, 2026
Contributor
anmolnar
left a comment
anmolnar
left a comment
There was a problem hiding this comment.
I think we could go much simpler than that. Don't need to catch the exception at all, we don't need to explicitly log it here. Just let it be caught at higher levels, like other Callables do.
Don't need to unit test either.
sharmaar12
force-pushed
the
except_refreshhfiles
branch
from
b12ec65 to
ebed90a
Compare
sharmaar12
force-pushed
the
except_refreshhfiles
branch
from
ebed90a to
a883e0c
Compare
anmolnar
approved these changes
Apr 14, 2026
Contributor
|
Merged. Thanks @sharmaar12 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.