HBASE-30085: Migrate all unit tests to JUnit 5#8096
Merged
taklwu merged 2 commits intoapache:HBASE-29081from Apr 17, 2026
Merged
HBASE-30085: Migrate all unit tests to JUnit 5#8096taklwu merged 2 commits intoapache:HBASE-29081from
taklwu merged 2 commits intoapache:HBASE-29081from
Conversation
taklwu
requested changes
Apr 16, 2026
Contributor
taklwu
left a comment
taklwu
left a comment
There was a problem hiding this comment.
can you check also below files and tests
- assertEquals in TestMasterRegionInitialize#testMasterRegionDirSuffix
- assertFalse and assertTrue in TestMasterMetrics#testClusterMetricsSkippingForeignMetaTable and other tests we added
taklwu
approved these changes
Apr 17, 2026
Contributor
taklwu
left a comment
taklwu
left a comment
There was a problem hiding this comment.
LGTM, thanks for working on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.