Skip to content

HBASE-30059 Upgrade hbase-server to use junit5 Part6#8124

Merged
liuxiaocs7 merged 1 commit into
apache:branch-2.5from
liuxiaocs7:HBASE-30059-branch-2.5
Apr 24, 2026
Merged

HBASE-30059 Upgrade hbase-server to use junit5 Part6#8124
liuxiaocs7 merged 1 commit into
apache:branch-2.5from
liuxiaocs7:HBASE-30059-branch-2.5

Conversation

@liuxiaocs7
Copy link
Copy Markdown
Member

@liuxiaocs7 liuxiaocs7 requested a review from Copilot April 24, 2026 07:27
@liuxiaocs7 liuxiaocs7 added the backport This PR is a back port of some issue or issues already committed to master label Apr 24, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates a set of hbase-server (and related) tests on branch-2.5 from JUnit 4 to JUnit 5 as part of HBASE-30059, updating lifecycle annotations, assertions, and test classification tags.

Changes:

  • Replace JUnit4 annotations (@BeforeClass/@AfterClass/@Before/@After, @Category, @Ignore, @Rule) with JUnit5 equivalents (@BeforeAll/@AfterAll/@BeforeEach/@AfterEach, @Tag, @Disabled, TestInfo/@RegisterExtension).
  • Convert assertions from org.junit.Assert to org.junit.jupiter.api.Assertions (including message-argument ordering changes).
  • Mark TableNameTestRule as deprecated and migrate at least one usage to TableNameTestExtension.

Reviewed changes

Copilot reviewed 43 out of 43 changed files in this pull request and generated no comments.

Show a summary per file
File Description
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionReplicas.java JUnit5 migration: lifecycle + assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/replication/TestModifyPeerProcedureRetryBackoff.java JUnit5 migration: lifecycle + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestWakeUpUnexpectedProcedure.java JUnit5 migration: assertions + lifecycle + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestTransitRegionStateProcedure.java JUnit5 migration: lifecycle + assertions + TestInfo for per-test table name.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestTRSPPersistUninitializedSubProc.java JUnit5 migration: lifecycle + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestSplitTableRegionProcedure.java JUnit5 migration: lifecycle + assertions + TestInfo-derived table naming.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestSCPGetRegionsRace.java JUnit5 migration: assertions + lifecycle + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRollbackSCP.java JUnit5 migration: lifecycle + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRogueRSAssignment.java JUnit5 migration: replace ExpectedException/Ignore with assertThrows/Disabled + TestInfo naming.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestReportRegionStateTransitionRetry.java JUnit5 migration: lifecycle + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestReportRegionStateTransitionFromDeadServer.java JUnit5 migration: assertions + lifecycle + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestReportOnlineRegionsRace.java JUnit5 migration: lifecycle + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionStates.java JUnit5 migration: lifecycle + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionStateStore.java Migrate from TableNameTestRule to TableNameTestExtension + JUnit5 assertions/lifecycle.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionSplitAndSeparateChildren.java JUnit5 migration: lifecycle + assertions + TestInfo naming.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionSplit.java JUnit5 migration: lifecycle + assertions + TestInfo naming.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionReplicaSplit.java JUnit5 migration: lifecycle + tags + TestInfo naming.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionMoveAndAbandon.java JUnit5 migration: lifecycle + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionBypass.java JUnit5 migration: lifecycle + assertions + TestInfo naming.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionAssignedToMultipleRegionServers.java JUnit5 migration: lifecycle + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestReduceExcessRegionReplicasBlockedByRIT.java JUnit5 migration: lifecycle + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRaceBetweenSCPAndTRSP.java JUnit5 migration: lifecycle + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestOpenRegionProcedureHang.java JUnit5 migration: lifecycle + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestOpenRegionProcedureBackoff.java JUnit5 migration: lifecycle + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestModifyTableWhileMerging.java JUnit5 migration: assertions + lifecycle + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestMergeTableRegionsProcedure.java JUnit5 migration: lifecycle + assertions + TestInfo naming.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestMasterAbortWhileMergingTable.java JUnit5 migration: assertions + lifecycle + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestHbckChore.java JUnit5 migration: assertions + lifecycle + tags (base-class test).
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestExceptionInUnassignedRegion.java JUnit5 migration: assertions + lifecycle + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestExceptionInAssignRegion.java JUnit5 migration: assertions + lifecycle + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestDeadServerMetricRegionChore.java JUnit5 migration: lifecycle + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestCloseRegionWhileRSCrash.java JUnit5 migration: lifecycle + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAssignmentOnRSCrash.java JUnit5 migration: lifecycle + assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAssignmentManagerUtil.java JUnit5 migration: lifecycle + assertions + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAssignmentManagerLoadMetaRegionState.java JUnit5 migration: lifecycle + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAssignmentManagerBase.java Base test converted to JUnit5 lifecycle + TestInfo naming support.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAssignmentManager.java JUnit5 migration: assertions + tags; updated to use base’s testMethodName.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAssignRegionToUninitializedRegionServer.java JUnit5 migration: lifecycle + tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAMServerFailedOpen.java JUnit5 migration: tags; updated to use base’s testMethodName.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAMAssignWithRandExec.java JUnit5 migration: tags.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/AssignmentTestingUtil.java JUnit5 migration: static assertion imports.
hbase-server/src/test/java/org/apache/hadoop/hbase/TestMetaTableAccessor.java JUnit5 migration: lifecycle + tags + TestInfo injection for per-test names.
hbase-common/src/test/java/org/apache/hadoop/hbase/TableNameTestRule.java Mark JUnit4 rule as @Deprecated with migration guidance to TableNameTestExtension.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@liuxiaocs7 liuxiaocs7 merged commit b558b84 into apache:branch-2.5 Apr 24, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a back port of some issue or issues already committed to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants