HBASE-30059 Upgrade hbase-server to use junit5 Part6#8124
Merged
Conversation
Member
liuxiaocs7
commented
Apr 24, 2026
- for branch-2.5
- see: HBASE-30059
There was a problem hiding this comment.
Pull request overview
Migrates a set of hbase-server (and related) tests on branch-2.5 from JUnit 4 to JUnit 5 as part of HBASE-30059, updating lifecycle annotations, assertions, and test classification tags.
Changes:
- Replace JUnit4 annotations (
@BeforeClass/@AfterClass/@Before/@After,@Category,@Ignore,@Rule) with JUnit5 equivalents (@BeforeAll/@AfterAll/@BeforeEach/@AfterEach,@Tag,@Disabled,TestInfo/@RegisterExtension). - Convert assertions from
org.junit.Asserttoorg.junit.jupiter.api.Assertions(including message-argument ordering changes). - Mark
TableNameTestRuleas deprecated and migrate at least one usage toTableNameTestExtension.
Reviewed changes
Copilot reviewed 43 out of 43 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionReplicas.java | JUnit5 migration: lifecycle + assertions + tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/replication/TestModifyPeerProcedureRetryBackoff.java | JUnit5 migration: lifecycle + tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestWakeUpUnexpectedProcedure.java | JUnit5 migration: assertions + lifecycle + tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestTransitRegionStateProcedure.java | JUnit5 migration: lifecycle + assertions + TestInfo for per-test table name. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestTRSPPersistUninitializedSubProc.java | JUnit5 migration: lifecycle + tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestSplitTableRegionProcedure.java | JUnit5 migration: lifecycle + assertions + TestInfo-derived table naming. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestSCPGetRegionsRace.java | JUnit5 migration: assertions + lifecycle + tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRollbackSCP.java | JUnit5 migration: lifecycle + tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRogueRSAssignment.java | JUnit5 migration: replace ExpectedException/Ignore with assertThrows/Disabled + TestInfo naming. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestReportRegionStateTransitionRetry.java | JUnit5 migration: lifecycle + tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestReportRegionStateTransitionFromDeadServer.java | JUnit5 migration: assertions + lifecycle + tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestReportOnlineRegionsRace.java | JUnit5 migration: lifecycle + tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionStates.java | JUnit5 migration: lifecycle + tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionStateStore.java | Migrate from TableNameTestRule to TableNameTestExtension + JUnit5 assertions/lifecycle. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionSplitAndSeparateChildren.java | JUnit5 migration: lifecycle + assertions + TestInfo naming. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionSplit.java | JUnit5 migration: lifecycle + assertions + TestInfo naming. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionReplicaSplit.java | JUnit5 migration: lifecycle + tags + TestInfo naming. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionMoveAndAbandon.java | JUnit5 migration: lifecycle + tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionBypass.java | JUnit5 migration: lifecycle + assertions + TestInfo naming. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionAssignedToMultipleRegionServers.java | JUnit5 migration: lifecycle + tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestReduceExcessRegionReplicasBlockedByRIT.java | JUnit5 migration: lifecycle + tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRaceBetweenSCPAndTRSP.java | JUnit5 migration: lifecycle + tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestOpenRegionProcedureHang.java | JUnit5 migration: lifecycle + tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestOpenRegionProcedureBackoff.java | JUnit5 migration: lifecycle + tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestModifyTableWhileMerging.java | JUnit5 migration: assertions + lifecycle + tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestMergeTableRegionsProcedure.java | JUnit5 migration: lifecycle + assertions + TestInfo naming. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestMasterAbortWhileMergingTable.java | JUnit5 migration: assertions + lifecycle + tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestHbckChore.java | JUnit5 migration: assertions + lifecycle + tags (base-class test). |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestExceptionInUnassignedRegion.java | JUnit5 migration: assertions + lifecycle + tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestExceptionInAssignRegion.java | JUnit5 migration: assertions + lifecycle + tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestDeadServerMetricRegionChore.java | JUnit5 migration: lifecycle + tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestCloseRegionWhileRSCrash.java | JUnit5 migration: lifecycle + tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAssignmentOnRSCrash.java | JUnit5 migration: lifecycle + assertions + tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAssignmentManagerUtil.java | JUnit5 migration: lifecycle + assertions + tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAssignmentManagerLoadMetaRegionState.java | JUnit5 migration: lifecycle + tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAssignmentManagerBase.java | Base test converted to JUnit5 lifecycle + TestInfo naming support. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAssignmentManager.java | JUnit5 migration: assertions + tags; updated to use base’s testMethodName. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAssignRegionToUninitializedRegionServer.java | JUnit5 migration: lifecycle + tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAMServerFailedOpen.java | JUnit5 migration: tags; updated to use base’s testMethodName. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAMAssignWithRandExec.java | JUnit5 migration: tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/AssignmentTestingUtil.java | JUnit5 migration: static assertion imports. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/TestMetaTableAccessor.java | JUnit5 migration: lifecycle + tags + TestInfo injection for per-test names. |
| hbase-common/src/test/java/org/apache/hadoop/hbase/TableNameTestRule.java | Mark JUnit4 rule as @Deprecated with migration guidance to TableNameTestExtension. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.