HBASE-30067 Upgrade hbase-server to use junit5 Part10#8137
Merged
liuxiaocs7 merged 1 commit intoapache:branch-2.5from Apr 25, 2026
Merged
HBASE-30067 Upgrade hbase-server to use junit5 Part10#8137liuxiaocs7 merged 1 commit intoapache:branch-2.5from
liuxiaocs7 merged 1 commit intoapache:branch-2.5from
Conversation
Member
liuxiaocs7
commented
Apr 24, 2026
- for branch-2.5
- see: HBASE-30067
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Upgrades a set of hbase-server and hbase-rsgroup tests to JUnit 5 (Jupiter), including parameterized test migrations and shared test helpers.
Changes:
- Migrated many tests from JUnit4 annotations/rules/categories to JUnit5 annotations, assertions, and tags.
- Reworked parameterized tests to use
@HBaseParameterizedTestTemplate+@TestTemplateand JUnit5TestInfo. - Introduced
AbstractTestRpcServerto consolidate common RPC server test behavior across multiple test classes.
Reviewed changes
Copilot reviewed 58 out of 58 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| hbase-server/src/test/java/org/apache/hadoop/hbase/namespace/TestNamespaceAuditor.java | Migrates assertions/annotations to JUnit5 and replaces expected exceptions with assertThrows. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/mob/*.java | Bulk JUnit5 migration; updates parameterized tests and replaces JUnit4 rules with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/*.java | Migrates RPC tests to JUnit5; introduces shared base AbstractTestRpcServer and updates parameterization. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/AbstractTestRpcServer.java | New common base class consolidating table-based RPC verification logic. |
| hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/*.java | Migrates RSGroup tests to JUnit5; updates base class to accept TestInfo. |
| hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestEnableRSGroups.java | Refactors into an abstract base class as part of JUnit5 migration. |
| hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupUtil.java | Removes trailing whitespace line. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.