Skip to content

HBASE-30067 Upgrade hbase-server to use junit5 Part10#8137

Merged
liuxiaocs7 merged 1 commit intoapache:branch-2.5from
liuxiaocs7:HBASE-30067-branch-2.5
Apr 25, 2026
Merged

HBASE-30067 Upgrade hbase-server to use junit5 Part10#8137
liuxiaocs7 merged 1 commit intoapache:branch-2.5from
liuxiaocs7:HBASE-30067-branch-2.5

Conversation

@liuxiaocs7
Copy link
Copy Markdown
Member

@liuxiaocs7 liuxiaocs7 added the backport This PR is a back port of some issue or issues already committed to master label Apr 24, 2026
@liuxiaocs7 liuxiaocs7 requested a review from Copilot April 24, 2026 17:20
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Upgrades a set of hbase-server and hbase-rsgroup tests to JUnit 5 (Jupiter), including parameterized test migrations and shared test helpers.

Changes:

  • Migrated many tests from JUnit4 annotations/rules/categories to JUnit5 annotations, assertions, and tags.
  • Reworked parameterized tests to use @HBaseParameterizedTestTemplate + @TestTemplate and JUnit5 TestInfo.
  • Introduced AbstractTestRpcServer to consolidate common RPC server test behavior across multiple test classes.

Reviewed changes

Copilot reviewed 58 out of 58 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
hbase-server/src/test/java/org/apache/hadoop/hbase/namespace/TestNamespaceAuditor.java Migrates assertions/annotations to JUnit5 and replaces expected exceptions with assertThrows.
hbase-server/src/test/java/org/apache/hadoop/hbase/mob/*.java Bulk JUnit5 migration; updates parameterized tests and replaces JUnit4 rules with TestInfo.
hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/*.java Migrates RPC tests to JUnit5; introduces shared base AbstractTestRpcServer and updates parameterization.
hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/AbstractTestRpcServer.java New common base class consolidating table-based RPC verification logic.
hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/*.java Migrates RSGroup tests to JUnit5; updates base class to accept TestInfo.
hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestEnableRSGroups.java Refactors into an abstract base class as part of JUnit5 migration.
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupUtil.java Removes trailing whitespace line.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@liuxiaocs7 liuxiaocs7 merged commit 2e7d9b0 into apache:branch-2.5 Apr 25, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a back port of some issue or issues already committed to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants