HBASE-30126 Fix mismatched LoggerFactory class references#8152
Merged
liuxiaocs7 merged 2 commits intoapache:masterfrom Apr 28, 2026
Merged
HBASE-30126 Fix mismatched LoggerFactory class references#8152liuxiaocs7 merged 2 commits intoapache:masterfrom
liuxiaocs7 merged 2 commits intoapache:masterfrom
Conversation
Member
liuxiaocs7
commented
Apr 27, 2026
- see: HBASE-30126
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes mismatched LoggerFactory.getLogger(...) class references across several HBase modules so log categories match the declaring class (per HBASE-30126).
Changes:
- Updated
LoggerFactory.getLogger(...)arguments to reference the actual enclosing class (including several test bases and inner classes). - Normalized logger definitions where they were previously pointing at unrelated classes.
Reviewed changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/HThreadedSelectorServerArgs.java | Use the enclosing class for the logger category. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/wal/WALCorruptionDueToDanglingByteBufferTestBase.java | Use the test base class for the logger category. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALSplitToHFile.java | Use the test class for the logger category. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestSnapshotWhenChoreCleaning.java | Use the test class for the logger category. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestMobFlushSnapshotFromClient.java | Use the test class for the logger category. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestConcurrentFlushSnapshotFromClient.java | Use the test class for the logger category (with line wrap). |
| hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController3.java | Use the test class for the logger category. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/rsgroup/EnableRSGroupsTestBase.java | Use the test base class for the logger category. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationStuckWithDroppedTable.java | Use the test class for the logger category. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java | Use the test class for the logger category. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionReplicaFailover.java | Use the test class for the logger category. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java | Use the test class for the logger category. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/namequeues/TestWALEventTracker.java | Use the test class for the logger category. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestMasterProcedureEvents.java | Use the test class for the logger category. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterOperationsForRegionReplicas.java | Use the test class for the logger category (with line wrap). |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/AbstractTestDLS.java | Use the abstract test base class for the logger category. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/client/BasicReadWriteWithDifferentConnectionRegistriesTestBase.java | Use the test base class for the logger category. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractRecoveredEditsOutputSink.java | Use the enclosing abstract class for the logger category. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java | Use the tool class for the logger category. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/security/provider/SaslServerAuthenticationProviders.java | Use the server provider class for the logger category. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceLogQueue.java | Use the log queue class for the logger category. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePreadReader.java | Use the pread reader class for the logger category. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MultiRowMutationEndpoint.java | Use the endpoint class for the logger category. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordination.java | Use the ZK coordination class for the logger category. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/ExecutorStatusChore.java | Use the chore class for the logger category. |
| hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/MetricRegistriesLoader.java | Use the loader class for the logger category. |
| hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/MultiTableInputFormatTestBase.java | Use the test base class for the logger category. |
| hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java | Use the correct inner mapper class for the logger category. |
| hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestServletFilter.java | Use the test class for the logger category. |
| hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestPathFilter.java | Use the test class for the logger category. |
| hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestGlobalFilter.java | Use the test class for the logger category. |
| hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/CompatibilityFactory.java | Use the factory class for the logger category. |
| hbase-common/src/main/java/org/apache/hadoop/hbase/io/compress/ReusableStreamGzipCodec.java | Use the codec class for the logger category. |
| hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java | Use the raw async admin implementation class for the logger category. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 34 out of 34 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Apache9
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.