Skip to content

HBASE-30126 Fix mismatched LoggerFactory class references#8152

Merged
liuxiaocs7 merged 2 commits intoapache:masterfrom
liuxiaocs7:HBASE-30126
Apr 28, 2026
Merged

HBASE-30126 Fix mismatched LoggerFactory class references#8152
liuxiaocs7 merged 2 commits intoapache:masterfrom
liuxiaocs7:HBASE-30126

Conversation

@liuxiaocs7
Copy link
Copy Markdown
Member

@liuxiaocs7 liuxiaocs7 requested a review from Copilot April 27, 2026 15:06
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Fixes mismatched LoggerFactory.getLogger(...) class references across several HBase modules so log categories match the declaring class (per HBASE-30126).

Changes:

  • Updated LoggerFactory.getLogger(...) arguments to reference the actual enclosing class (including several test bases and inner classes).
  • Normalized logger definitions where they were previously pointing at unrelated classes.

Reviewed changes

Copilot reviewed 34 out of 34 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/HThreadedSelectorServerArgs.java Use the enclosing class for the logger category.
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/WALCorruptionDueToDanglingByteBufferTestBase.java Use the test base class for the logger category.
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALSplitToHFile.java Use the test class for the logger category.
hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestSnapshotWhenChoreCleaning.java Use the test class for the logger category.
hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestMobFlushSnapshotFromClient.java Use the test class for the logger category.
hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestConcurrentFlushSnapshotFromClient.java Use the test class for the logger category (with line wrap).
hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController3.java Use the test class for the logger category.
hbase-server/src/test/java/org/apache/hadoop/hbase/rsgroup/EnableRSGroupsTestBase.java Use the test base class for the logger category.
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationStuckWithDroppedTable.java Use the test class for the logger category.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java Use the test class for the logger category.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionReplicaFailover.java Use the test class for the logger category.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java Use the test class for the logger category.
hbase-server/src/test/java/org/apache/hadoop/hbase/namequeues/TestWALEventTracker.java Use the test class for the logger category.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestMasterProcedureEvents.java Use the test class for the logger category.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterOperationsForRegionReplicas.java Use the test class for the logger category (with line wrap).
hbase-server/src/test/java/org/apache/hadoop/hbase/master/AbstractTestDLS.java Use the abstract test base class for the logger category.
hbase-server/src/test/java/org/apache/hadoop/hbase/client/BasicReadWriteWithDifferentConnectionRegistriesTestBase.java Use the test base class for the logger category.
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractRecoveredEditsOutputSink.java Use the enclosing abstract class for the logger category.
hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java Use the tool class for the logger category.
hbase-server/src/main/java/org/apache/hadoop/hbase/security/provider/SaslServerAuthenticationProviders.java Use the server provider class for the logger category.
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceLogQueue.java Use the log queue class for the logger category.
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePreadReader.java Use the pread reader class for the logger category.
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MultiRowMutationEndpoint.java Use the endpoint class for the logger category.
hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordination.java Use the ZK coordination class for the logger category.
hbase-server/src/main/java/org/apache/hadoop/hbase/ExecutorStatusChore.java Use the chore class for the logger category.
hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/MetricRegistriesLoader.java Use the loader class for the logger category.
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/MultiTableInputFormatTestBase.java Use the test base class for the logger category.
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java Use the correct inner mapper class for the logger category.
hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestServletFilter.java Use the test class for the logger category.
hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestPathFilter.java Use the test class for the logger category.
hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestGlobalFilter.java Use the test class for the logger category.
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/CompatibilityFactory.java Use the factory class for the logger category.
hbase-common/src/main/java/org/apache/hadoop/hbase/io/compress/ReusableStreamGzipCodec.java Use the codec class for the logger category.
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java Use the raw async admin implementation class for the logger category.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@liuxiaocs7 liuxiaocs7 requested a review from Copilot April 27, 2026 16:29
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 34 out of 34 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@liuxiaocs7 liuxiaocs7 merged commit 2873eb8 into apache:master Apr 28, 2026
36 of 42 checks passed
liuxiaocs7 added a commit that referenced this pull request Apr 29, 2026
)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants