Skip to content

HBASE-30126 Fix mismatched LoggerFactory class references#8162

Merged
liuxiaocs7 merged 2 commits intoapache:branch-2.5from
liuxiaocs7:HBASE-30126-branch-2.5
Apr 29, 2026
Merged

HBASE-30126 Fix mismatched LoggerFactory class references#8162
liuxiaocs7 merged 2 commits intoapache:branch-2.5from
liuxiaocs7:HBASE-30126-branch-2.5

Conversation

@liuxiaocs7
Copy link
Copy Markdown
Member

@liuxiaocs7 liuxiaocs7 requested a review from Copilot April 29, 2026 04:08
@liuxiaocs7 liuxiaocs7 added the backport This PR is a back port of some issue or issues already committed to master label Apr 29, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes incorrect LoggerFactory.getLogger(...) class references so log categories match the declaring class across several HBase modules (branch-2.5), addressing HBASE-30126.

Changes:

  • Update LoggerFactory.getLogger(...) arguments to reference the local/declaring class (and remove one now-unneeded import).
  • Normalize logger declarations in a few places to follow existing formatting patterns.

Reviewed changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/HThreadedSelectorServerArgs.java Point logger at HThreadedSelectorServerArgs instead of TThreadedSelectorServer.
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/WALCorruptionDueToDanglingByteBufferTestBase.java Point logger at WALCorruptionDueToDanglingByteBufferTestBase.
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALSplitToHFile.java Point logger at TestWALSplitToHFile.
hbase-server/src/test/java/org/apache/hadoop/hbase/tool/BulkLoadHFilesSplitRecoveryTestBase.java Point logger at BulkLoadHFilesSplitRecoveryTestBase.
hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestMobFlushSnapshotFromClient.java Point logger at TestMobFlushSnapshotFromClient.
hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestConcurrentFlushSnapshotFromClient.java Point logger at TestConcurrentFlushSnapshotFromClient (wrapped formatting).
hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController3.java Point logger at TestAccessController3.
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestWALEntrySinkFilter.java Point logger at TestWALEntrySinkFilter.
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationStuckWithDroppedTable.java Point logger at TestReplicationStuckWithDroppedTable.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java Point logger at TestLogRollAbort.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionReplicaFailover.java Point logger at TestRegionReplicaFailover and remove unrelated import.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java Point logger at TestHRegionReplayEvents.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestMasterProcedureEvents.java Point logger at TestMasterProcedureEvents.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterOperationsForRegionReplicas.java Point logger at TestMasterOperationsForRegionReplicas (wrapped formatting).
hbase-server/src/test/java/org/apache/hadoop/hbase/master/AbstractTestDLS.java Point logger at AbstractTestDLS.
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractRecoveredEditsOutputSink.java Point logger at AbstractRecoveredEditsOutputSink.
hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java Point logger at CanaryTool instead of Canary.
hbase-server/src/main/java/org/apache/hadoop/hbase/security/provider/SaslServerAuthenticationProviders.java Point logger at SaslServerAuthenticationProviders.
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceLogQueue.java Point logger at ReplicationSourceLogQueue.
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePreadReader.java Point logger at HFilePreadReader.
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MultiRowMutationEndpoint.java Point logger at MultiRowMutationEndpoint.
hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordination.java Point logger at ZKSplitLogManagerCoordination.
hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/MetricRegistriesLoader.java Point logger at MetricRegistriesLoader.
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java Point CellSortImporter logger at CellSortImporter.
hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestServletFilter.java Point logger at TestServletFilter.
hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestPathFilter.java Point logger at TestPathFilter.
hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestGlobalFilter.java Point logger at TestGlobalFilter.
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/CompatibilityFactory.java Point logger at CompatibilityFactory.
hbase-common/src/main/java/org/apache/hadoop/hbase/io/compress/ReusableStreamGzipCodec.java Point logger at ReusableStreamGzipCodec.
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java Point logger at RawAsyncHBaseAdmin.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@liuxiaocs7
Copy link
Copy Markdown
Member Author

Failed UT are not related, let me merge

@liuxiaocs7 liuxiaocs7 merged commit 55b7bfe into apache:branch-2.5 Apr 29, 2026
26 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a back port of some issue or issues already committed to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants