HBASE-30126 Fix mismatched LoggerFactory class references#8162
Merged
liuxiaocs7 merged 2 commits intoapache:branch-2.5from Apr 29, 2026
Merged
HBASE-30126 Fix mismatched LoggerFactory class references#8162liuxiaocs7 merged 2 commits intoapache:branch-2.5from
liuxiaocs7 merged 2 commits intoapache:branch-2.5from
Conversation
Member
liuxiaocs7
commented
Apr 29, 2026
- for branch-2.5
- see: HBASE-30126
There was a problem hiding this comment.
Pull request overview
Fixes incorrect LoggerFactory.getLogger(...) class references so log categories match the declaring class across several HBase modules (branch-2.5), addressing HBASE-30126.
Changes:
- Update
LoggerFactory.getLogger(...)arguments to reference the local/declaring class (and remove one now-unneeded import). - Normalize logger declarations in a few places to follow existing formatting patterns.
Reviewed changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/HThreadedSelectorServerArgs.java | Point logger at HThreadedSelectorServerArgs instead of TThreadedSelectorServer. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/wal/WALCorruptionDueToDanglingByteBufferTestBase.java | Point logger at WALCorruptionDueToDanglingByteBufferTestBase. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALSplitToHFile.java | Point logger at TestWALSplitToHFile. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/tool/BulkLoadHFilesSplitRecoveryTestBase.java | Point logger at BulkLoadHFilesSplitRecoveryTestBase. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestMobFlushSnapshotFromClient.java | Point logger at TestMobFlushSnapshotFromClient. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestConcurrentFlushSnapshotFromClient.java | Point logger at TestConcurrentFlushSnapshotFromClient (wrapped formatting). |
| hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController3.java | Point logger at TestAccessController3. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestWALEntrySinkFilter.java | Point logger at TestWALEntrySinkFilter. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationStuckWithDroppedTable.java | Point logger at TestReplicationStuckWithDroppedTable. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java | Point logger at TestLogRollAbort. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionReplicaFailover.java | Point logger at TestRegionReplicaFailover and remove unrelated import. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java | Point logger at TestHRegionReplayEvents. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestMasterProcedureEvents.java | Point logger at TestMasterProcedureEvents. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterOperationsForRegionReplicas.java | Point logger at TestMasterOperationsForRegionReplicas (wrapped formatting). |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/AbstractTestDLS.java | Point logger at AbstractTestDLS. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractRecoveredEditsOutputSink.java | Point logger at AbstractRecoveredEditsOutputSink. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java | Point logger at CanaryTool instead of Canary. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/security/provider/SaslServerAuthenticationProviders.java | Point logger at SaslServerAuthenticationProviders. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceLogQueue.java | Point logger at ReplicationSourceLogQueue. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePreadReader.java | Point logger at HFilePreadReader. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MultiRowMutationEndpoint.java | Point logger at MultiRowMutationEndpoint. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordination.java | Point logger at ZKSplitLogManagerCoordination. |
| hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/MetricRegistriesLoader.java | Point logger at MetricRegistriesLoader. |
| hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java | Point CellSortImporter logger at CellSortImporter. |
| hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestServletFilter.java | Point logger at TestServletFilter. |
| hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestPathFilter.java | Point logger at TestPathFilter. |
| hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestGlobalFilter.java | Point logger at TestGlobalFilter. |
| hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/CompatibilityFactory.java | Point logger at CompatibilityFactory. |
| hbase-common/src/main/java/org/apache/hadoop/hbase/io/compress/ReusableStreamGzipCodec.java | Point logger at ReusableStreamGzipCodec. |
| hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java | Point logger at RawAsyncHBaseAdmin. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pankaj72981
approved these changes
Apr 29, 2026
Member
Author
|
Failed UT are not related, let me merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.